Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Sergey Bylokhov
On Thu, 8 Apr 2021 04:27:16 GMT, Prasanta Sadhukhan wrote: >>> The behavior is not a javadoc bug. If a method is overridden with no >>> specified change in behavior, the method will be documented in the "Methods >>> Declared In ..." list at the end of the main summary table. >> >> If it is

Re: RFR: 8264398: BevelBorderUIResource​(int, Color, Color) spec should mention that the passed colors are for highlightInner and shadowOuter props [v3]

2021-04-07 Thread Prasanta Sadhukhan
> The current spec for > javax/swing/plaf/BorderUIResource.BevelBorderUIResource.html(int,java.awt.Color,java.awt.Color) > does not clearly specify the usage of color for hightlight and shadow as > there are outer/inner hightlight and outer/inner shadow. > Updated spec to clarify the same.

Re: RFR: 8264398: BevelBorderUIResource​(int, Color, Color) spec should mention that the passed colors are for highlightInner and shadowOuter props

2021-04-07 Thread Sergey Bylokhov
On Thu, 8 Apr 2021 04:31:12 GMT, Prasanta Sadhukhan wrote: > I don't think the spec is coped from BevelBorder...Yes, the spec is inspired > by how BevelBorder treates the shadow/highlight color! The BevelBorderUIResource is just a tagged wrapper on top of the BevelBorder, it does not provide

Integrated: 8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to

2021-04-07 Thread Prasanta Sadhukhan
On Tue, 23 Mar 2021 06:10:32 GMT, Prasanta Sadhukhan wrote: > Specification for method > javax/swing/CellRendererPane.html#paintComponent(java.awt.Graphics,java.awt.Component,java.awt.Container,java.awt.Rectangle) > is not perfectly clear which method the call is delegated to. > > Updated

Re: RFR: 8264398: BevelBorderUIResource​(int, Color, Color) spec should mention that the passed colors are for highlightInner and shadowOuter props

2021-04-07 Thread Prasanta Sadhukhan
On Thu, 8 Apr 2021 04:27:02 GMT, Sergey Bylokhov wrote: >> Not sure I understand...The change is still in BevelorderUIResource(int, >> Color, Color) method so what should be changed in PR title? > >> Not sure I understand...The change is still in BevelorderUIResource(int, >> Color, Color)

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Prasanta Sadhukhan
On Thu, 8 Apr 2021 00:37:57 GMT, Sergey Bylokhov wrote: >> The behavior is not a javadoc bug. >> >> If a method is overridden with no specified change in behavior, the >> method will be documented in the "Methods Declared In ..." list at the >> end of the main summary table. >> >> -- Jon >>

Re: RFR: 8264398: BevelBorderUIResource​(int, Color, Color) spec should mention that the passed colors are for highlightInner and shadowOuter props

2021-04-07 Thread Sergey Bylokhov
On Thu, 8 Apr 2021 04:20:16 GMT, Prasanta Sadhukhan wrote: > Not sure I understand...The change is still in BevelorderUIResource(int, > Color, Color) method so what should be changed in PR title? It should be Bevelorder as well, the class from where the spec is copied to the

Re: RFR: 8264398: BevelBorderUIResource​(int, Color, Color) spec should mention that the passed colors are for highlightInner and shadowOuter props

2021-04-07 Thread Prasanta Sadhukhan
On Thu, 8 Apr 2021 01:00:37 GMT, Sergey Bylokhov wrote: >> Please update the title of the bug/PR, since the change now in another class. > > BevelBorder vs BevelBorderUIResource. The BevelBorderUIResource is a > UIResource version of BevelBorder and its spec is just a copy. Not sure I

Re: RFR: 8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to [v3]

2021-04-07 Thread Prasanta Sadhukhan
> Specification for method > javax/swing/CellRendererPane.html#paintComponent(java.awt.Graphics,java.awt.Component,java.awt.Container,java.awt.Rectangle) > is not perfectly clear which method the call is delegated to. > > Updated spec to clarify. Prasanta Sadhukhan has updated the pull request

Re: RFR: 8264398: BevelBorderUIResource​(int, Color, Color) spec should mention that the passed colors are for highlightInner and shadowOuter props

2021-04-07 Thread Sergey Bylokhov
On Thu, 8 Apr 2021 00:56:34 GMT, Sergey Bylokhov wrote: >> In this context and BevelBorder context, 'derived' is used for >> brighter/darker version of the same color and as per Color.brighter method >>

Re: RFR: 8264398: BevelBorderUIResource​(int, Color, Color) spec should mention that the passed colors are for highlightInner and shadowOuter props

2021-04-07 Thread Sergey Bylokhov
On Tue, 6 Apr 2021 12:31:00 GMT, Prasanta Sadhukhan wrote: >> Does 'derived' in javax.swing domain mean the color would be different, or >> 'equal color' also qualifies as 'derived' javax.swing? > > In this context and BevelBorder context, 'derived' is used for > brighter/darker version of

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Sergey Bylokhov
On Thu, 8 Apr 2021 00:16:29 GMT, Jonathan Gibbons wrote: > The behavior is not a javadoc bug. If a method is overridden with no > specified change in behavior, the method will be documented in the "Methods > Declared In ..." list at the end of the main summary table. If it is not a bug it is

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Jonathan Gibbons
On Wed, 7 Apr 2021 20:34:22 GMT, Alexey Ivanov wrote: >>> I dont see any update in JDK-8264217. Is this then considered to be a >>> javadoc bug? >> >> It does not matter is it a JavaDoc bug or feature. If it is a bug it will be >> fixed and spec will be returned for the current method. If it

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Alexey Ivanov
On Wed, 7 Apr 2021 20:06:46 GMT, Sergey Bylokhov wrote: > > I dont see any update in JDK-8264217. Is this then considered to be a > > javadoc bug? > > It does not matter is it a JavaDoc bug or feature. If it is a bug it will be > fixed and spec will be returned for the current method. If it

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-04-07 Thread Sergey Bylokhov
On Mon, 5 Apr 2021 18:47:25 GMT, Pankaj Bansal wrote: >> Ok, please file a similar bug for the windows platform. > > @mrserb @azuev-java Any other comments on this? Can you please look at the > CSR also? I have no additional comments. - PR:

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Sergey Bylokhov
On Wed, 7 Apr 2021 03:32:35 GMT, Prasanta Sadhukhan wrote: > I dont see any update in JDK-8264217. Is this then considered to be a javadoc > bug? It does not matter is it a JavaDoc bug or feature. If it is a bug it will be fixed and spec will be returned for the current method. If it is an

Re: RFR: 8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to [v2]

2021-04-07 Thread Sergey Bylokhov
On Wed, 7 Apr 2021 03:21:13 GMT, Prasanta Sadhukhan wrote: >> Specification for method >> javax/swing/CellRendererPane.html#paintComponent(java.awt.Graphics,java.awt.Component,java.awt.Container,java.awt.Rectangle) >> is not perfectly clear which method the call is delegated to. >> >> Updated

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v3]

2021-04-07 Thread Alexey Ivanov
On Wed, 7 Apr 2021 06:39:48 GMT, Andrey Turbanov wrote: >> There are few possible cleanups in java.desktop related to legacy >> StringBuffer usages: >> 1. In few places StringBuffer can be replaced with plain String >> concatenation. >> 2. StringBuffer can be replaced with StringBuilder.

Re: RFR: 8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to [v2]

2021-04-07 Thread Alexey Ivanov
On Wed, 7 Apr 2021 03:21:13 GMT, Prasanta Sadhukhan wrote: >> Specification for method >> javax/swing/CellRendererPane.html#paintComponent(java.awt.Graphics,java.awt.Component,java.awt.Container,java.awt.Rectangle) >> is not perfectly clear which method the call is delegated to. >> >> Updated

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v3]

2021-04-07 Thread Alexander Zvegintsev
On Wed, 7 Apr 2021 06:39:48 GMT, Andrey Turbanov wrote: >> There are few possible cleanups in java.desktop related to legacy >> StringBuffer usages: >> 1. In few places StringBuffer can be replaced with plain String >> concatenation. >> 2. StringBuffer can be replaced with StringBuilder.

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v3]

2021-04-07 Thread Andrey Turbanov
On Tue, 30 Mar 2021 15:46:56 GMT, Alexander Zvegintsev wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> [PATCH] Replace uses of StringBuffer with StringBuilder in java.desktop >> >> fix copyright year > >

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v3]

2021-04-07 Thread Andrey Turbanov
> There are few possible cleanups in java.desktop related to legacy > StringBuffer usages: > 1. In few places StringBuffer can be replaced with plain String concatenation. > 2. StringBuffer can be replaced with StringBuilder. StringBuilder has better > performance as it is not thread-safe. > 3.

Integrated: 8264680: Use the blessed modifier order in java.desktop

2021-04-07 Thread Alex Blewitt
On Sat, 3 Apr 2021 22:03:44 GMT, Alex Blewitt wrote: > 8264680: Use the blessed modifier order in java.desktop This pull request has now been integrated. Changeset: 92fad1b4 Author:Alex Blewitt Committer: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/92fad1b4 Stats: