Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

2019-06-21 Thread Jonathan Gibbons
"Invisible" captions need to be discussed for our documentation in general. Although is optional for HTML 5, the accessibility guidelines that we follow require that we use it. We need to work to provide useful (and visible) captions on tables. -- Jon On 06/21/2019 01:54 PM, Alexey Ivanov

Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

2019-06-21 Thread Alexey Ivanov
On 20/06/2019 01:00, Sergey Bylokhov wrote: On 12/06/2019 07:09, Alexey Ivanov wrote: I'd rather leave bold rendering for keys, I think it makes sense. Yet it's up to you to decide. Something like this? http://cr.openjdk.java.net/~serb/8225146/webrev.03

Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

2019-06-19 Thread Sergey Bylokhov
On 12/06/2019 07:09, Alexey Ivanov wrote: However, I'd prefer a more “verbose” version of element, I mean with added line-breaks and indents unless we're saving disk space. I also wonder whether it's preserved intact after passing through javadoc.



Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

On 11/06/2019 22:26, Sergey Bylokhov wrote: On 11/06/2019 14:11, Alexey Ivanov wrote: Is style="font-weight:normal" necessary for each inside ? I tried to set the style to tbody itself and it does not work, will check your suggestion below. But before that, I would like to confirm that

Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

On 11/06/2019 14:26, Sergey Bylokhov wrote: Is style="font-weight:normal" necessary for each inside ? It works, thank you for suggestion: http://cr.openjdk.java.net/~serb/8225146/webrev.02

Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

On 11/06/2019 14:11, Alexey Ivanov wrote: Is style="font-weight:normal" necessary for each inside ? I tried to set the style to tbody itself and it does not work, will check your suggestion below. But before that, I would like to confirm that the "bold-version"(webrev.00) is not good

Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

Hi Sergey, Is style="font-weight:normal" necessary for each inside ? (The previous version defaulted to bold rendering.) If yes, is it possible to add a stylesheet to handle this for the entire page?     tbody th {     font-weight: normal;     } Should the title of the page use title

[13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8225146 Fix: http://cr.openjdk.java.net/~serb/8225146/webrev.01 Accessibility support was improved for "nimbus/doc-files/properties.html" file, the next changes were done: - I have renumbered old h1 tags to