Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

The fix looks good to me. Thanks, Alexandr. On 7/22/2016 12:14 PM, Rajeev Chamyal wrote: Hello Semyon, Your suggestion regarding _NET_WM_ICON requires some investigation and can be implemented as separate bug. Could you please review the webrev.

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Linked to 8147648, added prefix Hidpi. Regards, Rajeev Chamyal From: Semyon Sadetsky Sent: 22 July 2016 15:51 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

On 7/22/2016 1:04 PM, Rajeev Chamyal wrote: Hello Semyon, Below is the bug id. https://bugs.openjdk.java.net/browse/JDK-8162387 Please add [hidpi] prefix to the title. Also link it to the JDK-8147648. --Semyon Regards, Rajeev Chamyal *From:*Semyon Sadetsky *Sent:* 22 July 2016 15:21

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello Semyon, Below is the bug id. https://bugs.openjdk.java.net/browse/JDK-8162387 Regards, Rajeev Chamyal From: Semyon Sadetsky Sent: 22 July 2016 15:21 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: [9] Review Request

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

On 7/22/2016 12:14 PM, Rajeev Chamyal wrote: Hello Semyon, Your suggestion regarding _NET_WM_ICON requires some investigation and can be implemented as separate bug. Ok. Please create this bug. --Semyon Could you please review the webrev.

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello Semyon, Your suggestion regarding _NET_WM_ICON requires some investigation and can be implemented as separate bug. Could you please review the webrev. HYPERLINK "http://cr.openjdk.java.net/%7Erchamyal/8147648/webrev.03/"http://cr.openjdk.java.net/~rchamyal/8147648/webrev.03/

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

On 7/21/2016 5:25 PM, Rajeev Chamyal wrote: Hello Semyon, The resolution variant image returned is based on the implementation of BaseMultiResolutionImage::getResolutionVariant API. Current implementation of BaseMultiResolutionImage::getResolutionVariant returns a resolution variant image

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello Semyon, The resolution variant image returned is based on the implementation of BaseMultiResolutionImage::getResolutionVariant API. Current implementation of BaseMultiResolutionImage::getResolutionVariant returns a resolution variant image which has width and height greater than or

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

On 7/21/2016 11:49 AM, Semyon Sadetsky wrote: Hello Rajeev, The taskbar icon is ok now. I change the resolution variants from the test a bit: final BaseMultiResolutionImage IMG = new BaseMultiResolutionImage( new BufferedImage[]{generateImage(4,

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello Rajeev, The taskbar icon is ok now. I change the resolution variants from the test a bit: final BaseMultiResolutionImage IMG = new BaseMultiResolutionImage( new BufferedImage[]{generateImage(4, Color.RED), generateImage(10, Color.BLUE)}); And

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello Semyon, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147648/webrev.03/ Regards, Rajeev Chamyal From: Semyon Sadetsky Sent: 14 July 2016 16:58 To: Rajeev Chamyal; swing-dev@openjdk.java.net; Sergey Bylokhov; Alexander Scherbatiy Subject: Re: [9]

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hi Rajeev, I have added 1px border to the icon in your test: private static BufferedImage generateImage(int scale, Color c) { int x = SZ * scale; BufferedImage img = new BufferedImage(x, x, BufferedImage.TYPE_INT_RGB); Graphics g = img.getGraphics(); if (g

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello Sergey, Could you please review this fix. http://cr.openjdk.java.net/~rchamyal/8147648/webrev.01/ Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 22 June 2016 15:46 To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: [9] Review Request

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

The fix looks good to me. Thanks, Alexandr. On 6/22/2016 10:49 AM, Rajeev Chamyal wrote: Hello Alexandr, Thanks for the review. I have updated webrev as per comments. http://cr.openjdk.java.net/~rchamyal/8147648/webrev.01/

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello Alexandr, Thanks for the review. I have updated webrev as per comments. http://cr.openjdk.java.net/~rchamyal/8147648/webrev.01/ Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 21 June 2016 17:37 To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net Subject:

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

On 6/21/2016 12:16 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Webrev: http://cr.openjdk.java.net/~rchamyal/8147648/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8147648 Issue: Wrong

[9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello All, Please review the following webrev. Webrev: http://cr.openjdk.java.net/~rchamyal/8147648/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8147648 Issue: Wrong resolution variant is used as icon in the Unity panel. Cause: The screen transforms are not applied to