Re: [9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

2016-10-25 Thread Sergey Bylokhov
On 25.10.16 21:19, Phil Race wrote: Hi, OK with the change below and the rest of the explanation this is probably good to go .. What is the reason to remove(instead of append it) old code which describe what the method do, for example: - * Sets the row height, this is forwarded to the t

Re: [9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

2016-10-25 Thread Phil Race
Hi, OK with the change below and the rest of the explanation this is probably good to go .. -phil. On 07/18/2016 10:37 AM, Semyon Sadetsky wrote: O.k. I would use "displayed" because it simply proxies tree.isRootVisible() which has "displayed" in its specs. Returns whether the root no

Re: [9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

2016-07-18 Thread Semyon Sadetsky
On 7/18/2016 7:29 PM, Phil Race wrote: /** - * Sets the {@code TreeCellRenderer} to {@code tcr}. This invokes - * {@code updateRenderer}. + * Called when the {@code cellRenderer} property is changed in + * the drawn tree component. * - * @param tcr the new value + *

Re: [9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

2016-07-18 Thread Phil Race
/** - * Sets the {@code TreeCellRenderer} to {@code tcr}. This invokes - * {@code updateRenderer}. + * Called when the {@code cellRenderer} property is changed in + * the drawn tree component. * - * @param tcr the new value + * @param tcr the new value of the {@c

Re: [9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

2016-06-21 Thread Alexandr Scherbatiy
On 6/14/2016 5:37 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-7020860 webrev: http://cr.openjdk.java.net/~ssadetsky/7020860/webrev.00/ The methods mentioned in JIRA are not getters/setters according to JavaBeans specs, neverthel

[9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

2016-06-14 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-7020860 webrev: http://cr.openjdk.java.net/~ssadetsky/7020860/webrev.00/ The methods mentioned in JIRA are not getters/setters according to JavaBeans specs, nevertheless some of them got wrong javadocs. The prop