Hello Dmitry
Looks good!
Thanks
alexp
On 10/9/2014 12:08 PM, dmitry markov wrote:
I ran related JCK and regression tests and did not observe any failures.
Thanks,
Dmitry
On 08/10/2014 16:04, Alexander Scherbatiy wrote:
The fix looks good to me.
Could you also test the fix with the JCK
I ran related JCK and regression tests and did not observe any failures.
Thanks,
Dmitry
On 08/10/2014 16:04, Alexander Scherbatiy wrote:
The fix looks good to me.
Could you also test the fix with the JCK and regression tests?
Thanks,
Alexandr.
On 10/8/2014 2:08 PM, dmitry markov wrot
The fix looks good to me.
Could you also test the fix with the JCK and regression tests?
Thanks,
Alexandr.
On 10/8/2014 2:08 PM, dmitry markov wrote:
Hi Alexandr,
Thank you for the review.
HTMLDocument does not override getLength() method, so
AbstractDocument.getLength() is used. A
Hi Alexandr,
Thank you for the review.
HTMLDocument does not override getLength() method, so
AbstractDocument.getLength() is used. AbstractDocument.getLength()
returns one less than the length of the Content (see Java Docs for more
details). So if we add anything to the end of the document, w
On 10/8/2014 10:32 AM, dmitry markov wrote:
Hello,
Any volunteers to review the fix?
Could you give more details about the change:
-
-if (offset > getLength()) {
+if (offset > (getLength() + 1)) {
offset--;
}
---
Hello,
Any volunteers to review the fix?
Thanks,
Dmitry
On 03/10/2014 09:58, dmitry markov wrote:
Hello,
Friendly reminder... Could anyone review the fix, please?
Thanks,
Dmitry
On 29/09/2014 11:10, dmitry markov wrote:
Hello,
Could you review the fix for jdk9, please?
bug: https://bu
Hello,
Friendly reminder... Could anyone review the fix, please?
Thanks,
Dmitry
On 29/09/2014 11:10, dmitry markov wrote:
Hello,
Could you review the fix for jdk9, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8058120
webrev: http://cr.openjdk.java.net/~dmarkov/8058120/jdk9/we
Hello,
Could you review the fix for jdk9, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8058120
webrev: http://cr.openjdk.java.net/~dmarkov/8058120/jdk9/webrev.00/
Problem description: if some text (not wrapped by HTML tags) is inserted
via insertAfterEnd() method, the text is
