The fix looks good to me.
Thanks,
Alexandr.
On 11/29/2016 7:42 PM, Semyon Sadetsky wrote:
Please review the updated webrev:
http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.03/
changes:
- according to Sergey's suggestion in the specs term "focusable" is
replaced with "can be the focus
Looks fine to me.
The only question I have: is "enable" state missing in the javadoc of
the parent method, or is was intentional?
take a look to the parent method where the
next states are covered "displayable, focusable, visible"(enable state
is missing??).
--
Best regards, Sergey.
Please review the updated webrev:
http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.03/
changes:
- according to Sergey's suggestion in the specs term "focusable" is
replaced with "can be the focus owner".
--Semyon
On 11/29/2016 6:34 PM, Sergey Bylokhov wrote:
On 29.11.16 17:52, Semyon
On 29.11.16 17:52, Semyon Sadetsky wrote:
On 11/29/2016 5:41 PM, Sergey Bylokhov wrote:
On 24.11.16 18:34, Semyon Sadetsky wrote:
Yes they are different and can results the different results, but
currently spec says the opposite: "(1) method execution is the same as
calling (2)". It will be goo
On 11/29/2016 5:41 PM, Sergey Bylokhov wrote:
On 24.11.16 18:34, Semyon Sadetsky wrote:
Yes they are different and can results the different results, but
currently spec says the opposite: "(1) method execution is the same as
calling (2)". It will be good to rephrase it somehow that we will try
On 24.11.16 18:34, Semyon Sadetsky wrote:
Yes they are different and can results the different results, but
currently spec says the opposite: "(1) method execution is the same as
calling (2)". It will be good to rephrase it somehow that we will try
to move focus to the selected component.
I stil
On 24.11.2016 17:08, Sergey Bylokhov wrote:
On 14.11.16 19:41, Semyon Sadetsky wrote:
247 * If this toggle button is a member of the {@link
ButtonGroup}
which has
248 * an another ***focusable*** toggle button selected, and the
focus cause argument
in Swing a component may not re
On 14.11.16 19:41, Semyon Sadetsky wrote:
247 * If this toggle button is a member of the {@link ButtonGroup}
which has
248 * an another ***focusable*** toggle button selected, and the
focus cause argument
in Swing a component may not receive focus if it is disabled, invisible,
non-di
On 14.11.2016 16:24, Sergey Bylokhov wrote:
On 14.11.16 12:16, Semyon Sadetsky wrote:
But what about the question to specification, is it the spac below is
true when the selected toggle button is disabled?:
48 * If this toggle button is a member of the {@link ButtonGroup}
which has an another
On 14.11.16 12:16, Semyon Sadetsky wrote:
But what about the question to specification, is it the spac below is
true when the selected toggle button is disabled?:
48 * If this toggle button is a member of the {@link ButtonGroup}
which has an another focusable toggle button selected, and the focu
On 11/8/2016 4:00 PM, Sergey Bylokhov wrote:
On 02.11.16 10:51, Semyon Sadetsky wrote:
On 11/1/2016 10:37 PM, Sergey Bylokhov wrote:
On 28.10.16 11:20, Semyon Sadetsky wrote:
probably it is possible to change the while loop to something?
just to
hide the usage of Enumeration? like
Enumirat
On 02.11.16 10:51, Semyon Sadetsky wrote:
On 11/1/2016 10:37 PM, Sergey Bylokhov wrote:
On 28.10.16 11:20, Semyon Sadetsky wrote:
probably it is possible to change the while loop to something? just to
hide the usage of Enumeration? like
Enumiration.asIterator().forEachRemaining()?
I did not g
On 11/1/2016 10:37 PM, Sergey Bylokhov wrote:
On 28.10.16 11:20, Semyon Sadetsky wrote:
probably it is possible to change the while loop to something? just to
hide the usage of Enumeration? like
Enumiration.asIterator().forEachRemaining()?
I did not get why. What is wrong with Enumeration?
I
On 28.10.16 11:20, Semyon Sadetsky wrote:
probably it is possible to change the while loop to something? just to
hide the usage of Enumeration? like
Enumiration.asIterator().forEachRemaining()?
I did not get why. What is wrong with Enumeration?
It is an old style iterator, and we can hide its
On 10/27/2016 3:40 PM, Sergey Bylokhov wrote:
On 27.10.16 8:56, Semyon Sadetsky wrote:
Thank you, Alexander. Please review the updated webrev:
http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.01/
probably it is possible to change the while loop to something? just to
hide the usage of Enu
On 27.10.16 8:56, Semyon Sadetsky wrote:
Thank you, Alexander. Please review the updated webrev:
http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.01/
probably it is possible to change the while loop to something? just to
hide the usage of Enumeration? like
Enumiration.asIterator().forEach
Thank you, Alexander. Please review the updated webrev:
http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.01/
CCC request will be filed after the fix is approved.
--Semyon
On 10/25/2016 3:14 PM, Alexandr Scherbatiy wrote:
On 10/19/2016 8:14 PM, Semyon Sadetsky wrote:
Hello,
Please revie
On 10/19/2016 8:14 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8074883
webrev: http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.00/
To avoid unexpected selection change the selected button of a button
group should always gra
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8074883
webrev: http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.00/
To avoid unexpected selection change the selected button of a button
group should always grab focus when focus is transferred form componen
19 matches
Mail list logo
