Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-13 Thread Alexey Ivanov
Hi Mikhail, Thanks! Looks great now! Regards, Alexey On 12.05.2016 18:54, Alexander Potochkin wrote: Hello Mikhail Looks great! Thanks alexp On 5/12/2016 5:53 PM, Alexey Ivanov wrote: 56 while (!parsingDone && System.currentTimeMillis() - s < 5_000) { Check for exception was added:

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread Sergey Bylokhov
So there was no performance difference if you used char[] or String.charAt()? On 12.05.16 15:33, mikhail cherkasov wrote: and one more small update: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.04/ I removed START_COMMENT_CHARS and END_COMMENT_CHARS variables and instead of them use

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread Alexander Potochkin
Hello Mikhail Looks great! Thanks alexp On 5/12/2016 5:53 PM, Alexey Ivanov wrote: 56 while (!parsingDone && System.currentTimeMillis() - s < 5_000) { Check for exception was added: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.05/

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread mikhail cherkasov
On 5/12/2016 5:53 PM, Alexey Ivanov wrote: 56 while (!parsingDone && System.currentTimeMillis() - s < 5_000) { Check for exception was added: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.05/

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread Alexey Ivanov
Hi Mikhail, On 12.05.2016 12:47, mikhail cherkasov wrote: On 5/12/2016 12:18 PM, Alexey Ivanov wrote: HTMLEditorKit htmlKit = new HTMLEditorKit(); Document doc = htmlKit.createDefaultDocument(); htmlKit.read(new FileReader(...), doc, 0); Thank you for advice, this works fine:

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread mikhail cherkasov
On 5/12/2016 12:18 PM, Alexey Ivanov wrote: HTMLEditorKit htmlKit = new HTMLEditorKit(); Document doc = htmlKit.createDefaultDocument(); htmlKit.read(new FileReader(...), doc, 0); Thank you for advice, this works fine: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.03/

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread Alexey Ivanov
Hi Mikhail, Source code changes look good now. Please also see my comments below. On 11.05.2016 23:11, mikhail cherkasov wrote: Please see update version: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.02 >You don't need to create JEditorPane, you can instantiate HTMLDocument directly

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-11 Thread mikhail cherkasov
Please see update version: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.02 >You don't need to create JEditorPane, you can instantiate HTMLDocument directly with new HTMLDocument(). without JEditorPane parser will be null in HTMLDocument, so it's the easiest way to init HTMLDocument right

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-11 Thread Alexey Ivanov
Hi Mikhail, Can I ask you to add one space between if, while and the opening parenthesis which is in according to Java Coding Style? In your test, you use none of JFrame methods, then why do you extend JFrame? You don't need to create JEditorPane, you can instantiate HTMLDocument directly

[9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-11 Thread mikhail cherkasov
Hi all, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8078268 webrev: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.01/ The problem is in the following line: