I notice that there is a variable that was already there (not one you
added this time) also mis-spelled : isFPMethodOverriden I'd prefer that
be fixed in this push but I don't need to see an updated webrev for
that. Comments about threading noted. +1 -phil.
On 12/20/2016 12:52 PM, Alexandr S
On 12/16/2016 2:36 AM, Phil Race wrote:
I just noticed that you spell the new methods with a single d :eg :
getFPMethodOverriden
Like the variables that were there before it should be
getFPMethodOverridden
and checkFPMethodOverridden
Here is the updated fix where the typo is updated:
Looks fine.
>
>
> Hello,
>
> Could you review the updated fix:
> http://cr.openjdk.java.net/~alexsch/8169922/webrev.01
>
> - the HashMap is stored in SoftRefence
> - the typo in getMethodArguments() is fixed
> - classes FPMethodItem and FPMethodArgs are defined in the PlainView class.
>
> Th
I just noticed that you spell the new methods with a single d :eg :
getFPMethodOverriden
Like the variables that were there before it should be getFPMethodOverridden
and checkFPMethodOverridden
Also, although rather unlikely to be a problem in practice, since there
is nothing in the swing rules
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8169922/webrev.01
- the HashMap is stored in SoftRefence
- the typo in getMethodArguments() is fixed
- classes FPMethodItem and FPMethodArgs are defined in the PlainView class.
Thanks,
Alexandr.
On 12/14/2016 8:30
Hi, Alexander.
Should not the storage be based on soft references? In the current solution we
will store the references to the checked classes forever in the static map.
> 13 дек. 2016 г., в 18:41, Alexandr Scherbatiy
> написал(а):
>
>
> Hello,
>
> Could you review the fix:
> bug: https://b
821
822 static boolean getFPMethodOverriden(Class cls, String method,
823 FPMethodArgs methodArgs) {
824 FPMethodItem methodItem = new FPMethodItem(cls, method); Where are
the definitions of the types FPMethodItem and FPMethodArgs ?
842 methodArgs.getMethodAruments(false),
843 methodArgs.getMe
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8169922
webrev: http://cr.openjdk.java.net/~alexsch/8169922/webrev.00
The fix JDK-8156217 checks presence of the overridden methods with
floating point arguments.
The proposed fix caches results of found ove
