Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-03-12 Thread Shashidhara Veerabhadraiah
Race Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash   Hello, I strongly recommend using     String.strip rather than     String.trim as Strim.trim uses a idosyncratic definition

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-03-08 Thread Joe Darcy
*Cc:* awt-...@openjdk.java.net; Joe Darcy ; swing-dev@openjdk.java.net *Subject:* Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash Ok but you need to wait for the CSR to be approved before you can push. -phil. On 3/8/19, 11:41 AM, Shashidhara Veer

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-03-07 Thread Shashidhara Veerabhadraiah
oracle.com"; Cc: HYPERLINK "mailto:awt-...@openjdk.java.net"awt-...@openjdk.java.net; Joe Darcy HYPERLINK "mailto:joe.da...@oracle.com";; HYPERLINK "mailto:swing-dev@openjdk.java.net"swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibilit

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-03-07 Thread Philip Race
Darcy mailto:joe.da...@oracle.com>> *Subject:* Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash the webrev needs a couple of minor tweaks : contains empty string -> is the empty string and immeadiately -> immediately Go ahead and fin

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-03-07 Thread Shashidhara Veerabhadraiah
-...@openjdk.java.net; Joe Darcy ; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash   Thank you Phil for the review and here are the updates done:   HYPERLINK "http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.08/

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-03-07 Thread Shashidhara Veerabhadraiah
0:42 PM To: Shashidhara Veerabhadraiah Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net; Joe Darcy Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash   the webrev needs a couple of minor tweaks :   contains empty string -> is the

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-03-06 Thread Philip Race
*Shashidhara Veerabhadraiah *Sent:* Monday, March 4, 2019 3:36 PM *To:* Philip Race ; Joe Darcy *Cc:* awt-...@openjdk.java.net; swing-dev@openjdk.java.net *Subject:* Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash Hi Joe, Please find the updated W

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-03-05 Thread Shashidhara Veerabhadraiah
: Shashidhara Veerabhadraiah Sent: Monday, March 4, 2019 3:36 PM To: Philip Race ; Joe Darcy Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash   Hi Joe, Please find the updated Webrev fixing

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-03-04 Thread Shashidhara Veerabhadraiah
-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash   Hi Joe, Please find the new Webrev fixing the specification as asked in the CSR bug: https://bugs.openjdk.java.net/browse/JDK-8218737   Webrev: http

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-02-21 Thread Shashidhara Veerabhadraiah
, February 18, 2019 10:19 AM To: Philip Race Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash   Thank you Phil for that help on CSR.   From: Phil Race Sent: Friday, February 15, 2019 9:41 PM

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-02-17 Thread Shashidhara Veerabhadraiah
y Bylokhov HYPERLINK "mailto:sergey.bylok...@oracle.com";; HYPERLINK "mailto:awt-...@openjdk.java.net"awt-...@openjdk.java.net; HYPERLINK "mailto:swing-dev@openjdk.java.net"swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies emp

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-02-15 Thread Phil Race
> *Cc:* Sergey Bylokhov <mailto:sergey.bylok...@oracle.com>; awt-...@openjdk.java.net <mailto:awt-...@openjdk.java.net>; swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> *Subject:* Re: [13] JDK-8216008: -Djavax.accessibility.assistive_tec

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-02-15 Thread Shashidhara Veerabhadraiah
: Sergey Bylokhov ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash   + * activate method.  If the list of assistive technology providers is empty string,   is "the" empty strin

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-02-14 Thread Phil Race
8737 Thanks and regards, Shashi *From:*Philip Race *Sent:* Saturday, February 9, 2019 2:18 AM *To:* Shashidhara Veerabhadraiah *Cc:* Sergey Bylokhov ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net *Subject:* Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-02-12 Thread Shashidhara Veerabhadraiah
Veerabhadraiah Cc: Sergey Bylokhov ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash   FWIW I think this could be closed out as "not a bug". An empty value string is an error and the

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-02-08 Thread Philip Race
ava.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash On 16/01/2019 23:03, shashidhara.veerabhadra...@oracle.com wrote: Another point is that the whitespace trimming should not trigger additional input processing

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-21 Thread Shashidhara Veerabhadraiah
; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash On 16/01/2019 23:03, shashidhara.veerabhadra...@oracle.com wrote: > Another point is that the whitespace trimming should not trigger additional > input processing  f

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-18 Thread Sergey Bylokhov
regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Tuesday, January 15, 2019 7:32 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to cras

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-16 Thread shashidhara . veerabhadraiah
rom: Sergey Bylokhov Sent: Thursday, January 17, 2019 1:33 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash I guess you meant whitespaces, then it is uncle

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-16 Thread Shashidhara Veerabhadraiah
- From: Sergey Bylokhov Sent: Thursday, January 17, 2019 1:33 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash I guess you meant whitespaces, then it

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-16 Thread Sergey Bylokhov
shidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash Hi, Shashi. Should we trim all whitespaces from the "atNames"? Otherwise the "atNames", which contains

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-15 Thread Shashidhara Veerabhadraiah
ds, Shashi -Original Message- From: Sergey Bylokhov Sent: Tuesday, January 15, 2019 7:32 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash Hi, Shashi. Shou

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-14 Thread Sergey Bylokhov
e: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash Hi, Shashi. I think you can update an existing test: open/test/jdk/javax/accessibility/AccessibilityProvider/basic.sh On 03/01/2019 01:36, Shashidhara Veerabhadraiah wrote: Hi All, Please review a fix for the be

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-09 Thread Shashidhara Veerabhadraiah
-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash Hi, Shashi. I think you can update an existing test: open/test/jdk/javax/accessibility/AccessibilityProvider/basic.sh On 03/01/2019 01:36, Shashidhara

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-03 Thread Shashidhara Veerabhadraiah
va.net Subject: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash Hi All, Please review a fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8216008 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.00/ Since t

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-03 Thread Sergey Bylokhov
Hi, Shashi. I think you can update an existing test: open/test/jdk/javax/accessibility/AccessibilityProvider/basic.sh On 03/01/2019 01:36, Shashidhara Veerabhadraiah wrote: Hi All, Please review a fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8216008 Webrev: http://cr.op

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-03 Thread Krishna Addepalli
+1 Thanks, Krishna From: Shashidhara Veerabhadraiah Sent: Thursday, January 3, 2019 3:06 PM To: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash Hi All, Please review a fix for the

[13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-03 Thread Shashidhara Veerabhadraiah
Hi All, Please review a fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8216008 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.00/ Since the mentioned list of assistive technologies for the system property(javax.accessibility.assistive_technologies