Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-05-21 Thread Sergey Bylokhov
On Thu, 1 Apr 2021 16:19:48 GMT, Prasanta Sadhukhan wrote: >> A public overriding method >> JMenu.setComponentOrientation(java.awt.ComponentOrientation) >> has no spec. >> Added spec for the method. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-05-15 Thread Prasanta Sadhukhan
On Thu, 8 Apr 2021 04:59:13 GMT, Sergey Bylokhov wrote: > > > > In many places, we use {@inheritdoc} [ex. > > https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthToolTipUI.java#L68] > > for same usecase!!! > > All of them are in the SynthXX

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Sergey Bylokhov
On Thu, 8 Apr 2021 04:27:16 GMT, Prasanta Sadhukhan wrote: >>> The behavior is not a javadoc bug. If a method is overridden with no >>> specified change in behavior, the method will be documented in the "Methods >>> Declared In ..." list at the end of the main summary table. >> >> If it is

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Prasanta Sadhukhan
On Thu, 8 Apr 2021 00:37:57 GMT, Sergey Bylokhov wrote: >> The behavior is not a javadoc bug. >> >> If a method is overridden with no specified change in behavior, the >> method will be documented in the "Methods Declared In ..." list at the >> end of the main summary table. >> >> -- Jon >>

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Sergey Bylokhov
On Thu, 8 Apr 2021 00:16:29 GMT, Jonathan Gibbons wrote: > The behavior is not a javadoc bug. If a method is overridden with no > specified change in behavior, the method will be documented in the "Methods > Declared In ..." list at the end of the main summary table. If it is not a bug it is

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Jonathan Gibbons
On Wed, 7 Apr 2021 20:34:22 GMT, Alexey Ivanov wrote: >>> I dont see any update in JDK-8264217. Is this then considered to be a >>> javadoc bug? >> >> It does not matter is it a JavaDoc bug or feature. If it is a bug it will be >> fixed and spec will be returned for the current method. If it

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Alexey Ivanov
On Wed, 7 Apr 2021 20:06:46 GMT, Sergey Bylokhov wrote: > > I dont see any update in JDK-8264217. Is this then considered to be a > > javadoc bug? > > It does not matter is it a JavaDoc bug or feature. If it is a bug it will be > fixed and spec will be returned for the current method. If it

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-07 Thread Sergey Bylokhov
On Wed, 7 Apr 2021 03:32:35 GMT, Prasanta Sadhukhan wrote: > I dont see any update in JDK-8264217. Is this then considered to be a javadoc > bug? It does not matter is it a JavaDoc bug or feature. If it is a bug it will be fixed and spec will be returned for the current method. If it is an

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-06 Thread Prasanta Sadhukhan
On Thu, 1 Apr 2021 17:00:15 GMT, Sergey Bylokhov wrote: >> Marked as reviewed by aivanov (Reviewer). > >> This might have been overlooked. The overridden method changes the >> behaviour. I'm for documenting the updated behaviour. > > It does not, the spec of the parent is still applicable to

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-01 Thread Sergey Bylokhov
On Thu, 1 Apr 2021 16:14:14 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> javadoc change > > Marked as reviewed by aivanov (Reviewer). > This might have been overlooked. The overridden

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-01 Thread Alexey Ivanov
On Thu, 1 Apr 2021 16:16:07 GMT, Prasanta Sadhukhan wrote: >> A public overriding method >> JMenu.setComponentOrientation(java.awt.ComponentOrientation) >> has no spec. >> Added spec for the method. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit

Re: RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

2021-04-01 Thread Prasanta Sadhukhan
> A public overriding method > JMenu.setComponentOrientation(java.awt.ComponentOrientation) > has no spec. > Added spec for the method. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: javadoc change - Changes: