Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

The fix looks good to me. Thanks, Alexandr. On 1/14/2016 9:02 AM, Sergey Bylokhov wrote: Looks fine. On 14/01/16 07:37, Avik Niyogi wrote: Hi All, Please find code changes incorporating changes as suggested by inputs provided: http://cr.openjdk.java.net/~aniyogi/8016665/webrev.02/

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

On 13/01/16 09:27, Avik Niyogi wrote: Hi Sergey, If fFileList refers to a soft linked empty folder, we will will not need to apply orientation to it’s sub-components. I didn't understand what "soft linked empty folder" means here =(( Just to clarify. In the fix you have this code: 95

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Looks fine. On 14/01/16 07:37, Avik Niyogi wrote: Hi All, Please find code changes incorporating changes as suggested by inputs provided: http://cr.openjdk.java.net/~aniyogi/8016665/webrev.02/ With Regards, Avik Niyogi On 13-Jan-2016, at 11:38 pm, Sergey Bylokhov

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi All, Please find code changes incorporating changes as suggested by inputs provided: http://cr.openjdk.java.net/~aniyogi/8016665/webrev.02/ With Regards, Avik Niyogi > On 13-Jan-2016, at 11:38 pm, Sergey Bylokhov

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi Sergey, If fFileList refers to a soft linked empty folder, we will will not need to apply orientation to it’s sub-components. With Regards, Avik Niyogi > On 12-Jan-2016, at 7:19 pm, Sergey Bylokhov > wrote: > > Hi, Avik. > Is it possible that fFileList can be

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi All, The comment in the mail trail is regarding different bug 8015748. Since, No inputs remain for code review related to this fix, please provide +1 for the fixes. Thank you in advance. With Regards, Avik Niyogi > On 12-Jan-2016, at 2:52 pm, Avik Niyogi wrote: > >

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi Alexander, Due to animation effects on Aqua look and feel, the color checks can not be used as seen in the image below: The Blue color is not homogeneously distributed and varies continuously. Since this is a fix for Aqua look and feel mainly, we need to perform a visual confirmation

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi, Avik. Is it possible that fFileList can be null? I see that in other places we do not check it to null? On 04/01/16 11:52, Avik Niyogi wrote: Hi All, Please review the webrev.01 : http://cr.openjdk.java.net/~aniyogi/8016665/webrev.01/ incorporated with the inputs received. With Regards,

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

I am sorry. The comment really was about the issue 8015748. The fix looks good for me. Thanks, Alexandr. On 1/12/2016 1:44 AM, Avik Niyogi wrote: Hi All, The comment in the mail trail is regarding different bug 8015748. Since, No inputs remain for code review related to this fix, please

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Is it possible to make an automated test which compare colors from the 5/6 part of the progress bar when its value is set to 0 and 30? If these colors are the same it means that the progress has been painted on the left side instead of right. Thanks, Alexandr. On 04/01/16 12:52, Avik

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi All, Please review the webrev.01 : http://cr.openjdk.java.net/~aniyogi/8016665/webrev.01/ incorporated with the inputs received. With Regards, Avik Niyogi > On 28-Dec-2015, at 10:23 am, Avik Niyogi wrote: >

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi Alexandr, Automated test may fail based on folder contents on individual systems irrespective of the fix directly not depending on the same. Also, to confirm this fix, it will need visual confirmation and hence, no automated test was provided. With Regards, Avik Niyogi > On 23-Dec-2015, at

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

  The fix looks good to me.   Is it possible to write an automated test for the fix?   Thanks,   Alexandr. On 12/21/2015 2:55 PM, Avik Niyogi wrote: Hi All, Kindly review the bug fix

Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi All, Kindly review the bug fix for JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8016665 Webrev: http://cr.openjdk.java.net/~aniyogi/8016665/webrev.00/ Issue: The manual