Fix looks good to me.
Regards
Prasanta
On 1/20/2016 6:18 PM, Alexander Scherbatiy wrote:
On 1/20/2016 3:45 PM, Rajeev Chamyal wrote:
Hello Alexandr,
Thanks for the review.
I have updated the webrev as suggested.
http://cr.openjdk.java.net/~rchamyal/8139213/webrev.01/
The fix looks good
On 1/20/2016 8:11 AM, Rajeev Chamyal wrote:
Hello Alexandr,
Thanks for the review.
Yes, we can call minimumLayoutSize(Container) of parent class but in
this case also again we need to check if any of the child components
are setting preferred size and compare it with the default values.
Hello Alexandr,
Thanks for the review.
I have updated the webrev as suggested.
http://cr.openjdk.java.net/~rchamyal/8139213/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 20 January 2016 17:04
To: Rajeev Chamyal
Cc: Sergey Bylokhov; Prasanta
Hello All,
Gentle reminder for review.
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 13 January 2016 16:37
To: Sergey Bylokhov; Alexander Scherbatiy; Prasanta Sadhukhan;
swing-dev@openjdk.java.net
Subject: Review request for JDK-8139213 : Mac OS X Aqua Look and
Hello Alexandr,
Thanks for the review.
Yes, we can call minimumLayoutSize(Container) of parent class but in this case
also again we need to check if any of the child components are setting
preferred size and compare it with the default values.
And after this we need to find a delta that
On 19/01/16 15:48, Rajeev Chamyal wrote:
Hello All,
Gentle reminder for review.
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 13 January 2016 16:37
To: Sergey Bylokhov; Alexander Scherbatiy; Prasanta Sadhukhan;
swing-dev@openjdk.java.net
Subject: Review
Hello All,
Please review the following fix for Jdk9:
Bug : https://bugs.openjdk.java.net/browse/JDK-8139213
Webrev : http://cr.openjdk.java.net/~rchamyal/8139213/webrev.00/
Issue : In Mac OS X Aqua LAF JOptionPane truncates the first button if multiple
buttons are added to it.
Cause:
