Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2016-03-10 Thread Sergey Bylokhov
; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hi, Rajeev. The fix looks fine, but the test should be updated. JFrame is created on non-EDT thread. It is unclear what l we should test(some

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2016-03-09 Thread Rajeev Chamyal
>> Regards, >> Rajeev Chamyal >> >> -Original Message- >> From: Rajeev Chamyal >> Sent: 02 January 2016 11:46 >> To: Sergey Bylokhov; swing-dev@openjdk.java.net >> Subject: RE: Review request for JDK-8145896 JInternalFrame setMaximum >&

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2016-03-09 Thread Sergey Bylokhov
/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 30 December 2015 20:34 To: Rajeev Chamyal; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exc

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2016-03-08 Thread Rajeev Chamyal
.01/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 02 January 2016 11:46 To: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: RE: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hello Sergey

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2016-01-19 Thread Alexander Scherbatiy
2016 11:46 To: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: RE: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hello Sergey, Thanks for review I have updated webrev. There was one more issue with fix to fix it , I have

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2016-01-11 Thread Rajeev Chamyal
Scherbatiy > *Sent:* 23 December 2015 19:44 > *To:* Rajeev Chamyal > *Cc:* Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net > *Subject:* Re: Review request for JDK-8145896 JInternalFrame > setMaximum before adding to desktop throws null pointer exception > > &

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2016-01-01 Thread Rajeev Chamyal
Bylokhov Sent: 30 December 2015 20:34 To: Rajeev Chamyal; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hi, Rajeev. A few notes: - The "Rectangle desktopBounds = f.getP

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2015-12-30 Thread Sergey Bylokhov
Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net *Subject:* Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception The fix looks good to me. Thanks, Alexandr. On 12/21/2015 3:09 PM, Rajeev Chamyal wrote

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2015-12-29 Thread Rajeev Chamyal
Chamyal Cc: Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception The fix looks good to me. Thanks, Alexandr. On 12/21/2015 3:09 PM, Rajeev Chamyal wrote:

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2015-12-23 Thread Alexander Scherbatiy
  The fix looks good to me.   Thanks,   Alexandr. On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: Hello All,   Please review the following fix for Jdk9:   Bug:

Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2015-12-21 Thread Rajeev Chamyal
Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 Webrev: http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ Issue: JInternalFrame setMaximum before adding to desktop throws null pointer exception Cause: Null checks for