Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-19 Thread Rajeev Chamyal
Scherbatiy; swing-dev@openjdk.java.net Subject: Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java Hi Rajeev, I tried this version of the test on two Ubuntu 16.04 systems with Unity and a promoted b132.

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-19 Thread Yuri Nesterenko
amyal Sent: 16 August 2016 18:45 To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java Hello Sergey, Thanks for the review. I

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-18 Thread Rajeev Chamyal
: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java Hello Sergey, Thanks for the review. In the bug its reported that border of button is grey. Instead of button border icon border should be checked. I h

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-16 Thread Rajeev Chamyal
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java On 16.08.16 15:57, Sergey Bylokhov wrote: > The changes look

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-16 Thread Sergey Bylokhov
On 16.08.16 15:57, Sergey Bylokhov wrote: The changes looks fine, there are a notice, is it a known issues? there are a notice about different background of the buttons. On 16.08.16 15:01, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Webrev:

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-16 Thread Sergey Bylokhov
The changes looks fine, there are a notice, is it a known issues? On 16.08.16 15:01, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Webrev: http://cr.openjdk.java.net/~rchamyal/8163160/webrev.00/ Bug : https://bugs.openjdk.java.net/browse/JDK-8163160 Issue : manual

Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-16 Thread Rajeev Chamyal
Hello All, Please review the following webrev. Webrev: http://cr.openjdk.java.net/~rchamyal/8163160/webrev.00/ Bug : https://bugs.openjdk.java.net/browse/JDK-8163160 Issue : manual tag was missing in test. Regards, Rajeev Chamyal