Re: Swing Dev [9] Review Request: 8015085 [macosx] Label shortening via ... broken when String contains combining diaeresis

2015-02-02 Thread Sergey Bylokhov
Hi, Alexander. You are right! http://cr.openjdk.java.net/~serb/8015085/webrev.02 On 02.02.2015 17:10, Alexander Zvegintsev wrote: Hi Sergey, The fix looks good to me too, but the test using a valid third party domain[1]. I suggest to replace it with something else. [1]

Re: Swing Dev [9] Review Request: 8015085 [macosx] Label shortening via ... broken when String contains combining diaeresis

2015-02-02 Thread Alexander Zvegintsev
looks good. Thanks, Alexander. On 02/02/2015 05:50 PM, Sergey Bylokhov wrote: Hi, Alexander. You are right! http://cr.openjdk.java.net/~serb/8015085/webrev.02 On 02.02.2015 17:10, Alexander Zvegintsev wrote: Hi Sergey, The fix looks good to me too, but the test using a valid third party

Re: Swing Dev [9] Review Request: 8015085 [macosx] Label shortening via ... broken when String contains combining diaeresis

2015-01-20 Thread Sergey Bylokhov
Still looking for volunteers =( On 12.01.2015 18:46, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. Description: The problem is that we consider the string which contains a combining diaeresis as string which needs TextLayout. In such case SwingUtilities2.clipString will use

Swing Dev [9] Review Request: 8015085 [macosx] Label shortening via ... broken when String contains combining diaeresis

2015-01-12 Thread Sergey Bylokhov
Hello. Please review a fix for jdk 9. Description: The problem is that we consider the string which contains a combining diaeresis as string which needs TextLayout. In such case SwingUtilities2.clipString will use LineBreakMeasurer to calculate the characters inside some advance. But by