On Mon, 1 Feb 2021 07:19:10 GMT, Tejpal Rebari wrote:
>> Please review the following fix for jdk17.
>> In this fix i have deprecated and marked for removal following classes and
>> methods
>>public void intervalAdded(ListDataEvent e)
>>public void intervalRemoved(ListDataEvent e)
>>
> This PR supersedes #2223.
> The original PR was created from master, whereas this PR is created from a
> fresh branch.
>
> Below is a copy of the original description, but as @mrserb correctly
> [pointed
> out](https://github.com/openjdk/jdk/pull/2223#issuecomment-767048399), there
> is actu
On Fri, 29 Jan 2021 18:14:59 GMT, Alexey Ivanov wrote:
>> Matthias Perktold has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Move StyleSheet rule into body tag
>> - Measure preferredSize of htmlPane instead of frame bounds
>> - Fix
> This PR supersedes #2223.
> The original PR was created from master, whereas this PR is created from a
> fresh branch.
>
> Below is a copy of the original description, but as @mrserb correctly
> [pointed
> out](https://github.com/openjdk/jdk/pull/2223#issuecomment-767048399), there
> is actu
> This PR supersedes #2223.
> The original PR was created from master, whereas this PR is created from a
> fresh branch.
>
> Below is a copy of the original description, but as @mrserb correctly
> [pointed
> out](https://github.com/openjdk/jdk/pull/2223#issuecomment-767048399), there
> is actu
On Fri, 29 Jan 2021 14:16:46 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 2870:
>>
>>> 2868: w3cLengthMapping.put("cm", 37.7952f); //96px/2.54
>>> 2869: w3cLengthMapping.put("pc", 16f); //1/6 of 1in
>>> 2870:
On Sat, 30 Jan 2021 16:22:17 GMT, Alexey Ivanov wrote:
>>> The test passes for me with the fresh build of JDK, even without the fix
>>> applied.
>>> Indeed, I get the same frame dimensions in both cases: 150×42.
>>>
>>> However, the test fails when run with JDK 11.0.10 or JDK 15, the dimension
On Mon, 1 Feb 2021 12:28:32 GMT, Matthias Perktold
wrote:
> > Does
> > ```java
> > if ("1.3".equals(String.format("%1.1", ratio))
> > ```
> >
> >
> > look clearer?
>
> I went with something similar to this now. Unfortunately, I also needed to
> use `Locale.ENGLISH` explicitely to get a dot a
I've fixed annoying behaviour of input methods in text components.
Code checks caret position before submitting composed text.
-
Commit messages:
- 8260719: Input method character moves with caret
Changes: https://git.openjdk.java.net/jdk/pull/2337/files
Webrev: https://webrevs.op
On Wed, 27 Jan 2021 11:47:36 GMT, Alexey Ivanov wrote:
>>> I believe we're talking about javadoc spec: its text has not changed.
>>> CSS spec is updated. Since you follow the rules of CSS 2.2, it's better to
>>> link to CSS 2.2.
>>
>> No, I did not mean the JavaDoc, my question was - "what part
On Fri, 29 Jan 2021 19:47:03 GMT, Alexey Ivanov wrote:
>> Matthias Perktold has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Link to CSS 2.2 spec from length mapping comments
>
> Changes requested by aivanov (Reviewer).
>
>
> It seems
On Mon, 1 Feb 2021 03:52:54 GMT, Prasanta Sadhukhan
wrote:
>>> > Does this volatile modifier resolve the now-removed infinite loop in
>>> > `while (!tk.IsDisposed())` in `WToolkit_shutdown`?
>>>
>>> The loop should not be removed.
>>
>> No, it should not, as you noted previously.
>>
>> Howev
On Mon, 1 Feb 2021 18:16:12 GMT, Denis Konoplev wrote:
> I've fixed annoying behaviour of input methods in text components.
> Code checks caret position before submitting composed text.
@dmarkov20 please take a look
-
PR: https://git.openjdk.java.net/jdk/pull/2337
On Mon, 1 Feb 2021 12:06:16 GMT, Matthias Perktold
wrote:
>
>
> > As for px, CSS defines, “1px is equal to 0.75pt”, then 1pt is 4/3px — this
> > is where 1.3f comes from (=96/72).
>
> This makes sense.
>
> What makes me wonder is why the length mappings for `px` and `pt` without
> `W3C_LEN
On Mon, 1 Feb 2021 12:01:58 GMT, Matthias Perktold
wrote:
>> This PR supersedes #2223.
>> The original PR was created from master, whereas this PR is created from a
>> fresh branch.
>>
>> Below is a copy of the original description, but as @mrserb correctly
>> [pointed
>> out](https://github
On Mon, 1 Feb 2021 22:02:16 GMT, Sergey Bylokhov wrote:
>> I ran the test locally for several iterations but it does not fail locally
>> so I believe it's a test issue. Re reverting the test changes made in 1st
>> webrev...
>
> I do not see a reason to change the test until the root cause of th
On Mon, 1 Feb 2021 23:03:30 GMT, Alexey Ivanov wrote:
>> Matthias Perktold has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Link to CSS 2.2 spec from length mapping comments
>
> Changes requested by aivanov (Reviewer).
>
>
> > It seems
17 matches
Mail list logo
