red OS to account
for supported native, non-native and cross-platform Look and Feels.
With Regards,
Avik Niyogi
red OS to account
for supported native, non-native and cross-platform Look and Feels.
With Regards,
Avik Niyogi
e
different test case flow with regards to focus owner.
Fix: Modified test case with appropriate deviant test case for Look and Feels
which are not eligible for focus traversal as expected previously in test file.
With Regards,
Avik Niyogi
Hi Rajeev,
Will fix and create webrev.01 with inputs provided. Also, we have verified on
Mac OS X, Windows and Ubuntu.
With Regards,
Avik Niyogi
> On 12-Nov-2015, at 4:52 pm, Rajeev Chamyal wrote:
>
> Hello Avik,
>
> 1) In the tryLookAndFeel exception handling is skippe
Hi All,
The bug fix has been updated as per the comments.
http://cr.openjdk.java.net/~rchamyal/avik/8132770/webrev.01/
<http://cr.openjdk.java.net/~rchamyal/avik/8132770/webrev.01/>
With Regards,
Avik Niyogi
> On 13-Nov-2015, at 9:46 am, Avik Niyogi wrote:
>
> Hi Rajeev,
&g
Hi All,
The bug fix has been updated as per the comments.
http://cr.openjdk.java.net/~rchamyal/avik/7124218/webrev.01/
<http://cr.openjdk.java.net/~rchamyal/avik/7124218/webrev.01/>
With Regards,
Avik Niyogi
> On 11-Nov-2015, at 8:20 pm, Alexander Scherbatiy
> wrote:
>
Hi All,
The bug fix has been updated as per comments.
http://cr.openjdk.java.net/~rchamyal/avik/8132770/webrev.02/
<http://cr.openjdk.java.net/~rchamyal/avik/8132770/webrev.02/>
With Regards,
Avik Niyogi
> On 16-Nov-2015, at 12:36 pm, Rajeev Chamyal wrote:
>
> Hello Avik,
&
tion with an accelerator like "meta shift COMMA”.
It is put in the component's action map, when it is invoked, the action is
called twice.
Cause: Incorrect implementation within CMenuItem.m
Fix:Added logic to sense all modifiers including “shift” in CMenuItem which did
not exist befor
Hi All,
Please find updated webrev.01 with inputs from comments below:
http://cr.openjdk.java.net/~aniyogi/8139169/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8139169/webrev.01/>
With Regards,
Avik Niyogi
> On 02-Dec-2015, at 5:16 pm, Rajeev Chamyal wrote:
>
> Hello Avik
With Regards,
Avik Niyogi
> On 07-Dec-2015, at 9:27 pm, Sergey Bylokhov
> wrote:
>
> Hi, Avik.
> The fix looks fine for me.
>
> But I think that you incorrectly tried to place the window in the center of
> the screen, you need to place frame.setLocationRelativeTo(n
Hi Alexander,
Since there is no change in char from this depending on status of the method,
the check is not required.
With Regards,
Avik Niyogi
> On 09-Dec-2015, at 11:29 pm, Alexander Scherbatiy
> wrote:
>
> paramErr
added while checking for for
editor to
take charge of applying the component orientation to all subsequent
subcomponents.
With Regards,
Avik Niyogi
spinner.repaint();
}
Casting of JComponent is done explicitly for the values there. Maintaining same
standard
and scoping out uncertainty seems correct in the context.
With Regards,
Avik Niyogi
> On 19-Dec-2015, at 4:47 am, Sergey Bylokhov
> wrote:
>
> Hi, Avik.
>
k of RIGHT_TO_LEFT ComponentOrientation and
verified with other combination orientation with available
Horizontal and Vertical orientations as provided from before.
With Regards,
Avik Niyogi
in comments: "The Aqua LAF must support the RTL orientation
of JFileChooser."
Fix:
Added implementation for the check of RIGHT_TO_LEFT ComponentOrientation and
verified with test suite.
With Regards,
Avik Niyogi
Hi Alexandr,
Automated test may fail based on folder contents on individual systems
irrespective of the fix directly not depending on the same.
Also, to confirm this fix, it will need visual confirmation and hence, no
automated test was provided.
With Regards,
Avik Niyogi
> On 23-Dec-2015,
Hi All,
Please review the webrev.01 :
http://cr.openjdk.java.net/~aniyogi/8016665/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8016665/webrev.01/>
incorporated with the inputs received.
With Regards,
Avik Niyogi
> On 28-Dec-2015, at 10:23 am, Avik Niyogi wrote:
>
&
Hi All,
Please review the following incorporated with inputs provided
http://cr.openjdk.java.net/~aniyogi/8041894/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8041894/webrev.01/>
With Regards,
Avik Niyogi
> On 28-Dec-2015, at 7:05 pm, Sergey Bylokhov
> wrote:
>
> Hi, Avi
Hi All,
Please find webrev with inputs as provided:
http://cr.openjdk.java.net/~aniyogi/8015748/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8015748/webrev.01/>
With Regards,
Avik Niyogi
> On 23-Dec-2015, at 7:29 pm, Alexander Scherbatiy
> wrote:
>
>
> - please ch
itself.
Hence, manual test is essential in this case.
With Regards,
Avik Niyogi
> On 11-Jan-2016, at 9:12 pm, Alexander Scherbatiy
> wrote:
>
>
> Is it possible to make an automated test which compare colors from the 5/6
> part of the progress bar
> when its value is set
Hi All,
Please find the code changes in fix as with the inputs received for the same.
http://cr.openjdk.java.net/~aniyogi/8015748/webrev.02/
<http://cr.openjdk.java.net/~aniyogi/8015748/webrev.02/>
With Regards,
Avik Niyogi
> On 11-Jan-2016, at 3:55 pm, Semyon Sadetsky
> wrote:
Hi All,
The comment in the mail trail is regarding different bug 8015748. Since, No
inputs remain for code review related to this fix, please provide +1 for the
fixes.
Thank you in advance.
With Regards,
Avik Niyogi
> On 12-Jan-2016, at 2:52 pm, Avik Niyogi wrote:
>
> Hi Alexander,
&g
Hi All,
Gentle reminder: Please provide review and provide +1 for the review in case it
is acceptable.
Thank you in advance.
With Regards,
Avik Niyogi
> On 04-Jan-2016, at 3:11 pm, Avik Niyogi wrote:
>
> Hi All,
> Please review the following incorporated with inputs pro
Hi All,
Thank you for the reviews. Kindly request to commit the changes for the same.
With Regards,
Avik Niyogi
> On 12-Jan-2016, at 11:23 pm, Alexander Scherbatiy
> wrote:
>
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 12/01/16 17:53, Sergey By
Hi Sergey,
If fFileList refers to a soft linked empty folder, we will will not need to
apply orientation to it’s sub-components.
With Regards,
Avik Niyogi
> On 12-Jan-2016, at 7:19 pm, Sergey Bylokhov
> wrote:
>
> Hi, Avik.
> Is it possible that fFileList can be null? I se
Hi All,
Please find changes as provided with incorporation of inputs:
http://cr.openjdk.java.net/~aniyogi/8015748/webrev.03/
<http://cr.openjdk.java.net/~aniyogi/8015748/webrev.03/>
With Regards,
Avik Niyogi
> On 12-Jan-2016, at 11:49 pm, Alexander Scherbatiy
> wrote:
>
>
Hi All,
Please find code changes incorporating changes as suggested by inputs provided:
http://cr.openjdk.java.net/~aniyogi/8016665/webrev.02/
<http://cr.openjdk.java.net/~aniyogi/8016665/webrev.02/>
With Regards,
Avik Niyogi
> On 13-Jan-2016, at 11:38 pm, Sergey Bylokhov
> wr
resulted in null value for resized ImageIcon image was not well handled.
Fix:
All places in Aqua LAF where "instanceof Icon” (and not just ImageIcon class)
is required,
inputs were added after significant analyses.
Check for null for getImage was done to remove a Null Pointer Exception.
With Regards,
Avik Niyogi
Hi All,
Please find changes as provided with incorporation of inputs:
http://cr.openjdk.java.net/~aniyogi/8015748/webrev.04/
<http://cr.openjdk.java.net/~aniyogi/8015748/webrev.04/>
With Regards,
Avik Niyogi
> On 13-Jan-2016, at 7:02 pm, Alexander Scherbatiy
> wrote:
>
> On
so and no control exists to prevent that. So, with or
without my fix, this behaviour will be same for ImageIcon and Icon custom
instances.
Hope this clarifies the query.
With Regards,
Avik Niyogi
> On 14-Jan-2016, at 11:36 am, Sergey Bylokhov
> wrote:
>
> Hi, Avik.
> In the fi
Hi All,
Please find the changes as provided with incorporation of inputs:
http://cr.openjdk.java.net/~aniyogi/8015748/webrev.05/
<http://cr.openjdk.java.net/~aniyogi/8015748/webrev.05/>
With Regards,
Avik Niyogi
> On 14-Jan-2016, at 3:18 pm, Alexander Scherbatiy
> wrote:
>
>
Hi All, Please find the changes as provided with incorporation of inputs:
http://cr.openjdk.java.net/~aniyogi/8015748/webrev.06/
<http://cr.openjdk.java.net/~aniyogi/8015748/webrev.06/>
With Regards,
Avik Niyogi
> On 14-Jan-2016, at 10:57 pm, Sergey Bylokhov
> wrote:
>
>
Hi Sergey,
Please review the webrev taking inputs as per the discussion before:
http://cr.openjdk.java.net/~aniyogi/8146321/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8146321/webrev.01/>
With Regards,
Avik Niyogi
> On 14-Jan-2016, at 12:55 pm, Avik Niyogi wrote:
>
> Hi S
Hi All,
A gentle reminder. Please review my code changes as mentioned in the webrev
below as available in the link in the mail trail.
With Regards,
Avik Niyogi
> On 18-Jan-2016, at 11:34 am, Avik Niyogi wrote:
>
> Hi All, Please find the changes as provided with incorporation
Hi All,
A gentle reminder, please review my code changes as in the webrev below in the
mail trail.
With Regards,
Avik Niyogi
> On 18-Jan-2016, at 3:01 pm, Avik Niyogi wrote:
>
> Hi Sergey,
>
> Please review the webrev taking inputs as per the discussion before:
> http://c
Hi All,
Please review the code changes made as with inputs for the webrev:
http://cr.openjdk.java.net/~aniyogi/8015748/webrev.07/
<http://cr.openjdk.java.net/~aniyogi/8015748/webrev.07/>
With Regards,
Avik Niyogi
> On 20-Jan-2016, at 10:40 am, Rajeev Chamyal wrote:
>
> Hello
t;> The fix looks good to me.
>>
>> Thanks,
>> Alexandr.
>>
>> On 1/20/2016 12:47 PM, Rajeev Chamyal wrote:
>>>
>>> Looks good to me.
>>>
>>> Regards,
>>>
>>> Rajeev Chamyal
>>>
>>> *
Hi Sergey,
The JTreg will pass, but the errors are posted to the log and not as an
interrupt as it would prematurely terminate execution of entire test case for
other look and feels if done so.
With Regards,
Avik Niyogi
> On 21-Jan-2016, at 8:26 am, Avik Niyogi wrote:
>
> Hi Serge
)
With Regards,
Avik Niyogi
> On 20-Jan-2016, at 4:30 pm, Alexander Scherbatiy
> wrote:
>
>
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 1/20/2016 12:47 PM, Rajeev Chamyal wrote:
>>
>> Looks good to me.
>>
>> Regards,
>>
Hi All,
Please review my code change with inputs received:
http://cr.openjdk.java.net/~aniyogi/8015748/webrev.08/
<http://cr.openjdk.java.net/~aniyogi/8015748/webrev.08/>
With Regards,
Avik Niyogi
> On 21-Jan-2016, at 8:30 am, Avik Niyogi wrote:
>
> Hi Sergey,
> The JTreg
Hi All,
Please review the code changes made as per inputs provided:
cr.openjdk.java.net/~aniyogi/8146321/webrev.02
<http://cr.openjdk.java.net/~aniyogi/8146321/webrev.02>
With Regards,
Avik Niyogi
> On 20-Jan-2016, at 10:35 pm, Sergey Bylokhov
> wrote:
>
> On 20/01/16 18:43,
Hi All,
Please review the code changes made as per the inputs provided:
cr.openjdk.java.net/~aniyogi/8146321/webrev.03
<http://cr.openjdk.java.net/~aniyogi/8146321/webrev.03>
With Regards,
Avik Niyogi
> On 02-Feb-2016, at 3:02 pm, Alexandr Scherbatiy
> wrote:
>
> On 2/1/2
Hi Alexander,
> On 02-Feb-2016, at 3:44 pm, Alexandr Scherbatiy
> wrote:
>
> On 2/2/2016 1:50 AM, Avik Niyogi wrote:
>> Hi All,
>> Please review the code changes made as per the inputs provided:
>> cr.openjdk.java.net/~aniyogi/8146321/webrev.03
>> &l
Hi All,
Please review the code changes made as per the inputs provided:
http://cr.openjdk.java.net/~aniyogi/8146321/webrev.04
<http://cr.openjdk.java.net/~aniyogi/8146321/webrev.04>
With Regards,
Avik Niyogi
> On 02-Feb-2016, at 5:55 pm, Alexandr Scherbatiy
> wrote:
>
> O
Hi All,
Please review the code changes made as per the inputs provided:
http://cr.openjdk.java.net/~aniyogi/8146321/webrev.05/
<http://cr.openjdk.java.net/~aniyogi/8146321/webrev.05/>
With Regards,
Avik Niyogi
> On 03-Feb-2016, at 7:38 pm, Alexandr Scherbatiy
> wrote:
>
>
Hi Sergey,
Please review webrev with changes as per the inputs provided:
cr.openjdk.java.net/~aniyogi/8146321/webrev.06/
<http://cr.openjdk.java.net/~aniyogi/8146321/webrev.06/>
With Regards,
Avik Niyogi
> On 08-Feb-2016, at 2:29 am, Sergey Bylokhov
> wrote:
>
> Both upda
A gentle reminder. Please review webrev with changes as per the inputs provided:
cr.openjdk.java.net/~aniyogi/8146321/webrev.06/
<http://cr.openjdk.java.net/~aniyogi/8146321/webrev.06/>
With Regards,
Avik Niyogi
> On 08-Feb-2016, at 12:42 pm, Avik Niyogi wrote:
>
> Hi Sergey,
or Aqua Look&Feel, multiple calls to pane.getMinimumSize().height causes
incremental return of values.
Cause:
The impact was caused by a major broken code within AquaTabbedPaneUI.java for
createLayoutManager()
Fix:
Major linking calls to super class fix done within createLayoutManager().
Wi
or Aqua Look&Feel, multiple calls to pane.getMinimumSize().height causes
incremental return of values.
Cause:
The impact was caused by a major broken code within AquaTabbedPaneUI.java for
createLayoutManager()
Fix:
Major linking calls to super class fix done within createLayoutManager().
Wi
addressed. Thank you.
With Regards,
Avik Niyogi
> On 25-Feb-2016, at 6:45 pm, Alexander Potochkin
> wrote:
>
> Hello Avik
>
> AquaTruncatingTabbedPaneLayout has a lot of code which is specific for the
> AquaTabbedPaneUI.
> I don't think setting the layout manag
Gentle reminder. Please review this fix.
> On 26-Feb-2016, at 10:39 am, Avik Niyogi wrote:
>
> The issue is with setting of TabbedPaneScrollLayout() for the option
> JTabbedPane.SCROLL_TAB_LAYOUT as is enabled in the test code
> and not TabbedPaneLayout() as which is the de
he test case failed for GTK LAF.
Cause:
The test case was meant to be Mac specific and was missing a jtreg parameter
Fix:
Minor change to test case with @requires tag added to set the fix.
With Regards,
Avik Niyogi
JNI. Albeit rendering is not yet
supported, they will appear as blank “Missing font” notation.
Also, added debug point in case of issue with glyph arrises.
With Regards,
Avik Niyogi
Policy(JTabbedPane.SCROLL_TAB_LAYOUT); is not
honoured.
In the new fix as provided, references to base class layout manager is removed
in current solution.
With Regards,
Avik Niyogi
> On 02-Mar-2016, at 7:50 pm, Alexander Potochkin
> wrote:
>
> Hello Avik
>
> Let me make
Hi All,
A gentle reminder, please review code changes.
With Regards,
Avik Niyogi
> On 08-Mar-2016, at 9:51 pm, Avik Niyogi wrote:
>
> Hi All,
>
> Please review code changes done as with inputs provided.
> http://cr.openjdk.java.net/~aniyogi/8137169/webrev.01/
> <ht
Hi All,
A gentle reminder, please review my code changes.
With Regards,
Avik Niyogi
> On 08-Mar-2016, at 9:39 pm, Avik Niyogi wrote:
>
> Hi All,
>
> Kindly review the bug fix for JDK 9.
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8148555
> <https:/
Hi Sergey,
Seems like it is a delay issue. Will submit test case with a waitForIdle() fix.
With Regards,
Avik Niyogi
> On 10-Mar-2016, at 7:22 pm, Sergey Bylokhov
> wrote:
>
> Hi, Avik.
> A few questions.
> - Why webrev contains the new file?
> - You marked the test as a m
Hi All,
Please review code changes made as per inputs provided.
http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/>
With Regards,
Avik Niyogi
> On 14-Mar-2016, at 10:53 am, Avik Niyogi wrote:
>
> Hi Sergey,
> Seems
would be maintaining with
requirements with code impact to superclasses.
Please provide any insight to a probable compensate to mitigate this dichotomy
of code expectation. Thank you in advance.
With Regards,
Avik Niyogi
> On 18-Mar-2016, at 2:42 pm, Alexander Scherbatiy
> wrote:
>
&
It can be made into a class method, but herein this case it is needed for that
instance only and hence the need for instance method and referred with “self”.
With Regards,
Avik Niyogi
> On 16-Mar-2016, at 11:55 pm, Alexander Scherbatiy
> wrote:
>
>
> Could the -(
Hi Alexander,
The issue only applies for ScrollingTabbedPane and hence this fix.
With Regards,
Avik Niyogi
> On 16-Mar-2016, at 4:51 pm, Alexander Scherbatiy
> wrote:
>
>
> Does the same issue affects the AquaTabbedPaneContrastUI?
>
> Thanks,
> Alexandr.
>
>
encompass actual expectations from Java on OS X as per native
behaviour.
Please review my current fix as available in the mail trail. Thank you in
advance.
With Regards,
Avik Niyogi
> On 14-Mar-2016, at 6:48 pm, Sergey Bylokhov
> wrote:
>
> Hi, Avik.
> Can you please take a lo
Hi Sergey,
https://bugs.openjdk.java.net/browse/JDK-8151282
<https://bugs.openjdk.java.net/browse/JDK-8151282> is open and in progress.
With Regards,
Avik Niyogi
> On 19-Mar-2016, at 4:52 pm, Sergey Bylokhov
> wrote:
>
> I guess you need a separate CR for this, because JDK-
duplicate code.
With Regards,
Avik Niyogi
> On 19-Mar-2016, at 1:52 am, Alexander Scherbatiy
> wrote:
>
>
> I would think about something like:
> -
> public class TabbedPaneLayout implements LayoutManager {
>
> protected int basePreferredTabAreaW
Hi Sergey,
This bug fix has been committed and resolved. Does not require a review.
With Regards,
Avik Niyogi
> On 21-Mar-2016, at 10:42 am, Avik Niyogi wrote:
>
> Hi Sergey,
> https://bugs.openjdk.java.net/browse/JDK-8151282
> <https://bugs.openjdk.java.net/browse/JDK-81512
Hi Sergey,
Please review the following code change.
With Regards,
Avik Niyogi
> On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy
> wrote:
>
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 14/03/16 16:25, Avik Niyogi wrote:
>> Hi All,
>> Please
Hi Sergey,
Please review the following code changes.
With Regards,
Avik Niyogi
> On 17-Mar-2016, at 7:03 pm, Alexander Scherbatiy
> wrote:
>
>
> The fix looks good to me.
>
> Just a small note: it is better to remove comment "527 //" since it
Hi Rajeev,
Please review the following code changes.
With Regards,
Avik Niyogi
> On 21-Mar-2016, at 12:17 pm, Avik Niyogi wrote:
>
> Hi Sergey,
>
> Please review the following code changes.
> With Regards,
> Avik Niyogi
>> On 17-Mar-2016, at 7:
Hi Manajit,
Please review the following code changes.
With Regards,
Avik Niyogi
> On 21-Mar-2016, at 12:20 pm, Avik Niyogi wrote:
>
> Hi Rajeev,
> Please review the following code changes.
>
> With Regards,
> Avik Niyogi
>> On 21-Mar-2016, at 12:17 pm, Avi
Hi All,
Please review the below code changes as per the inputs received.
http://cr.openjdk.java.net/~aniyogi/8148555/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8148555/webrev.01/>
With Regards,
Avik Niyogi
> On 21-Mar-2016, at 12:45 pm, Rajeev Chamyal wrote:
>
> Hello Avik
Hi All,
Please find webrev with new code fix:
http://cr.openjdk.java.net/~aniyogi/8151282/webrev.02/
<http://cr.openjdk.java.net/~aniyogi/8151282/webrev.02/>
With Regards,
Avik Niyogi
> On 21-Mar-2016, at 8:07 pm, Sergey Bylokhov
> wrote:
>
> Hi, Avik.
> How this test c
he UI and
different elements not required to be visible were being rendered because it is
copying those elements from BasicUI.
If a better solution is available without breaking some code apart from fix
provided, please let me know. Thank you in advance.
With Regards,
Avik Niyogi
> On 19-Mar-2016
> On 23-Mar-2016, at 3:31 pm, Alexander Scherbatiy
> wrote:
>
> On 21/03/16 09:19, Avik Niyogi wrote:
>> Hi Alexander,
>> I agree with what you said regarding the look and feel looking different.
>> But this bug arrises due to setting of TabbedPaneScrollLayout
forth to the UI by the arrow buttons AQUA provides
instead of placing them in another row or column. This is also the expected
behaviour for AquaLAF as per javadoc.
With Regards,
Avik Niyogi
> On 23-Mar-2016, at 4:14 pm, Alexander Scherbatiy
> wrote:
>
> On 23/03/16 14:07,
UI by the arrow buttons AQUA provides
instead of placing them in another row or column. This is also the expected
behaviour for AquaLAF as per javadoc.
With Regards,
Avik Niyogi
> On 24-Mar-2016, at 12:34 pm, Rajeev Chamyal wrote:
>
> Hello Avik,
>
> x variable on line 2195 is
Hi Rajeev,
The fix looks fine to me.
With Regards,
Avik Niyogi
-Original Message-
From: Rajeev Chamyal
Sent: 23 March 2016 14:45
To: Sergey Bylokhov; Alexander Scherbatiy; [email protected]
<mailto:[email protected]>
Subject: RE: [9] Review request for JDK-8
A gentle reminder, Please review the code changes as presented below.
With Regards,
Avik Niyogi
> On 24-Mar-2016, at 3:01 pm, Rajeev Chamyal wrote:
>
> Looks good to me.
>
> Regards,
> Rajeev Chamyal
>
> From: Avik Niyogi
> Sent: 24 March 2016 12:54
>
Hi Sergey and Alexander,
Please review the code changes done.
With Regards,
Avik Niyogi
> On 28-Mar-2016, at 1:45 pm, Avik Niyogi wrote:
>
> A gentle reminder, Please review the code changes as presented below.
>
> With Regards,
> Avik Niyogi
>> On 24-Mar-2016, at
This has to be accounted for.
Fix:
All required edge case scenarios for the soft modification of Shift and cases
of valid modifiers were taken into account.
With Regards,
Avik Niyogi
Hi Sergey,
I have tried all these Input sources:
I am unable to reproduce the test failure as mentioned by you with these
inputs. Please provide some screenshots and/or details of the procedure used
for this test failure.
Thank you in advance.
With Regards,
Avik Niyogi
> On 08-Apr-2016, a
Hi All,
Please review my code changes with inputs received:
http://cr.openjdk.java.net/~aniyogi/8152492/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8152492/webrev.01/>
With Regards,
Avik Niyogi
> On 19-Apr-2016, at 11:47 am, Avik Niyogi wrote:
>
> Hi Sergey,
> I have tri
Hi All,
I have added some comments and made some minor tweaks as per the inputs
received.
Please review my code changes as available at this link below:
http://cr.openjdk.java.net/~aniyogi/8152492/webrev.02/
<http://cr.openjdk.java.net/~aniyogi/8152492/webrev.02/>
With Regards,
Avik
Chamyal
>>
>> -Original Message-
>> From: Sergey Bylokhov
>> Sent: 02 May 2016 19:05
>> To: Rajeev Chamyal; [email protected]; Avik Niyogi
>> Subject: Re: [9] Review request for JDK-8153282 [TEST_BUG] some
>> new JInternalFrame tests f
height) for Mac.
With Regards,
Avik Niyogi
1/>
With Regards,
Avik Niyogi
> On 24-May-2016, at 5:58 pm, Alexander Scherbatiy
> wrote:
>
> On 24/05/16 15:22, Avik Niyogi wrote:
>> Hi All,
>>
>> Kindly review the fix for JDK9.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8144161
>
Changes updated to same webrev.01
> http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01
> <http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01>
With regards,
Avik Niyogi
> On 25-May-2016, at 2:21 pm, Rajeev Chamyal wrote:
>
> Looks ok to me.
> Can you please ad
A gentle reminder. Please review the bug fix:
http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/>
With Regards,
Avik Niyogi
> On 25-May-2016, at 2:30 pm, Avik Niyogi wrote:
>
> Changes updated to same we
A gentle reminder. Please review the bug fix.
http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/>
With Regards,
Avik Niyogi
> On 27-May-2016, at 12:59 pm, Avik Niyogi wrote:
>
> A gentle reminder. Please review the
owerHalfDrop Test case throws an exception when the behaviour
is as expected.
Cause: The robot does not have enough delay to run appropriately.
Fix: The test case was fixed to have enough delay for the test case.
With Regards,
Avik Niyogi
Hi All,
Please review the code changes with inputs provided.
http://cr.openjdk.java.net/~aniyogi/8132771/webrev.01/
<http://cr.openjdk.java.net/~aniyogi/8132771/webrev.01/>
With Regards,
Avik Niyogi
> On 31-May-2016, at 1:24 pm, Rajeev Chamyal wrote:
>
> Hello Avik,
>
>
Event is not fired for menu item with option
apple.laf.useScreenMenuBar
Cause: The case for event that is not a Keydown has to be handled
Fix: With fixing the if - else loop, the correct behaviour was confirmed.
With Regards,
Avik Niyogi
Hi Sergey,
I ran the relevant test cases:
ActionListenerCalledTwiceTest
ScreenMenuBarInputTwice
with different keyboard preferences and locales.
Also tried different LAFs but found that only default (aqua) LAF is relevant
for this case.
With Regards,
Avik Niyogi
> On 31-May-2016, at 7:05
The bug fix looks good to me.
With Regards,
Avik Niyogi
> On 03-Jun-2016, at 11:31 am, Rajeev Chamyal wrote:
>
>
>
> From: Alexandr Scherbatiy
> Sent: 02 June 2016 12:00
> To: Rajeev Chamyal; Sergey Bylokhov; [email protected]
> <mailto:swing-dev@open
ound colours.
With Regards,
Avik Niyogi
ore specific on "negative scenarios" why they are
> necessary ?
>
> Also could you replace labeled break with "return foundMatch; "
>
> --Semyon
>
>
> On 07.07.2016 15:11, Avik Niyogi wrote:
>> Hi All,
>>
>> Kindly review the fix for J
inputs
to modify the test case will be welcome.
With Regards,
Avik Niyogi
> On 07-Jul-2016, at 9:51 pm, Semyon Sadetsky
> wrote:
>
>
>
> On 7/7/2016 6:30 PM, Yuri Nesterenko wrote:
>> On 07/07/2016 06:15 PM, Semyon Sadetsky wrote:
>>>
>>>
>
Hi All,
A gentle reminder, please review my code changes.
With Regards,
Avik Niyogi
> On 08-Jul-2016, at 4:24 pm, Yuri Nesterenko
> wrote:
>
> It pass for me if I provide some time to process native events
> after the user activity simulation. For instance,
> setAutoDelay(
Hi All,
Please find my webrev below for review which includes changes as perceived from
inputs provided.
http://cr.openjdk.java.net/~aniyogi/8160438/webrev.02/
<http://cr.openjdk.java.net/~aniyogi/8160438/webrev.02/>
With Regards,
Avik Niyogi
> On 12-Jul-2016, at 7:12 pm, Alexandr S
Another gentle reminder, please review my code changes. Thank you in advance.
With Regards,
Avik Niyogi
> On 14-Jul-2016, at 8:46 pm, Alexandr Scherbatiy
> wrote:
>
>
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 7/14/2016 9:53 AM, Avik Niyogi wrote
Hi Prasanta,
Kindly request you to review the webrev raised with inputs taken from reviewers
in the mail trail. Thank you in advance.
With Regards,
Avik Niyogi
> On 15-Jul-2016, at 11:37 am, Avik Niyogi wrote:
>
> I will ask Prasanta to review since it is not a native code change.
&g
1 - 100 of 142 matches
Mail list logo
