Re: [sympy] Doubt Regarding .mailmap file

2024-02-03 Thread ABHISHEK KUMAR
No, if you are a contributor, you don't need to include it in.mailmap. You just need to sync up the changes in the base branch and your name will reflect back there. On Fri, 2 Feb 2024, 11:06 pm Shishir Kushwaha, < kushwahashishir1...@gmail.com> wrote: > Do I need to add my details everytime to t

Re: [sympy] Doubt Regarding .mailmap file

2024-02-03 Thread Ankit Kumar Singh
Refresh your current branch with the master branch and make sure your name is in the mailmap file. On Fri, Feb 2, 2024, 11:06 PM Shishir Kushwaha < kushwahashishir1...@gmail.com> wrote: > Do I need to add my details everytime to thee .mailmap file when making a > PR , I did it in my first PR as m

Re: [sympy] Doubt Regarding .mailmap file

2024-02-02 Thread Shishir Kushwaha
Yes i forgot to sync with the upstream before creating the changes , It is solved now . Thank you for your time and help . On Saturday 3 February 2024 at 04:01:06 UTC+5:30 Oscar wrote: > It's hard to tell from a screenshot. Do you have a link to the PR? > > On Fri, 2 Feb 2024 at 17:36, Shishir K

Re: [sympy] Doubt Regarding .mailmap file

2024-02-02 Thread Oscar Benjamin
It's hard to tell from a screenshot. Do you have a link to the PR? On Fri, 2 Feb 2024 at 17:36, Shishir Kushwaha wrote: > > Do I need to add my details everytime to thee .mailmap file when making a PR > , I did it in my first PR as mentioned in the documentation but when creating > a new comitt

Re: [sympy] Doubt Regarding .mailmap file

2024-02-02 Thread Aaron Meurer
Is the name and email there the same as the one you added? If you changed the spelling of your name or the email, you have to add another entry to .mailmap. The point of .mailmap is to indicate when two different name/emails are actually the same person. Otherwise, I suspect the issue is that you

[sympy] Doubt Regarding .mailmap file

2024-02-02 Thread Shishir Kushwaha
Do I need to add my details everytime to thee .mailmap file when making a PR , I did it in my first PR as mentioned in the documentation but when creating a new comitt on another issue , the authro test was failing even though my name is there in the file already . Any idea why this could happe