Re: [sympy] Future plans for pattern matching

2010-05-04 Thread Ronan Lamy
Le lundi 03 mai 2010 à 22:11 +0200, Sebastian a écrit : Thanks for all your comments, it's very helpful to get so thorough feedback. On 05/03/2010 06:21 PM, Ronan Lamy wrote: Le dimanche 02 mai 2010 à 09:46 -0700, basti a écrit : The last few days I spent quite some time on

Re: [sympy] Future plans for pattern matching

2010-05-04 Thread Sebastian
On 05/04/2010 05:08 PM, Ronan Lamy wrote: Le lundi 03 mai 2010 à 22:11 +0200, Sebastian a écrit : Thanks for all your comments, it's very helpful to get so thorough feedback. On 05/03/2010 06:21 PM, Ronan Lamy wrote: Le dimanche 02 mai 2010 à 09:46 -0700, basti a écrit :

Re: [sympy] Future plans for pattern matching

2010-05-04 Thread Aaron S. Meurer
This probably goes without saying, but speed is an issue here, at least for atomic matching and substitution. For example, there are two match() calls in Basic._compare_pretty that are called all the time when using sympy. Making sure that this runs fast will therefore be very important

Re: [sympy] Future plans for pattern matching

2010-05-04 Thread Sebastian
Substitution I think that structural substitution should be a separate function, not just a subroutine handling a special case in subs. This would be useful for common subexpression elimination, at least. What do you understand under structural substitution? Do you

Re: [sympy] Future plans for pattern matching

2010-05-03 Thread Sebastian
Thanks for all your comments, it's very helpful to get so thorough feedback. On 05/03/2010 06:21 PM, Ronan Lamy wrote: Le dimanche 02 mai 2010 à 09:46 -0700, basti a écrit : The last few days I spent quite some time on understanding the pattern matching and substitution logic in sympy and

Re: [sympy] Future plans for pattern matching

2010-05-03 Thread Aaron S. Meurer
On May 3, 2010, at 10:21 AM, Ronan Lamy wrote: Le dimanche 02 mai 2010 à 09:46 -0700, basti a écrit : The last few days I spent quite some time on understanding the pattern matching and substitution logic in sympy and trying out ideas to improve them. Now I feel able and willing to redesign

Re: [sympy] Future plans for pattern matching

2010-05-03 Thread Aaron S. Meurer
On May 3, 2010, at 2:11 PM, Sebastian wrote: Thanks for all your comments, it's very helpful to get so thorough feedback. On 05/03/2010 06:21 PM, Ronan Lamy wrote: Le dimanche 02 mai 2010 à 09:46 -0700, basti a écrit : The last few days I spent quite some time on understanding the

[sympy] Future plans for pattern matching

2010-05-02 Thread basti
The last few days I spent quite some time on understanding the pattern matching and substitution logic in sympy and trying out ideas to improve them. Now I feel able and willing to redesign most of the stuff and will in the following give an overview about my plans. The ultimate goal is to have a

Re: [sympy] Future plans for pattern matching

2010-05-02 Thread Aaron S. Meurer
On May 2, 2010, at 10:46 AM, basti wrote: The last few days I spent quite some time on understanding the pattern matching and substitution logic in sympy and trying out ideas to improve them. Now I feel able and willing to redesign most of the stuff and will in the following give an overview

Re: [sympy] Future plans for pattern matching

2010-05-02 Thread Aaron S. Meurer
Regarding your guides: I'm assuming match() is not implemented yet, so the doctests shouldn't be working (they don't). Even so, I see this: match(x+y, x+u) {u: x+y} Shouldn't it rather be {u: y}. Regarding evenness, does that mean you will fix issue 1784? (+1) By the way, some of this

Re: [sympy] Future plans for pattern matching

2010-05-02 Thread Sebastian
On 05/02/2010 07:58 PM, Aaron S. Meurer wrote: Regarding your guides: I'm assuming match() is not implemented yet, so the doctests shouldn't be working (they don't). Even so, I see this: match(x+y, x+u) {u: x+y} Shouldn't it rather be {u: y}. Sorry, I forgot pushing