Re: [sympy] Irreducibility test

2010-03-08 Thread Priit Laes
Ühel kenal päeval, P, 2010-03-07 kell 14:07, kirjutas Kasun Samarasinghe: hi, I have attached the patch with this for rabin's test for irreducibility test. Please give me some comments on that. +def gf_irreducible_rabin(f, p, K): +Test for the irreducibility of a polynomial over

Re: [sympy] Irreducibility test

2010-03-08 Thread Kasun Samarasinghe
I have done test my self for the test cases for irreducibility already have in sympy. but i will add test to the galois_tools test file and attacha patch for your comments again. Thank you for the comments, kasun On Mon, Mar 8, 2010 at 12:33 PM, Priit Laes plaes...@gmail.com wrote: Ühel

Re: [sympy] Irreducibility test

2010-03-08 Thread Aaron S. Meurer
On Mar 8, 2010, at 4:33 AM, Priit Laes wrote: Ühel kenal päeval, P, 2010-03-07 kell 14:07, kirjutas Kasun Samarasinghe: hi, I have attached the patch with this for rabin's test for irreducibility test. Please give me some comments on that. +def gf_irreducible_rabin(f, p, K): +Test

Re: [sympy] Irreducibility test

2010-03-08 Thread Kasun Samarasinghe
hi I just used pi to correspond to p sub script i. since for each pi we check the relevant conditions. I did not see any conflict with other variables.?. Also will a test function in test_galoistools would be sufficient? Thank you, kasun On Mon, Mar 8, 2010 at 5:03 PM, Aaron S. Meurer

Re: [sympy] Irreducibility test

2010-03-08 Thread Aaron S. Meurer
Yes, I think that would be where to put the test. Maybe p_i then. It won't actually conflict with anything, but it can be confusing. Aaron Meurer On Mar 8, 2010, at 10:02 AM, Kasun Samarasinghe wrote: hi I just used pi to correspond to p sub script i. since for each pi we check the

Re: [sympy] Irreducibility test

2010-03-07 Thread Kasun Samarasinghe
hi, I have attached the patch with this for rabin's test for irreducibility test. Please give me some comments on that. Kasun On Sat, Mar 6, 2010 at 8:32 AM, Ondrej Certik ond...@certik.cz wrote: On Fri, Mar 5, 2010 at 3:00 PM, Kasun Samarasinghe kwsamarasin...@gmail.com wrote: hi, how

Re: [sympy] Irreducibility test

2010-03-05 Thread Kasun Samarasinghe
hi, how can i patch the modification i done using git? kasun On Tue, Mar 2, 2010 at 11:20 PM, Ondrej Certik ond...@certik.cz wrote: On Tue, Mar 2, 2010 at 2:10 PM, Kasun Samarasinghe kwsamarasin...@gmail.com wrote: Hi, I have implemented the rabis's irreducibility test in galois tool.

Re: [sympy] Irreducibility test

2010-03-05 Thread Ondrej Certik
On Fri, Mar 5, 2010 at 3:00 PM, Kasun Samarasinghe kwsamarasin...@gmail.com wrote: hi, how can i patch the modification i done using git? I created some video tutorials here: http://code.google.com/p/sympy/wiki/GitTutorials Ondrej -- You received this message because you are subscribed to

[sympy] Irreducibility test

2010-03-02 Thread Kasun Samarasinghe
Hi, I have implemented the rabis's irreducibility test in galois tool. How can I send it to you all to get comments. Regards Kasun -- You received this message because you are subscribed to the Google Groups sympy group. To post to this group, send email to sy...@googlegroups.com. To

Re: [sympy] Irreducibility test

2010-03-02 Thread Ondrej Certik
On Tue, Mar 2, 2010 at 2:10 PM, Kasun Samarasinghe kwsamarasin...@gmail.com wrote: Hi, I have implemented the rabis's irreducibility test in galois tool. How can I send it to you all to get comments. Publish a branch at github, or send a patch using git. Ondrej -- You received this message