Re: [sympy] doubt regarding test files

2017-03-29 Thread Vedarth Sharma
One more thing, should I debug and implement new algorithms first or refactor the module first? On Thursday, 30 March 2017 04:29:34 UTC+5:30, Aaron Meurer wrote: > > You can submit a draft to Google's website, but make sure to also > submit a final version before the deadline. > > It would help

Re: [sympy] doubt regarding test files

2017-03-29 Thread Vedarth Sharma
What about the basic idea? Is it too much or too less or the right amount? Also, my basic idea is rewriting a module. How am i supposed to show implementation part? -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and st

Re: [sympy] doubt regarding test files

2017-03-29 Thread Aaron Meurer
You can submit a draft to Google's website, but make sure to also submit a final version before the deadline. It would help to clean up the formatting, especially for the timeline. You can look at other proposals to see how people are doing it. Beyond that, the proposal could use some more detail

Re: [sympy] doubt regarding test files

2017-03-29 Thread Vedarth Sharma
https://github.com/sympy/sympy/wiki/GSoC-2017-Application-Vedarth-Sharma-:-Rewriting-the-Matrices-module-to-make-matrices-in-Sympy-faster-and-more-usable. kindly give me some feedback. I would really appreciate it. I know it is not perfect but it is just a draft right now. Should I submit it to g

Re: [sympy] doubt regarding test files

2017-03-29 Thread Vedarth Sharma
I will submit the draft to you in about 2 hours. Kindly review it and give your feedback. Thanks for your help. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+u

Re: [sympy] doubt regarding test files

2017-03-29 Thread Aaron Meurer
Bugfix only projects are allowed, although we have never had one before. You just need to make sure that your proposal is clear enough on what you plan to do, so that it is possible to do the evaluations. Aaron Meurer On Wed, Mar 29, 2017 at 11:31 AM, Vedarth Sharma wrote: > Can my project propo

Re: [sympy] doubt regarding test files

2017-03-29 Thread Vedarth Sharma
Can my project proposal involve fixing a module i.e. fixing bugs? I mean obviously organizing it and rewriting it properly of course. Is it allowed? Or should I do something more? -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from th

Re: [sympy] doubt regarding test files

2017-03-24 Thread Aaron Meurer
Doing a pull request that is related to your proposal is always a good idea, if you are unsure what else to do. Aaron Meurer On Fri, Mar 24, 2017 at 1:21 PM, Vedarth Sharma wrote: > Definitely. I will contribute more frequently and try to solve more > significant issues. I have been going throug

Re: [sympy] doubt regarding test files

2017-03-24 Thread Vedarth Sharma
Definitely. I will contribute more frequently and try to solve more significant issues. I have been going through sympy's code base and issue tracker for past 3 months, but wasn't able to make any significant contribution because I was busy with my exams (and some other stuff). But now I'll be

Re: [sympy] doubt regarding test files

2017-03-24 Thread Aaron Meurer
It does technically fulfill the requirement, but I would suggest doing something more to make your proposal stronger. Aaron Meurer On Fri, Mar 24, 2017 at 2:58 AM, Vedarth Sharma wrote: > Done. And it got merged as well :). Does that fulfill my patch requirement or > do i need to submit a pull

Re: [sympy] doubt regarding test files

2017-03-23 Thread Vedarth Sharma
Done. And it got merged as well :). Does that fulfill my patch requirement or do i need to submit a pull request related to my proposal as well? -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails f

Re: [sympy] doubt regarding test files

2017-03-22 Thread Aaron Meurer
Just changing the name should work. None of the tests are referenced anywhere else in the code, and all the tests are gathered by the test runner automatically. Be sure to use 'git mv' to change the filename, so that git properly removes the old file and adds the new one. Aaron Meurer On Tue, Ma

Re: [sympy] doubt regarding test files

2017-03-21 Thread Vedarth Sharma
I would like to submit a patch with changed name of file. Should I just change the name of file or something more is required. Where else do i need to make this modification? Right now sympy.test() doesn't work on matexpr. -- You received this message because you are subscribed to the Google Gr

Re: [sympy] doubt regarding test files

2017-03-20 Thread Aaron Meurer
Yes, I don't know why that file isn't called test_matexpr.py. We should change it. As for the patch requirement, yes, it means getting a pull request submitted by the application deadline (April 3), and merged soon thereafter. We a little lax on the actual merging deadline, because we know that re

Re: [sympy] doubt regarding test files

2017-03-20 Thread Vedarth Sharma
That was really helpful. Thanks a lot. I made a change to matexpr and was really unsure should i submit a pull request or not because i just couldn't run tests on it. Btw shouldn't the test file follow the same naming convention and same location convention as mentioned in sympy wiki? Another q

Re: [sympy] doubt regarding test files

2017-03-20 Thread Aaron Meurer
Some files don't have tests, but more likely is that the tests are in another file. In this case, it looks like there is test_matrix_exprs.py. In general, if you make a change to a file in a submodule, like sympy.matrices, I would recommend running the tests for the whole submodule, and any other

[sympy] doubt regarding test files

2017-03-20 Thread Vedarth Sharma
I noticed that some files like matexpr.py do not have their test files. So I was wondering why is that so? And how are we supposed to run tests on them? -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving