Re: [sympy] review request

2013-04-19 Thread Aaron Meurer
Maybe some of the GSoC applicants could help out. Reviewing others' code is a great way to become more familiar with the code base, and to improve your own coding practices. Aaron Meurer On Apr 18, 2013, at 11:24 PM, smichr smi...@gmail.com wrote: These branches (with indicated PR number) and

[sympy] review request

2013-04-18 Thread smichr
These branches (with indicated PR number) and addressed issues are in need of review. https://github.com/sympy/sympy/pull/1925 +3712 PR1925 (issue https://code.google.com/p/sympy/issues/detail?id=3712, https://code.google.com/p/sympy/issues/detail?id=3475)

[sympy] review request

2011-09-20 Thread smichr
I have a short pull request for review: https://github.com/sympy/sympy/pull/596 as_independent uses has to determine whether an expression has the symbol of interest or not. A potential problem is that an expression may have a bound symbol x that is not part of the free symbols of the

Re: [sympy] review request

2010-07-17 Thread Priit Laes
Ühel kenal päeval, R, 2010-07-16 kell 03:00, kirjutas smichr: Hi all, I have a lot of work that I have separated out into about 35 issues. The work deals with everything from minor editing of code, to handling of non-commutatives in simplifications and (hopefully) a total purge of

Re: [sympy] review request

2010-07-17 Thread Ondrej Certik
On Sat, Jul 17, 2010 at 12:13 AM, Aaron S. Meurer asmeu...@gmail.com wrote: On Jul 16, 2010, at 4:00 AM, smichr wrote: Hi all, I have a lot of work that I have separated out into about 35 issues. The work deals with everything from minor editing of code, to handling of non-commutatives in

Re: [sympy] review request

2010-07-17 Thread Aaron S. Meurer
Given the complexity of the patchset, I would recommend to use the smartbear web hosted tool that Andy and I used for reviewing the fortran code generator. Andy fixed it so that we have a free hosting for the Sympy project on their demo server, see this post:

Re: [sympy] review request

2010-07-17 Thread Aaron S. Meurer
On Jul 17, 2010, at 2:19 AM, Ondrej Certik wrote: On Sat, Jul 17, 2010 at 12:13 AM, Aaron S. Meurer asmeu...@gmail.com wrote: On Jul 16, 2010, at 4:00 AM, smichr wrote: Hi all, I have a lot of work that I have separated out into about 35 issues. The work deals with everything from

Issue 1510 in sympy: Review request for variable separation for partial differential equations

2009-07-06 Thread codesite-noreply
Updates: Status: Fixed Comment #1 on issue 1510 by ondrej.certik: Review request for variable separation for partial differential equations http://code.google.com/p/sympy/issues/detail?id=1510 Patches are +1, they are in, thanks! -- You received this message because you are listed in

Issue 1510 in sympy: Review request for variable separation for partial differential equations

2009-07-01 Thread codesite-noreply
Status: Accepted Owner: plaes800 CC: ondrej.certik Labels: Type-Enhancement Priority-Medium New issue 1510 by plaes800: Review request for variable separation for partial differential equations http://code.google.com/p/sympy/issues/detail?id=1510 Adds variable separation helpers for partial