Re: Issue 1263 in sympy: Invalid movement of roots across fractions

2010-06-14 Thread sympy
Comment #27 on issue 1263 by smichr: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 I can see now that as_base_exp was only dealing with the case where the argument was a Rational (not a rational) so I really didn't fix anything there. I wi

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

2010-06-14 Thread sympy
Updates: Labels: -NeedsBetterPatch NeedsReview Comment #26 on issue 1263 by smichr: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 The test has been changed to simplify(sqrt(1/n)) != 1/sqrt(n). -- You received this message because you

Issue 1958 in sympy: Bugs with greek letter symbols

2010-06-14 Thread sympy
Status: Accepted Owner: asmeurer Labels: Type-Defect Priority-Medium New issue 1958 by asmeurer: Bugs with greek letter symbols http://code.google.com/p/sympy/issues/detail?id=1958 In [13]: f = Function('phi') In [14]: f Out[14]: phi In [15]: f = Symbol('phi_nu') In [16]: f Out[16]: φ_nu In

Issue 1957 in sympy: Open parenthesis '(' does not work in live.sympy.org in Safari or Chrome

2010-06-14 Thread sympy
Status: Accepted Owner: asmeurer Labels: Type-Defect Priority-Medium New issue 1957 by asmeurer: Open parenthesis '(' does not work in live.sympy.org in Safari or Chrome http://code.google.com/p/sympy/issues/detail?id=1957 Mac OS X 10.6.3. Typing an open parenthesis does not work in live.s

Re: Issue 1955 in sympy: Update to mpmath 0.15

2010-06-14 Thread sympy
Updates: Status: Fixed Comment #7 on issue 1955 by asmeurer: Update to mpmath 0.15 http://code.google.com/p/sympy/issues/detail?id=1955 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post t

Re: Issue 1955 in sympy: Update to mpmath 0.15

2010-06-14 Thread sympy
Comment #6 on issue 1955 by asmeurer: Update to mpmath 0.15 http://code.google.com/p/sympy/issues/detail?id=1955 Maybe you forgot to do "make clean" first? Anyway, I pushed it in. -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to thi

Re: Issue 1843 in sympy: Increase coverage of ode.py

2010-06-14 Thread sympy
Comment #11 on issue 1843 by asmeurer: Increase coverage of ode.py http://code.google.com/p/sympy/issues/detail?id=1843 Ah, you are right. I made a note of this on issue 1841. Thanks for pushing this in. -- You received this message because you are subscribed to the Google Groups "sympy-issu

Re: Issue 1841 in sympy: Replace map() with a list compression in most cases

2010-06-14 Thread sympy
Comment #1 on issue 1841 by asmeurer: Replace map() with a list compression in most cases http://code.google.com/p/sympy/issues/detail?id=1841 As noted in comment 10 of issue 1843, generators, i.e., (x**i for i in range(100)), can often be even more efficient than list comprehensions. --

Re: Issue 1955 in sympy: Update to mpmath 0.15

2010-06-14 Thread sympy
Updates: Labels: -NeedsReview PassedReview Comment #5 on issue 1955 by Vinzent.Steinberg: Update to mpmath 0.15 http://code.google.com/p/sympy/issues/detail?id=1955 Strangely it works now, so the docs are fine. +1 :) -- You received this message because you are subscribed to the Google

Re: Issue 1910 in sympy: Update --help for bin/test and bin/doctest with glob information

2010-06-14 Thread sympy
Updates: Status: Fixed Labels: -NeedsReview Comment #4 on issue 1910 by Vinzent.Steinberg: Update --help for bin/test and bin/doctest with glob information http://code.google.com/p/sympy/issues/detail?id=1910 Thank you, I pushed it in. -- You received this message because you

Re: Issue 1843 in sympy: Increase coverage of ode.py

2010-06-14 Thread sympy
Updates: Status: Fixed Labels: -NeedsReview Comment #10 on issue 1843 by Vinzent.Steinberg: Increase coverage of ode.py http://code.google.com/p/sympy/issues/detail?id=1843 A general note about list comprehensions: You can often use generators instead, which can simplify the sy

Re: Issue 1955 in sympy: Update to mpmath 0.15

2010-06-14 Thread sympy
Comment #4 on issue 1955 by asmeurer: Update to mpmath 0.15 http://code.google.com/p/sympy/issues/detail?id=1955 The docs build fine for me. I even went through each page in my browser to make sure they looked OK. I am running Sphinx 0.6.2. -- You received this message because you are subs

Re: Issue 1949 in sympy: Doctests for polynomials module

2010-06-14 Thread sympy
Comment #2 on issue 1949 by asmeurer: Doctests for polynomials module http://code.google.com/p/sympy/issues/detail?id=1949 No, polys9 is not ready to go in (test failures for one). This will have to wait at least until that. My main reason for putting this up was so Mateusz look it over an

Re: Issue 1949 in sympy: Doctests for polynomials module

2010-06-14 Thread sympy
Comment #1 on issue 1949 by Vinzent.Steinberg: Doctests for polynomials module http://code.google.com/p/sympy/issues/detail?id=1949 Did you actually review polys9, Aaron? -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group

Re: Issue 1955 in sympy: Update to mpmath 0.15

2010-06-14 Thread sympy
Comment #3 on issue 1955 by Vinzent.Steinberg: Update to mpmath 0.15 http://code.google.com/p/sympy/issues/detail?id=1955 All tests pass (even faster than before :), this part looks fine. I'm not sure whether 372e6aba and fdac1eb should be actually squashed. And maybe 1b86eda too. The docs h

Re: Issue 1903 in sympy: Unify Assume keys, ask keys and ask handlers

2010-06-14 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #12 on issue 1903 by Vinzent.Steinberg: Unify Assume keys, ask keys and ask handlers http://code.google.com/p/sympy/issues/detail?id=1903 Christian, your review is as official as any other one. :) The main goal is to catch thing

Re: Issue 1942 in sympy: Refactor the singleton mechanism

2010-06-14 Thread sympy
Comment #2 on issue 1942 by Vinzent.Steinberg: Refactor the singleton mechanism http://code.google.com/p/sympy/issues/detail?id=1942 Looks fine to me. Why should Singleton derive from Atom? Please add it to the commit message. The docstring should be fixed, but this can be done later. Yo

Re: Issue 1956 in sympy: mpmath: test_visualization fails on AttributeError with matplotlib 0.91.2

2010-06-14 Thread sympy
Comment #5 on issue 1956 by jensen.oyvind: mpmath: test_visualization fails on AttributeError with matplotlib 0.91.2 http://code.google.com/p/sympy/issues/detail?id=1956 I get the error because of the old version of matplotlib I have available on my ubuntu 8.04. So it does make sense to ch

Re: Issue 1819 in sympy: _sympify(True) == 1

2010-06-14 Thread sympy
Updates: Status: Fixed Comment #2 on issue 1819 by Vinzent.Steinberg: _sympify(True) == 1 http://code.google.com/p/sympy/issues/detail?id=1819 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To

Re: Issue 1896 in sympy: Inner core refactoring

2010-06-14 Thread sympy
Updates: Status: Fixed Labels: -NeedsReview Comment #1 on issue 1896 by Vinzent.Steinberg: Inner core refactoring http://code.google.com/p/sympy/issues/detail?id=1896 Thank you, I pushed it in. -- You received this message because you are subscribed to the Google Groups "sympy-

Re: Issue 1956 in sympy: mpmath: test_visualization fails on AttributeError with matplotlib 0.91.2

2010-06-14 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #4 on issue 1956 by asmeurer: mpmath: test_visualization fails on AttributeError with matplotlib 0.91.2 http://code.google.com/p/sympy/issues/detail?id=1956 I think that both what is already there and this patch should be changed

Re: Issue 1956 in sympy: mpmath: test_visualization fails on AttributeError with matplotlib 0.91.2

2010-06-14 Thread sympy
Comment #3 on issue 1956 by fredrik.johansson: mpmath: test_visualization fails on AttributeError with matplotlib 0.91.2 http://code.google.com/p/sympy/issues/detail?id=1956 I implemented a slightly different fix in http://code.google.com/p/mpmath/source/detail?r=1157 Since there could be

Re: Issue 1956 in sympy: mpmath: test_visualization fails on AttributeError with matplotlib 0.91.2

2010-06-14 Thread sympy
Updates: Cc: fredrik.johansson Comment #2 on issue 1956 by Vinzent.Steinberg: mpmath: test_visualization fails on AttributeError with matplotlib 0.91.2 http://code.google.com/p/sympy/issues/detail?id=1956 This should be fixed upstream. Btw, I do not get the failure with matplotlib 0.

Re: Issue 1943 in sympy: Need a superclass of Function that doesn't subclass Expr

2010-06-14 Thread sympy
Updates: Status: Fixed Labels: -NeedsReview Comment #1 on issue 1943 by Vinzent.Steinberg: Need a superclass of Function that doesn't subclass Expr http://code.google.com/p/sympy/issues/detail?id=1943 Thanks, this looks fine an is in now. -- You received this message because

Re: Issue 1928 in sympy: Add __xor__ magic method to Boolean

2010-06-14 Thread sympy
Updates: Labels: -NeedsReview PassedReview Comment #12 on issue 1928 by Vinzent.Steinberg: Add __xor__ magic method to Boolean http://code.google.com/p/sympy/issues/detail?id=1928 I'm positive about the __xor__ change. Users are warned about '^' in the docs. -- You received this m

Re: Issue 1864 in sympy: AttributeError: is_commutative with Mul(Pow(2, 2, evaluate=False), 3, evaluate=False) + 1

2010-06-14 Thread sympy
Updates: Status: Fixed Comment #15 on issue 1864 by Vinzent.Steinberg: AttributeError: is_commutative with Mul(Pow(2, 2, evaluate=False), 3, evaluate=False) + 1 http://code.google.com/p/sympy/issues/detail?id=1864 Thanks, this is finally in. -- You received this message because you a

Re: Issue 1376 in sympy: sympy.sum overrides built-in sum with a different call syntax

2010-06-14 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #7 on issue 1376 by Vinzent.Steinberg: sympy.sum overrides built-in sum with a different call syntax http://code.google.com/p/sympy/issues/detail?id=1376 I agree with Ronan. Also I don't like that we are overwriting sum(), but t

Re: Issue 1545 in sympy: Efficient data representation in logic.satisfiable()

2010-06-14 Thread sympy
Updates: Labels: -NeedsReview Comment #18 on issue 1545 by Vinzent.Steinberg: Efficient data representation in logic.satisfiable() http://code.google.com/p/sympy/issues/detail?id=1545 I think this got in, feel free to correct me. -- You received this message because you are subscribe

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

2010-06-14 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #25 on issue 1263 by Vinzent.Steinberg: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 Looks good to me. However, the test you add seems not to fail in master. -- You received this