Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1852 by raffaele.defeo: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 x, y = symbols('xy', commutative = False) expand((x + y)**3) produces the following

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Comment #1 on issue 1852 by raffaele.defeo: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 I discovered what the problem is. To correct that issue, it is necessary a one row change to the file

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Updates: Status: Accepted Labels: NeedsReview Comment #2 on issue 1852 by asmeurer: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 That looks like it fixes it, but I need to run the tests to see if it breaks

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #3 on issue 1852 by asmeurer: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 OK tests all pass. Could you write this into a git patch and write a test for it? --

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Comment #4 on issue 1852 by raffaele.defeo: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 I can try... but this would be my git first time. Is there a tutorial to follow? All of the instructions I found refer to the use of

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Comment #5 on issue 1852 by asmeurer: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 Yes. Ondrej made tutorial specifically for SymPy. You can find them here: http://code.google.com/p/sympy/wiki/GitTutorials. -- You received

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Comment #6 on issue 1852 by smichr: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 It passes everything in 1766, too...but the issue is also present for a non-Add base: (x*y)**3 - x**3*y**3 instead of x*y*x*y*x*y Also, in

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Comment #7 on issue 1852 by asmeurer: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 This is related to issue 1261. -- You received this message because you are listed in the owner or CC fields of this issue, or because you

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Comment #8 on issue 1852 by raffaele.defeo: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 I hope the patch is good! Attachments: non-commutative-multinomial-power-expansion.patch 2.6 KB -- You received this message

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Updates: Labels: -NeedsBetterPatch PassedReview Comment #9 on issue 1852 by asmeurer: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 Thanks. This looked fine, so I pushed it in. Chris, does your problem still apply

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Comment #10 on issue 1852 by smichr: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 1261...and I raised a question there. -- You received this message because you are listed in the owner or CC fields of this issue, or because you

Re: Issue 1852 in sympy: expand fails when non-commutative symbols are involved

2010-03-08 Thread sympy
Updates: Status: Fixed Comment #11 on issue 1852 by asmeurer: expand fails when non-commutative symbols are involved http://code.google.com/p/sympy/issues/detail?id=1852 OK. I will close it then. -- You received this message because you are listed in the owner or CC fields of this