Updates:
Status: Fixed
Comment #17 on issue 2003 by asmeurer: Use factorint() with limit argument
in sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
This was pushed in (see the Pull Request). Don't forget to close the issue
when you merge in the Pull Requ
Comment #16 on issue 2003 by smichr: Use factorint() with limit argument in
sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
Review is happening at http://github.com/sympy/sympy/pull/8
--
You received this message because you are subscribed to the Google Groups
"sy
Comment #15 on issue 2003 by smichr: Use factorint() with limit argument in
sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
So I did...sorry about that. I wasn't looking at this page when I did it; I
was looking at another email that you sent about the process whi
Updates:
Cc: ondrej.certik
Comment #14 on issue 2003 by asmeurer: Use factorint() with limit argument
in sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
So you made the mistake that I suspected you might make, and tried to warn
you about. You sent the req
Comment #13 on issue 2003 by smichr: Use factorint() with limit argument in
sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
I appreciate the primer...thanks. I'll see what I can do.
--
You received this message because you are subscribed to the Google Groups
"symp
Comment #12 on issue 2003 by asmeurer: Use factorint() with limit argument
in sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
It's really easy. You go to the branch in GitHub (in this case, to
http://github.com/smichr/sympy/tree/2003). Then, you click on the but
Comment #11 on issue 2003 by smichr: Use factorint() with limit argument in
sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
I don't know how to do the pull request yet and can't look at this until
the weekend. Current 2003 has the routine moved and used in factor_
Comment #10 on issue 2003 by asmeurer: Use factorint() with limit argument
in sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
By the way, prime generation shouldn't matter after one run, because it
should use the global Sieve of Eratosthenes (i.e., the Sieve varia
Comment #9 on issue 2003 by asmeurer: Use factorint() with limit argument
in sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
Well, if the code outside of factorint() is really faster, then it should
be moved into factorint(). The point is that we shouldn't have a
Comment #8 on issue 2003 by smichr: Use factorint() with limit argument in
sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
factorint doesn't use trial division first and then other methods, it does
a little of both:
limit given
lo=3
high=250
while 1:
trial di
Comment #7 on issue 2003 by asmeurer: Use factorint() with limit argument
in sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
I haven't actually thoroughly read the factorint() code, but from what I
read in the docsrting, the point of the limit argument is that it
Comment #6 on issue 2003 by smichr: Use factorint() with limit argument in
sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
If the reviewer would prefer a standalone commit, there is one at
github/smichr/2003
--
You received this message because you are subscribe
Updates:
Labels: smichr
Comment #5 on issue 2003 by smichr: Use factorint() with limit argument in
sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
(No comment was entered for this change.)
--
You received this message because you are subscribed to the Googl
Updates:
Labels: NeedsReview
Comment #4 on issue 2003 by smichr: Use factorint() with limit argument in
sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
Please see commit 2003 of the github/smichr/2003 branch. Changes were made
to the eval_power (to use a
Comment #3 on issue 2003 by smichr: Use factorint() with limit argument in
sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
tentative changes in t2 under commit 2003. I'm not following everything you
are saying in comment 2, however.
(The factorials are examples
Comment #2 on issue 2003 by asmeurer: Use factorint() with limit argument
in sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
Actually, it already uses a function called
integer_nthroot() ._eval_power() to do this. We just need to make sure to
do this on any rem
Comment #1 on issue 2003 by asmeurer: Use factorint() with limit argument
in sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
Another thing is that we still need to catch perfect powers, even if they
are of large primes, because that is also inexpensive (see also w
Status: Accepted
Owner: asmeurer
Labels: Type-Defect Priority-Medium
New issue 2003 by asmeurer: Use factorint() with limit argument in
sympy/core/numbers.py
http://code.google.com/p/sympy/issues/detail?id=2003
Based on this thread:
http://groups.google.com/group/sympy/browse_thread/thread/
18 matches
Mail list logo
