Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-04-27 Thread sympy
Updates: Status: Fixed Comment #42 on issue 2133 by ronan.l...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 It's been merged -- You received this message because you are subscribed to the Google Groups sympy-issues group.

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-03-27 Thread sympy
Issue 2133: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 This issue is now blocking issue 1280. See http://code.google.com/p/sympy/issues/detail?id=1280 -- You received this message because you are listed in the owner or CC fields of this issue,

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-02-03 Thread sympy
Updates: Labels: -Priority-Medium Priority-Critical NeedsReview Comment #39 on issue 2133 by ronan.l...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 So, I have extracted the commits which I reviewed positively, and which

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-16 Thread sympy
Comment #38 on issue 2133 by matt...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 So do you know how to fix it? I don't know, so I just made the test work in 664856a14f4bf04a29485af01a574438ca478bd4 (I use as_ordered_terms()

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-15 Thread sympy
Comment #37 on issue 2133 by ronan.l...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 There are actually a lot of things to discuss, and I haven't reviewed half of it yet (see my comments on github). It would be easier if this

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #26 on issue 2133 by matt...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 In 0322f64353b0bc87c26390df1b3147ac82b60c16 I fixed the problem from #20. test_rootoftools.py:test_RootSum_independent This fails randomly on

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #27 on issue 2133 by matt...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 assert expr.as_ordered_terms() I tested all configurations and it doesn't fail for me. -- You received this message because you are subscribed to

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #28 on issue 2133 by matt...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 assert dsolve(eq2, f(x), hint='1st_homogeneous_coeff_best') == sol2 sol2 is a list and dsolve() doesn't sort lists of solutions, so this and

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #29 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 There is now a trivial failure in test_rationaltools.py (you just need to rewrite the output of an expression). Aaron, this gives me no information.

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #30 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 Really it is solve that should be sorting its output. -- You received this message because you are subscribed to the Google Groups sympy-issues group. To

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #31 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I did a little bisecting on the tests and figured out that it is test_implemented_function_evalf in test_evalf.py that is somehow causing that

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #32 on issue 2133 by matt...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 test_as_ordered_terms Now I see that this is cache related problem. -- You received this message because you are subscribed to the Google Groups

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #33 on issue 2133 by matt...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I tracked down this problem to implemented_function() from lambdify.py which modifies the global instance of a function when caching is enabled

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #34 on issue 2133 by matt...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 Well, I was hoping you could reproduce it yourself :) I'm not always able reproduce failures, so bin/test printing AssertionError isn't very

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #35 on issue 2133 by matt...@gmail.com: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I tracked down the problem with RootSum to: In [1]: var('a,b') Out[1]: (a, b) In [2]: f = (x**3 - a)**2*(x**4 - b)**3 In [3]: g = Lambda(x,

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-14 Thread sympy
Comment #36 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I tracked down this problem to implemented_function() from lambdify.py which modifies the global instance of a function when caching is enabled (see

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-13 Thread sympy
Updates: Labels: -NeedsBetterPatch NeedsReview Comment #18 on issue 2133 by mattpap: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 In 99e4eab95ee98ebc7cdcbdb7e60c6206a822e81a I updated the tests (in one case the solution is now

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-13 Thread sympy
Updates: Cc: Ronan.Lamy Vinzent.Steinberg Comment #19 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I bisected the sqrt(2) thing down to this commit, which seems unrelated: commit

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-13 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #20 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 OK, there is already at least on test failure: ___

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-13 Thread sympy
Comment #21 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 So it turns out that those other test failures are not tox related. The first one only shows up when running the full test suite; when testing

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-13 Thread sympy
Comment #22 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 There is an ode failure in 64-bit: ___ sympy/solvers/tests/test_ode.py:test_1st_homogeneous_coeff_ode2 File

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-13 Thread sympy
Comment #23 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 By the way, the RootSum failure is 32-bit only. -- You received this message because you are subscribed to the Google Groups sympy-issues group. To post to

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-13 Thread sympy
Comment #24 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 OK. Additional failures in Python2.4 (32-bit, python ground types): _ sympy/core/tests/test_expr.py:test_as_ordered_terms __

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-13 Thread sympy
Comment #25 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 Is your release0.7.0 branch still necessary, or have you merged all of those commits with polys12? -- You received this message because you are subscribed

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-12 Thread sympy
Comment #16 on issue 2133 by mattpap: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 1. In 5a58ad070d3a94fb4af6b22d19aa846623890c68 I removed all references to trim() from SymPy (or changed to simplify()). 2. In

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-10 Thread sympy
Comment #14 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 If you don't have gmpy installed, this is printed during the tests: sympy/polys/rootisolation.py[1] . [OK]

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-10 Thread sympy
Comment #15 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 Sorry, that's actually during the doctests, not the regular tests. -- You received this message because you are subscribed to the Google Groups sympy-issues

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-08 Thread sympy
Comment #13 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 The benchmarks do not run in polys12: __ entrypoint:

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-07 Thread sympy
Comment #12 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 Can you create a pull request for this branch and for any other branch that you want to get in? That will make t easier for people to review your code.

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-06 Thread sympy
Comment #8 on issue 2133 by mattpap: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I tracked this problem to: import math math.log(4, 2) 2.0 math.log(4L, 2) 1.9998 in Python 2.7. -- You received this message because you are

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-06 Thread sympy
Issue 2133: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 This issue is now blocking issue 1276. See http://code.google.com/p/sympy/issues/detail?id=1276 -- You received this message because you are listed in the owner or CC fields of this issue,

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-06 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #10 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 Regarding the math.log issue, isn't that to be expected, since math.log is a floating point function.

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-06 Thread sympy
Comment #11 on issue 2133 by mattpap: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 This is what Python devs wrote in bugs.python.org. This is of course correct explanation but in this (an a few other) special case the algorithm could

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-06 Thread sympy
Issue 2133: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 This issue is now blocking issue 1469. See http://code.google.com/p/sympy/issues/detail?id=1469 -- You received this message because you are listed in the owner or CC fields of this issue,

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-04 Thread sympy
Comment #4 on issue 2133 by mattpap: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 The ratint() example works when you apply doit() to the result: In [2]: from sympy.integrals.rationaltools import * In [3]: ratint(1/(x**2 + 1), x,

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-04 Thread sympy
Comment #5 on issue 2133 by mattpap: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I don't know how to run cythonized tests. Issue `make` in the main directory of sympy and it will compile selected modules in-place. Then run tests as

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-04 Thread sympy
Comment #6 on issue 2133 by mattpap: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I fixed test runner to work with Python 2.4, so now all tests in sympy.polys can be run in 2.4 and all pass. -- You received this message because you are

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-04 Thread sympy
Comment #7 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 Regarding the intervals thing, if I apply the patch: diff --git a/sympy/polys/tests/test_polytools.py b/sympy/polys/tests/test_polytools.py index

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-03 Thread sympy
Comment #1 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I don't know how to run cythonized tests. Otherwise, I have tested every combination, except that I do not have 64-bit Python 2.4 and I do not have gmpy

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-03 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch mattpap Comment #2 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I think the gmpy is not installed, using python ground types instead message should use the

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-03 Thread sympy
Comment #3 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I have a mistake above. It turns out that that intervals failure is on 32-bit and 64-bit Python 2.7 with python ground types only (which makes more