Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2012-10-14 Thread sympy
Updates: Labels: -NeedsReview Blockedon: -sympy:2307 sympy:2307 Comment #22 on issue 2308 by julien.r...@gmail.com: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 (No comment was entered for thi

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-18 Thread sympy
Updates: Summary: Should we rename primitive()? (and Expr.primitive() should call primitive()) Cc: matt...@gmail.com Comment #9 on issue 2308 by asmeurer: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=23

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-18 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #10 on issue 2308 by asmeurer: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 (No comment was entered for this change.) -- You received this messa

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-18 Thread sympy
Comment #11 on issue 2308 by matt...@gmail.com: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 a "primitive element" is (roughly) an element whose derivative (...) We also have primitive_element() in SymPy,

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-18 Thread sympy
Comment #12 on issue 2308 by asmeurer: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 Yeah, that's what I was referring to when I said "like primitive element in the sense of algebraic extensions." Mateusz,

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #13 on issue 2308 by smi...@gmail.com: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 Would 'kernel' be any better? "The choicest or most essential or most vital part of some idea or experience" --

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #14 on issue 2308 by asmeurer: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 If we were the mathematicians making up the names, that would be fine, but unfortunately, that has already happened. "Ker

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #15 on issue 2308 by smi...@gmail.com: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 Also is this the lack of unity between the function and method that is the source of the ending lines of comment 9

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #16 on issue 2308 by smi...@gmail.com: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 ...oops, rat_gcd can't take the place of as_coeff_Mul, but as_coeff_Mul could first call rat_gcd to get any buried

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #17 on issue 2308 by Vinzent.Steinberg: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 Well, if we have a clear docstring, I think "primitive" is fine. There are contradictory definitions of words, so

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #18 on issue 2308 by asmeurer: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 Well, Chris inadvertently brought up a good point. (2*x/3 + 4*y/9).primitive() => (2/9, 2*y + 3*x) is wrong. It should b

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-26 Thread sympy
Updates: Labels: -NeedsBetterPatch NeedsReview Comment #19 on issue 2308 by asmeurer: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 OK, I updated the branch at https://github.com/sympy/sympy/pull/322 t

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-27 Thread sympy
Comment #20 on issue 2308 by smi...@gmail.com: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 Why shouldn't `(2*x/3 + 4*y/9).primitive()` give `(2/3, x + 2*y/3)`? I don't know much about the algebra fields, b

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-06-04 Thread sympy
Updates: Labels: -Milestone-Release0.7.0 Comment #21 on issue 2308 by asmeurer: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 If we aren't going to change the name, this shouldn't block the release a