Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2012-04-10 Thread sympy
Status: Valid Owner: Labels: Type-Defect Priority-Medium WrongResult Matrices EasyToFix New issue 3221 by asmeu...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 The leading term of the characteristic pol

Re: Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2013-02-15 Thread sympy
Comment #1 on issue 3221 by mary.spr...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 From what I can see, the only method for calculating the characteristic polynomial is the Berkowitz algorithm, which sta

Re: Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2013-02-15 Thread sympy
Comment #2 on issue 3221 by asmeu...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 Probably we should just check if the leading coefficient of x**n in det() and multiply through by -1 if it isn't already -1

Re: Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2013-03-01 Thread sympy
Comment #3 on issue 3221 by khageshp...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 Is someone at this one because I want to do it. -- You received this message because this project is configured to send

Re: Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2013-03-21 Thread sympy
Comment #4 on issue 3221 by khageshp...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 https://github.com/sympy/sympy/pull/1919 -- You received this message because this project is configured to send all is

Re: Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2013-03-21 Thread sympy
Comment #5 on issue 3221 by matt...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 Doesn't the sign depend on the definition of characteristic polynomial? To me the result is correct assuming `charpoly(M) =

Re: Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2013-03-21 Thread sympy
Comment #6 on issue 3221 by khageshp...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 Yes det(t*I-M) will always give monic polynomial but which definition is used by sympy.Some authors support det(M-t*I) o

Re: Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2013-03-21 Thread sympy
Comment #7 on issue 3221 by matt...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 In berkowitz() and related methods we use det(t*I - M) (see the docstring) (charpoly() is an alias to berkowitz_charpoly()).

Re: Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2013-03-21 Thread sympy
Comment #8 on issue 3221 by khageshp...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 Then you should close this issue and there is also no point of this patch. -- You received this message because this proj

Re: Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2013-03-21 Thread sympy
Comment #9 on issue 3221 by khageshp...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 Then you can close this issue and there is also no point of this patch. -- You received this message because this project

Re: Issue 3221 in sympy: Matrix.charpoly() should include minus sign for odd order matrices

2013-03-21 Thread sympy
Updates: Status: WontFix Comment #10 on issue 3221 by asmeu...@gmail.com: Matrix.charpoly() should include minus sign for odd order matrices http://code.google.com/p/sympy/issues/detail?id=3221 I didn't realize that it was defined the other way. According to http://en.wikipedia.org