Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2013-04-18 Thread sympy
Comment #14 on issue 3226 by smi...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 Here is the corrected `di` function...but it is still slower. def di(eq, *syms): ... # find common subexpressions ... r, e = cse(eq)

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2013-04-16 Thread sympy
Updates: Labels: NeedsReview smichr Comment #12 on issue 3226 by smi...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 simplification is implemented in https://github.com/sympy/sympy/pull/1998 -- You received this

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2013-04-16 Thread sympy
Updates: Status: Fixed Comment #13 on issue 3226 by smi...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 (No comment was entered for this change.) -- You received this message because this project is configured to

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2013-04-10 Thread sympy
Comment #9 on issue 3226 by smi...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 I just confirmed that it's factor_terms and signsimp that are providing the simplification: print filldedent(factor_terms(s)) 3*(3*(-b**2

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2013-04-10 Thread sympy
Updates: Cc: smi...@gmail.com Comment #10 on issue 3226 by smi...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 I could be missing something here, but the pre-processing appears to take longer than just

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2013-04-10 Thread sympy
Comment #11 on issue 3226 by smi...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 cse(sqrt((a+c*t)**2+(x+t)*(a+c*t)**2+a*(x+t)) ... ) ([(x0, t + x), (x1, (a + c*t)**2)], [sqrt(a*x0 + x0*x1 + x1)]) Without preprocessing:

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2012-04-18 Thread sympy
Comment #7 on issue 3226 by valerywe...@hotmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 what about calling cse before and after the call to diff? can cse substitute things like eg (comment 1) g(f(x)) + h(f(x))? -- You

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2012-04-18 Thread sympy
Comment #8 on issue 3226 by smi...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 ([(x0, f(x))], [g(x0) + h(x0)]) -- You received this message because you are subscribed to the Google Groups sympy-issues group. To post to

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2012-04-15 Thread sympy
Updates: Labels: Simplify Comment #1 on issue 3226 by asmeu...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 If we do this right, it can also make it more efficient. The derivative of g(f(x)) + h(f(x)) is

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2012-04-15 Thread sympy
Comment #2 on issue 3226 by andreas.kloeck...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 Psst, csesimp is defined in the OP. :) -- You received this message because you are subscribed to the Google Groups sympy-issues

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2012-04-15 Thread sympy
Comment #3 on issue 3226 by asmeu...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 D'oh! -- You received this message because you are subscribed to the Google Groups sympy-issues group. To post to this group, send email to

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2012-04-15 Thread sympy
Comment #4 on issue 3226 by smi...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 It's what I posted in one of the comments, just a wrapper to running cse on an expression but only returning the expression. -- You received

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2012-04-15 Thread sympy
Comment #5 on issue 3226 by asmeu...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 I'm curious how csesimp() actually simplifies the expression. Are things just canceling in intermediate steps? Or does cse() do some

Re: Issue 3226 in sympy: high-order derivatives should be cse-simplified

2012-04-15 Thread sympy
Comment #6 on issue 3226 by smi...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 It does some fast simplifications, as I recall. You would have to check the code to know for sure. IIRC it uses factor_terms (but I could be

Issue 3226 in sympy: high-order derivatives should be cse-simplified

2012-04-14 Thread sympy
Status: Valid Owner: Labels: Type-Defect Priority-Medium New issue 3226 by smi...@gmail.com: high-order derivatives should be cse-simplified http://code.google.com/p/sympy/issues/detail?id=3226 In http://groups.google.com/group/sympy/t/9e7c4a7faa3e65b1 there was a discussion about the