Re: [PATCH 1/6] Improved documentation for evaluate_deltas

Looks good. On Sat, Feb 20, 2010 at 3:11 PM, Øyvind Jensen jensen.oyv...@gmail.comwrote: --- sympy/physics/secondquant.py | 25 + 1 files changed, 13 insertions(+), 12 deletions(-) diff --git a/sympy/physics/secondquant.py b/sympy/physics/secondquant.py index

Re: [PATCH 3/6] Refactoring in substitute_dummies and related helper routines

Looks good. On Sat, Feb 20, 2010 at 3:11 PM, Øyvind Jensen jensen.oyv...@gmail.comwrote: renamed the iterator '_reverse' to 'arg_iterator' for clarity --- sympy/physics/secondquant.py | 23 ++- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git

Re: [PATCH 4/6] Fixed doctests and improved documentation of _substitute() in secondquant.py

Looks good. Brian On Sat, Feb 20, 2010 at 3:11 PM, Øyvind Jensen jensen.oyv...@gmail.comwrote: --- sympy/physics/secondquant.py | 29 - 1 files changed, 20 insertions(+), 9 deletions(-) diff --git a/sympy/physics/secondquant.py b/sympy/physics/secondquant.py

Re: [PATCH 6/6] Make substitute_dummies() more flexible and controllable w.r.t. output

I would prefer if this would use the new assumptions system. Or should 'above_fermi' etc. be tied to symbols? The rest of the patches looks fine to me, assuming all tests pass. I agree with this. I agree, that we should move to the new assumption system, but that does require a major