Re: review of Chris' 1766

2010-03-11 Thread Aaron S. Meurer
I think that minor test failures are not too big of a deal for intermediate commits. It is important that isympy works in each intermediate commit, in case you need to bisect, and that there are no whitespace issues, because git complains about them while rebasing and if you have the

Re: review of Chris' 1766

2010-03-11 Thread Ondrej Certik
On Thu, Mar 11, 2010 at 9:56 AM, Aaron S. Meurer asmeu...@gmail.com wrote: I think that minor test failures are not too big of a deal for intermediate commits. It is important that isympy works in each intermediate commit, in case you need to bisect, and that there are no whitespace issues,