I think that minor test failures are not too big of a deal for
intermediate commits. It is important that isympy works in each
intermediate commit, in case you need to bisect, and that there are no
whitespace issues, because git complains about them while rebasing and
if you have the whitespace hook enabled, it will screw things up for
you, as you well know.
I would also fix any tests that infinite loop
Aaron Meurer
Sent from my iPod touch.
On Mar 11, 2010, at 9:09 AM, smichr <smi...@gmail.com> wrote:
OK, although *as a whole* all the work to date passes the tests,
individual commits amongst those of the 1766_s branch don't. It's
going to take some time to get each of the commits to pass.
Part of the problem is that I may make a commit A that passes tests,
but then after commits B, C, D something that should be done to A
arises. I move that commit back with A but it is actually (and unknown
to me at the time) blocked by something that is happening in B, C or
D. Perhaps it's better to just leave the commits as they fall, making
sure that at least one isn't going backwards in breaking previous
behavior. I'll post when there is progress on this.
--
You received this message because you are subscribed to the Google
Groups "sympy-patches" group.
To post to this group, send email to sympy-patc...@googlegroups.com.
To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com
.
For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en
.
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to this group, send email to sympy-patc...@googlegroups.com.
To unsubscribe from this group, send email to
sympy-patches+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sympy-patches?hl=en.
