Auditing sourcecode using pyflakes

2010-03-17 Thread Priit Laes
Hey, A while ago (last year sometime) I sent a review request about my pyflakes branch to the list, but I dont really recall the outcome but anyway - it wasn't included... So here's the proposal again: I have introduced an 'audit' target that checks sourcecode for various defects using Pyflakes

[PATCH 1/2] Implemented the Implies class to compile away in the same sense as Xor, Nand, etc. One of the tests led to misleading results ('Implies(False, False) == False' should not hold), and the te

2010-03-17 Thread Christian Muise
--- doc/src/modules/logic.txt |7 --- sympy/logic/boolalg.py| 12 +++- sympy/logic/tests/test_boolalg.py |6 -- 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/doc/src/modules/logic.txt b/doc/src/modules/logic.txt index 2487d57..e466d5a

[PATCH 2/2] Removing the option for passing in a list of pairs, since the outcome is ambiguous when two pairs are given as arguments.

2010-03-17 Thread Christian Muise
--- sympy/logic/boolalg.py |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/sympy/logic/boolalg.py b/sympy/logic/boolalg.py index 0a45e42..97c47b7 100755 --- a/sympy/logic/boolalg.py +++ b/sympy/logic/boolalg.py @@ -109,10 +109,8 @@ class Implies(BooleanFunction):

Re: Auditing sourcecode using pyflakes

2010-03-17 Thread Ondrej Certik
On Wed, Mar 17, 2010 at 6:11 AM, Priit Laes wrote: > Hey, > > A while ago (last year sometime) I sent a review request about my > pyflakes branch to the list, but I dont really recall the outcome but > anyway - it wasn't included... > > So here's the proposal again: > > I have introduced an 'audit

Re: Auditing sourcecode using pyflakes

2010-03-17 Thread Ondrej Certik
On Wed, Mar 17, 2010 at 9:35 AM, Ondrej Certik wrote: > On Wed, Mar 17, 2010 at 6:11 AM, Priit Laes wrote: >> Hey, >> >> A while ago (last year sometime) I sent a review request about my >> pyflakes branch to the list, but I dont really recall the outcome but >> anyway - it wasn't included... >>

Please review my 'unused-imports' branch

2010-03-17 Thread Priit Laes
Hey! Now that auditing support is in master, I went out there and picked some low-hanging fruit (unused imports) from the long list of issues reported by audit tool: 70 files changed, 87 insertions(+), 153 deletions(-) >From 545 warnings to 349 ;) Branch is here: http://github.com/plaes/sympy/c

Re: isympy - mention ipython?

2010-03-17 Thread Ondrej Certik
Hi Fernando, On Fri, Jan 1, 2010 at 12:47 PM, Fernando Perez wrote: > Hey Ondrej, > > I got that screenshot from David and noticed that isympy says > > (ipython-0.10)maqroll[~]> isympy > Python 2.6.4 console for SymPy 0.7.0-git > > It would be cool if you acknowledged that this is ipython-based,

Re: Please review my 'unused-imports' branch

2010-03-17 Thread Ondrej Certik
On Wed, Mar 17, 2010 at 2:13 PM, Priit Laes wrote: > Hey! > > Now that auditing support is in master, I went out there and picked some > low-hanging fruit (unused imports) from the long list of issues reported > by audit tool: > > 70 files changed, 87 insertions(+), 153 deletions(-) > > From 545 w

Re: isympy - mention ipython?

2010-03-17 Thread Aaron Meurer
Should we include the IPython version too? Otherwise, it looks fine. Aaron Meurer On Mar 17, 2010, at 4:24 PM, Ondrej Certik wrote: > Hi Fernando, > > On Fri, Jan 1, 2010 at 12:47 PM, Fernando Perez > wrote: >> Hey Ondrej, >> >> I got that screenshot from David and noticed that isympy says >>

Re: Please review my 'unused-imports' branch

2010-03-17 Thread Aaron Meurer
It does not rebase trivially over master, due to mpmath being updated. Aaron Meurer On Mar 17, 2010, at 4:27 PM, Ondrej Certik wrote: > On Wed, Mar 17, 2010 at 2:13 PM, Priit Laes wrote: >> Hey! >> >> Now that auditing support is in master, I went out there and picked some >> low-hanging frui

Re: Please review my 'unused-imports' branch

2010-03-17 Thread Mateusz Paprocki
Hi, On Wed, Mar 17, 2010 at 04:59:50PM -0600, Aaron Meurer wrote: > It does not rebase trivially over master, due to mpmath being updated. > New rebased branch is polys7. We currently testing it. > Aaron Meurer > On Mar 17, 2010, at 4:27 PM, Ondrej Certik wrote: > > > On Wed, Mar 17, 2010 at

Re: Please review my 'unused-imports' branch

2010-03-17 Thread Aaron Meurer
I was actually referring to Priit's branch, but I guess polys will need to fixed too. :) Aaron Meurer On Mar 17, 2010, at 5:10 PM, Mateusz Paprocki wrote: > Hi, > > On Wed, Mar 17, 2010 at 04:59:50PM -0600, Aaron Meurer wrote: >> It does not rebase trivially over master, due to mpmath being upd

Re: Please review my 'unused-imports' branch

2010-03-17 Thread Ondrej Certik
On Wed, Mar 17, 2010 at 5:21 PM, Aaron Meurer wrote: > I was actually referring to Priit's branch, but I guess polys will need to > fixed too. :) Polys are now rebased and pass all tests, but you need the patches from my polys7 branch at github. Those are hotfixes, so now we are looking with Mat

Re: Please review my 'unused-imports' branch

2010-03-17 Thread Priit Laes
Ühel kenal päeval, K, 2010-03-17 kell 17:51, kirjutas Ondrej Certik: > On Wed, Mar 17, 2010 at 5:21 PM, Aaron Meurer wrote: > > I was actually referring to Priit's branch, but I guess polys will need to > > fixed too. :) I pushed my rebased branch to http://github.com/plaes/sympy/tree/unused-im