issue 1356

2010-03-27 Thread Toon Verstraelen
Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 cheers, Toon -- You received this message because you are subscribed to the Google Groups sympy-patches group. To post to this group, send email to

Re: issue 1356

2010-03-27 Thread Priit Laes
Ühel kenal päeval, L, 2010-03-27 kell 07:41, kirjutas Toon Verstraelen: Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 IMHO, it would be more pythonic if it returns ValueError instead of TypeError when it encounters invalid

Re: issue 1356

2010-03-27 Thread Ondrej Certik
On Sat, Mar 27, 2010 at 12:16 AM, Priit Laes plaes...@gmail.com wrote: Ühel kenal päeval, L, 2010-03-27 kell 07:41, kirjutas Toon Verstraelen: Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 IMHO, it would be more pythonic if

Re: review of Chris' 1766

2010-03-27 Thread smichr
On Mar 26, 8:38 pm, Vinzent Steinberg vinzent.steinb...@googlemail.com wrote: I just tried to review the commits before the 'quartz' commit, I hope this is to be reviewed, if not, please create a new branch with only the commits to be reviewed. The 1766s and the 1766_s branch need to be

Re: issue 1356

2010-03-27 Thread Toon Verstraelen
Priit Laes wrote: Ühel kenal päeval, L, 2010-03-27 kell 07:41, kirjutas Toon Verstraelen: Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 IMHO, it would be more pythonic if it returns ValueError instead of TypeError when it

Re: issue 1356

2010-03-27 Thread Priit Laes
Ühel kenal päeval, L, 2010-03-27 kell 08:58, kirjutas Toon Verstraelen: Priit Laes wrote: IMHO, it would be more pythonic if it returns ValueError instead of TypeError when it encounters invalid kwarg. A TypeError is what python raises when wrong keyword arguments are given to a

Re: issue 1356

2010-03-27 Thread Toon Verstraelen
Ondrej Certik wrote: On Sat, Mar 27, 2010 at 12:16 AM, Priit Laes plaes...@gmail.com wrote: Ühel kenal päeval, L, 2010-03-27 kell 07:41, kirjutas Toon Verstraelen: Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 IMHO, it would

Re: review of Chris' 1766

2010-03-27 Thread Ondrej Certik
On Sat, Mar 27, 2010 at 12:54 AM, smichr smi...@gmail.com wrote: On Mar 26, 8:38 pm, Vinzent Steinberg vinzent.steinb...@googlemail.com wrote: I just tried to review the commits before the 'quartz' commit, I hope this is to be reviewed, if not, please create a new branch with only the

Branch for fixes to printer

2010-03-27 Thread Brian Granger
Hi, I have put up a branch that fixes two things in the printers: http://github.com/ellisonbg/sympy/tree/printer * lambdify(Piecewise) now uses iff for Python 2.4 compat. * I added printmethod = _pretty_ to the pretty printer class to allow types to declare how they can be pretty printed.