Re: Hilbert Space Review

2010-06-30 Thread Øyvind Jensen
I get some failing tests: __ /home/oy/git_workingdir/sympy/sympy/physics/tests/ test_hilbert.py ___ File /home/oy/git_workingdir/sympy/sympy/physics/tests/ test_hilbert.py, line 1, in module from

Re: Hilbert Space Review

2010-06-30 Thread Øyvind Jensen
  File /home/oy/git_workingdir/sympy/sympy/physics/hilbert.py, line 267     obj = Expr.__new__(cls, *args, commutative=False)                                              ^ SyntaxError: invalid syntax The syntax error is because I have python 2.5 installed. The following line is compatible

Re: Hilbert Space Review

2010-06-30 Thread Matt Curry
Okay, I've fixed up a few more things you've mentioned and pushed it to github. 1) I removed all of the subs lines. I realized they didn't need to be overwritten! 2) Whatever can live in a Hilbert space will have a .hilbert_space attribute that can be compared when necessary. I'll get back to

Re: Hilbert Space Review

2010-06-30 Thread Øyvind Jensen
on., 30.06.2010 kl. 12.05 -0700, skrev Matt Curry: Okay, I've fixed up a few more things you've mentioned and pushed it to github. Cool. I just finished commenting on github http://github.com/mattcurry/sympy/commit/8e63d9d62bca475bcd6e6ee711e166cb6fbe In general it looks very good: It's