on., 30.06.2010 kl. 12.05 -0700, skrev Matt Curry: > Okay, I've fixed up a few more things you've mentioned and pushed it > to github.
Cool. I just finished commenting on github http://github.com/mattcurry/sympy/commit/8e63d9d62bcadddd475bcd6e6ee711e166cb6fbe In general it looks very good: It's well documented, the coding style follows the standard and the tests are extensive. The comments I made are mainly suggestions that may or may not be valid. > 2) Whatever can live in a Hilbert space will have a .hilbert_space > attribute that can be compared when necessary. I noticed the __contains__ method. Very nice! Cheers, Øyvind -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.