Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-04 Thread sympy
Comment #4 on issue 2133 by mattpap: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 The ratint() example works when you apply doit() to the result: In [2]: from sympy.integrals.rationaltools import * In [3]: ratint(1/(x**2 + 1), x, real=False)

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-04 Thread sympy
Comment #5 on issue 2133 by mattpap: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I don't know how to run cythonized tests. Issue `make` in the main directory of sympy and it will compile selected modules in-place. Then run tests as usual

Re: Issue 2132 in sympy: Derivative of RootSum

2011-01-04 Thread sympy
Comment #24 on issue 2132 by mattpap: Derivative of RootSum http://code.google.com/p/sympy/issues/detail?id=2132 So, SymPy doesn't know that RootSum is commutative. Now it knows. Also RootOf is now commutative. -- You received this message because you are subscribed to the Google Groups "sy

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-04 Thread sympy
Comment #6 on issue 2133 by mattpap: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 I fixed test runner to work with Python 2.4, so now all tests in sympy.polys can be run in 2.4 and all pass. -- You received this message because you are sub

Re: Issue 51 in sympy: RootOf for polynomial equations

2011-01-04 Thread sympy
Comment #27 on issue 51 by mattpap: RootOf for polynomial equations http://code.google.com/p/sympy/issues/detail?id=51 Regarding #25, I slightly improved RooOf's API, so now we have: 1. Just a single root: In [1]: RootOf(x**3 + x + 1, 0) Out[1]: ⎛ 3 ⎞ RootOf⎝x + x + 1, 0⎠ 2.

Re: Issue 1386 in sympy: data/IPython/ipythonrc-sympy doesn't seem to work:

2011-01-04 Thread sympy
Updates: Status: Started Labels: NeedsReview Comment #4 on issue 1386 by mattpap: data/IPython/ipythonrc-sympy doesn't seem to work: http://code.google.com/p/sympy/issues/detail?id=1386 A fix for this issue is available from https://github.com/mattpap/sympy-polys/commits/rel

Re: Issue 1989 in sympy: Remove depricated Matrix functions

2011-01-04 Thread sympy
Comment #5 on issue 1989 by mattpap: Remove depricated Matrix functions http://code.google.com/p/sympy/issues/detail?id=1989 It was deprecated long enough, +1 for merging this patch before 0.7.0 release. -- You received this message because you are subscribed to the Google Groups "sympy-pat

Re: Issue 527 in sympy: guessing what functions, like integrate, roots, factor, apart (and many more), should do with the given expression

2011-01-04 Thread sympy
Updates: Labels: NeedsReview Comment #8 on issue 527 by mattpap: guessing what functions, like integrate, roots, factor, apart (and many more), should do with the given expression http://code.google.com/p/sympy/issues/detail?id=527 In commits 27f8bc6eef07da622590140c253444267b6797f3

Re: Issue 1432 in sympy: simplify gets hung up on this expression

2011-01-04 Thread sympy
Updates: Labels: -EasyToFix NeedsReview Comment #5 on issue 1432 by mattpap: simplify gets hung up on this expression http://code.google.com/p/sympy/issues/detail?id=1432 Actually there is a test for this, see lines 158-160 in sympy/simplify/test_simplify.py in polys12. -- You rec

Re: Issue 1646 in sympy: Solving inequalities

2011-01-04 Thread sympy
Comment #35 on issue 1646 by mattpap: Solving inequalities http://code.google.com/p/sympy/issues/detail?id=1646 Regarding #33, this misleading error message was improved in d2a9918f15ec2fb3fc05eae435901388133c744d in polys12 branch. -- You received this message because you are subscribed to

Re: Issue 2084 in sympy: limit(1+1/x, x, 0, dir='-') fails

2011-01-04 Thread sympy
Comment #44 on issue 2084 by ronan.l...@gmail.com: limit(1+1/x, x, 0, dir='-') fails http://code.google.com/p/sympy/issues/detail?id=2084 I'd push this in if I understood which of the 3 pull requests named "2084" is/are the right one(s). Chris, can you sort out the confusion between https

Re: Issue 2084 in sympy: limit(1+1/x, x, 0, dir='-') fails

2011-01-04 Thread sympy
Comment #45 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-') fails http://code.google.com/p/sympy/issues/detail?id=2084 Commit bae66169 is the correct one, so pull requests 22 and 29 are both right. Pull request 43 should be removed however (corresponding commits b7264f6

Re: Issue 1923 in sympy: count_ops doesn't return a count (by default)

2011-01-04 Thread sympy
Comment #32 on issue 1923 by candleband: count_ops doesn't return a count (by default) http://code.google.com/p/sympy/issues/detail?id=1923 Nocolas, can you figure out how to modify 1923 so that And(x, y) gives back a count of 1 (like it did in master) instead of 2. In master (AFAICT) it

Re: Issue 2084 in sympy: limit(1+1/x, x, 0, dir='-') fails

2011-01-04 Thread sympy
Comment #46 on issue 2084 by candleband: limit(1+1/x, x, 0, dir='-') fails http://code.google.com/p/sympy/issues/detail?id=2084 I closed all 3, and opened a new request (61) that shows the correct single commit over the current master. -- You received this message because you are subscribed

[GitHub] 2084 limit considers direction for Add [sympy/sympy GH-61]

2011-01-04 Thread GitHub
smichr wants someone to pull from smichr:2084: I don't know why any of the 3 previous pull requests didn't become updated when I repushed the current version that I have so I rebased on master, closed all previous requests and opened this new request. (One thing I did notice, however, is that o

Re: Issue 1923 in sympy: count_ops doesn't return a count (by default)

2011-01-04 Thread sympy
Comment #33 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a count (by default) http://code.google.com/p/sympy/issues/detail?id=1923 Sorry, I don't understand what you mean. Add(x, y).count_ops() still returns 1: $ git checkout smichr/1923 $ ./bin/isympy In [1]: Add(x,y).co

Re: Issue 1923 in sympy: count_ops doesn't return a count (by default)

2011-01-04 Thread sympy
Updates: Cc: Ronan.Lamy Comment #34 on issue 1923 by smichr: count_ops doesn't return a count (by default) http://code.google.com/p/sympy/issues/detail?id=1923 I am really having a bad day with sessions...yes, I (now) get the same result. Should count_ops() have these lines:

Re: Issue 1337 in sympy: find all instances in an expression

2011-01-04 Thread sympy
Comment #20 on issue 1337 by smichr: find all instances in an expression http://code.google.com/p/sympy/issues/detail?id=1337 While normal atoms can do some of what find does, f.atoms(tan) set([tan(1), tan(x**2), tan(tan(1 - x)), tan(1 - x)]) It can't find more general patterns so this looks

Re: Issue 2126 in sympy: fix doctest or quality testing to recognize doctests

2011-01-04 Thread sympy
Comment #5 on issue 2126 by smichr: fix doctest or quality testing to recognize doctests http://code.google.com/p/sympy/issues/detail?id=2126 Issue 2035 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To po

Re: Issue 1757 in sympy: coding style

2011-01-04 Thread sympy
Comment #34 on issue 1757 by smichr: coding style http://code.google.com/p/sympy/issues/detail?id=1757 Here are some other issues that have come up and can be discussed: 1) always name the first argument of a method "self" 2) don't modify self in a method. -- You received this message because

Re: Issue 1757 in sympy: coding style

2011-01-04 Thread sympy
Comment #35 on issue 1757 by mattpap: coding style http://code.google.com/p/sympy/issues/detail?id=1757 I disagree with 1) because in many cases it's more natural to not use self. Even in Python's standard library self is not always used as the first argument, e.g. in Fraction class from fra

Re: Issue 1949 in sympy: Doctests for polynomials module

2011-01-04 Thread sympy
Comment #14 on issue 1949 by asmeurer: Doctests for polynomials module http://code.google.com/p/sympy/issues/detail?id=1949 Concerning comments 7, 9, and 10, I tried building the docs in polys12 using Sphinx 1.0.5, and perhaps it is a new feature, but I the docs still built despite all the "

Re: Issue 1949 in sympy: Doctests for polynomials module

2011-01-04 Thread sympy
Comment #15 on issue 1949 by mattpap: Doctests for polynomials module http://code.google.com/p/sympy/issues/detail?id=1949 I didn't work on documentation yet, so let me look into this tomorrow. -- You received this message because you are subscribed to the Google Groups "sympy-patches" group.

Re: Issue 2135 in sympy: Drop support for Python 2.4

2011-01-04 Thread sympy
Issue 2135: Drop support for Python 2.4 http://code.google.com/p/sympy/issues/detail?id=2135 This issue is now blocking issue 1998. See http://code.google.com/p/sympy/issues/detail?id=1998 -- You received this message because you are listed in the owner or CC fields of this issue, or because you

Re: Issue 2135 in sympy: Drop support for Python 2.4

2011-01-04 Thread sympy
Comment #2 on issue 2135 by mattpap: Drop support for Python 2.4 http://code.google.com/p/sympy/issues/detail?id=2135 This way we will be also able to use things like collections.Callable instead of callable() to move towards Python 3. -- You received this message because you are subscribed

Re: Issue 1985 in sympy: as_real_imag() gives wrong answer when expanding quotient

2011-01-04 Thread sympy
Comment #21 on issue 1985 by asmeurer: as_real_imag() gives wrong answer when expanding quotient http://code.google.com/p/sympy/issues/detail?id=1985 Issue 2067 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "sympy-patches" grou

Re: Issue 1923 in sympy: count_ops doesn't return a count (by default)

2011-01-04 Thread sympy
Comment #35 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a count (by default) http://code.google.com/p/sympy/issues/detail?id=1923 Well, I personally don't mind. Concerning style, however, I would write it as following : elif isinstance(expr, Expr): return expr.c

Re: Issue 1757 in sympy: coding style

2011-01-04 Thread sympy
Comment #36 on issue 1757 by asmeurer: coding style http://code.google.com/p/sympy/issues/detail?id=1757 What do you mean "don't modify self in a method"? And by the way, the first argument of class methods should be "cls", not "self". -- You received this message because you are subscribed

Re: Issue 2135 in sympy: Drop support for Python 2.4

2011-01-04 Thread sympy
Comment #3 on issue 2135 by asmeurer: Drop support for Python 2.4 http://code.google.com/p/sympy/issues/detail?id=2135 I actually made a list of things we can do once we drop Python 2.4 in that second mailing list link above. This wasn't one of the items, though. Personally, I can't wait to

Re: Issue 2135 in sympy: Drop support for Python 2.4

2011-01-04 Thread sympy
Comment #4 on issue 2135 by mattpap: Drop support for Python 2.4 http://code.google.com/p/sympy/issues/detail?id=2135 Imagine wrapping the options manager around a with statement. See sympy/polys/polycontext.py ;) (__enter__ and __exit__ currently raise NotImplemented error, but it's not a

[GitHub] Update Mpmath to 0.16 [sympy/sympy GH-62]

2011-01-04 Thread GitHub
asmeurer wants someone to pull from asmeurer:mpmath-0.16: This updates mpmath to 0.16. There is currently a problem with the Sphinx docs where a bunch of plots to not get built correctly. Do `cd doc; make html` and open, for example, `_build/html/modules/mpmath/functions/bessel.html` to see t

Re: Issue 1757 in sympy: coding style

2011-01-04 Thread sympy
Comment #37 on issue 1757 by ronan.l...@gmail.com: coding style http://code.google.com/p/sympy/issues/detail?id=1757 What do you mean "don't modify self in a method"? More precisely, it's "don't rebind the first argument of a method (usually 'self' or 'cls') inside the method". It means th

[GitHub] Fix doctests to run in Python 2.6.6 and Python 2.7.1 [sympy/sympy GH-63]

2011-01-04 Thread GitHub
asmeurer wants someone to pull from asmeurer:doctest: This fixes the ubiquitous [issue 2041](http://code.google.com/p/sympy/issues/id=2041#makechanges) doctest problem by further patching our doctest runner from the Python 2.7 doctest.py file. View Pull Request: https://github.com/sympy/sympy/

Re: Issue 2041 in sympy: Doctest failures in Python 2.6.6

2011-01-04 Thread sympy
Updates: Labels: NeedsReview asmeurer Comment #23 on issue 2041 by asmeurer: Doctest failures in Python 2.6.6 http://code.google.com/p/sympy/issues/detail?id=2041 This was not too hard to fix. I basically had to do what I said in comment 11: I took the code that was changed in that Py

Re: Issue 1757 in sympy: coding style

2011-01-04 Thread sympy
Comment #38 on issue 1757 by asmeurer: coding style http://code.google.com/p/sympy/issues/detail?id=1757 I see. Yes, that is probably a bad idea, because then you lose access to self. But does it really happen so often that we need to test for it? I have never seen anything like that befo

Re: Issue 1757 in sympy: coding style

2011-01-04 Thread sympy
Comment #39 on issue 1757 by smichr: coding style http://code.google.com/p/sympy/issues/detail?id=1757 grep for "self = " and you'll find some places where it happens in current sympy. I would do it when I intend to modify self and return a new value. A trivial example, but in the spirit o

[GitHub] 2137: Fix a bug in as_real_imag() [sympy/sympy GH-64]

2011-01-04 Thread GitHub
asmeurer wants someone to pull from asmeurer:2137: See the issue page. The bug was with `(cos(1+I)**3).as_real_imag()`. View Pull Request: https://github.com/sympy/sympy/pull/64 -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this

Re: Issue 2137 in sympy: as_real_imag is broken for cos(1+I)**3

2011-01-04 Thread sympy
Updates: Labels: WrongResult EasyToFix NeedsReview asmeurer Comment #1 on issue 2137 by asmeurer: as_real_imag is broken for cos(1+I)**3 http://code.google.com/p/sympy/issues/detail?id=2137 I knew that people should have reviewed that part of the code better before it was pushed in!

Re: Issue 1989 in sympy: Remove depricated Matrix functions

2011-01-04 Thread sympy
Comment #6 on issue 1989 by asmeurer: Remove depricated Matrix functions http://code.google.com/p/sympy/issues/detail?id=1989 Go ahead and cherry-pick the commits from integration3 that you are +1 on into release0.7.0 or polys12, and they will go in with that (if you cherry-pick, I will assu

Re: Issue 1757 in sympy: coding style

2011-01-04 Thread sympy
Comment #40 on issue 1757 by asmeurer: coding style http://code.google.com/p/sympy/issues/detail?id=1757 Yeah, self is nothing special in Python; it's just a conventional name for the first argument of methods that is automatically given as object in object.method(…). It's not like by doing

Re: Issue 2133 in sympy: Merge new polynomials manipulation module

2011-01-04 Thread sympy
Comment #7 on issue 2133 by asmeurer: Merge new polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=2133 Regarding the intervals thing, if I apply the patch: diff --git a/sympy/polys/tests/test_polytools.py b/sympy/polys/tests/test_polytools.py index 61e0576..0

Re: Issue 2132 in sympy: Derivative of RootSum

2011-01-04 Thread sympy
Updates: Labels: -NeedsReview NeedsBetterPatch Comment #25 on issue 2132 by asmeurer: Derivative of RootSum http://code.google.com/p/sympy/issues/detail?id=2132 Now cancel(a.diff(x)) does not cause a traceback, but it doesn't auto-simplify either. Calling doit() gives this: In [4]:

Re: Issue 2132 in sympy: Derivative of RootSum

2011-01-04 Thread sympy
Comment #26 on issue 2132 by asmeurer: Derivative of RootSum http://code.google.com/p/sympy/issues/detail?id=2132 I think the problem, or at least part of the problem, is that it is trying to expand the RootSum into a sum or RootOfs instead of simplifying the rational function Lambda, which

[GitHub] 2018 as_coeff_ (terms/factors) now (mul/add) [sympy/sympy GH-65]

2011-01-04 Thread GitHub
smichr wants someone to pull from smichr:2018: I'm not sure how to decorate with @deprecated (I was unable to successfully import this from utilities) so I raised a NotImplementedError with instructions on what to use instead. All tests and doctests still pass. View Pull Request: https://githu

Re: Issue 2018 in sympy: terms vs factors

2011-01-04 Thread sympy
Updates: Labels: NeedsReview Comment #8 on issue 2018 by smichr: terms vs factors http://code.google.com/p/sympy/issues/detail?id=2018 https://github.com/sympy/sympy/pull/65 I just renamed as_coeff_terms to as_coeff_mul and as_coeff_factors to as_coeff_add and in a few places changed