quantum review

2011-03-24 Thread smichr
Can someone (Brian?) review the [ https://github.com/sympy/sympy/pull/125 ] and [ https://github.com/sympy/sympy/pull/128 ]? These have had no comments in 2 weeks. I'm happy to commit them but am not the best one to review them. -- You received this message because you are subscribed to the Googl

Re: Issue 1923 in sympy: count_ops doesn't return a count (by default)

2011-03-24 Thread sympy
Updates: Status: Fixed Comment #40 on issue 1923 by smi...@gmail.com: count_ops doesn't return a count (by default) http://code.google.com/p/sympy/issues/detail?id=1923 This is in. -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To

Re: Issue 2186 in sympy: X, Y, Z gates should be hermitian as well as unitary

2011-03-24 Thread sympy
Updates: Labels: lazovich NeedsReview Comment #4 on issue 2186 by asmeurer: X, Y, Z gates should be hermitian as well as unitary http://code.google.com/p/sympy/issues/detail?id=2186 (No comment was entered for this change.) -- You received this message because you are subscribed to t

Re: Issue 2225 in sympy: Enhancing Matrix Norm

2011-03-24 Thread sympy
Comment #31 on issue 2225 by mrock...@gmail.com: Enhancing Matrix Norm http://code.google.com/p/sympy/issues/detail?id=2225 OK, given what has been said on the comments I'm going to shift the default behavior of my branch back to Frobenius. Given the simplicity of computing the Frobenius mat

Re: Issue 1980 in sympy: has, has_any_symbols, has_all_symbols unified

2011-03-24 Thread sympy
Updates: Status: Fixed Comment #11 on issue 1980 by smi...@gmail.com: has, has_any_symbols, has_all_symbols unified http://code.google.com/p/sympy/issues/detail?id=1980 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Gro

Re: Issue 2225 in sympy: Enhancing Matrix Norm

2011-03-24 Thread sympy
Comment #30 on issue 2225 by pr...@goodok.ru: Enhancing Matrix Norm http://code.google.com/p/sympy/issues/detail?id=2225 A detected the old issue 821 about max's improving, remarking that now name-token is `Max` for this function in core since far. And this function is placed in: sympy/fun

Re: Issue 2225 in sympy: Enhancing Matrix Norm

2011-03-24 Thread sympy
Comment #29 on issue 2225 by pr...@goodok.ru: Enhancing Matrix Norm http://code.google.com/p/sympy/issues/detail?id=2225 Thanks, Vinzent, for me I do not know exactly speciality for all kinds of norms. -- You received this message because you are subscribed to the Google Groups "sympy-patch

Re: Issue 2225 in sympy: Enhancing Matrix Norm

2011-03-24 Thread sympy
Comment #28 on issue 2225 by pr...@goodok.ru: Enhancing Matrix Norm http://code.google.com/p/sympy/issues/detail?id=2225 About `Max()` function improving, yes, I pro. But my opinion is that it is separated (but little) issue though. About `Norm(matrix)` object and `norm(matrix)` function: it is

Re: Issue 2225 in sympy: Enhancing Matrix Norm

2011-03-24 Thread sympy
Comment #27 on issue 2225 by Vinzent.Steinberg: Enhancing Matrix Norm http://code.google.com/p/sympy/issues/detail?id=2225 After looking at the Wikipedia article I agree that Frobenius is a sane default. It is not really an approximation of the 2-norm, sorry for the confusion. The nice thi

Re: Issue 2225 in sympy: Enhancing Matrix Norm

2011-03-24 Thread sympy
Comment #26 on issue 2225 by pr...@goodok.ru: Enhancing Matrix Norm http://code.google.com/p/sympy/issues/detail?id=2225 With a view to do not hung this issue, but remarking that I have not observed logical grounds for consideration the Frobenius as "imitation", remarking that it is simple n

Re: Issue 511 in sympy: Plot has no docstring

2011-03-24 Thread sympy
Updates: Status: Fixed Labels: -NeedsReview PassedReview Comment #4 on issue 511 by ronan.l...@gmail.com: Plot has no docstring http://code.google.com/p/sympy/issues/detail?id=511 (No comment was entered for this change.) -- You received this message because you are subscribed t

Re: Issue 2220 in sympy: Bug with Matrix.is_symbolic and Matrix.is_upper

2011-03-24 Thread sympy
Updates: Labels: sean.v.775 NeedsReview Comment #2 on issue 2220 by asmeurer: Bug with Matrix.is_symbolic and Matrix.is_upper http://code.google.com/p/sympy/issues/detail?id=2220 (No comment was entered for this change.) -- You received this message because you are subscribed to the

Re: Issue 2225 in sympy: Enhancing Matrix Norm

2011-03-24 Thread sympy
Comment #25 on issue 2225 by asmeurer: Enhancing Matrix Norm http://code.google.com/p/sympy/issues/detail?id=2225 I think Norm(matrix) is suggested to be an object, which is unevaluated by default. Usually stuff evaluates by default, if it can. If it can't do it, or if you explicitly call

Re: Issue 1360 in sympy: "integrate" doesn't allow the use of functions as the variable of integration.

2011-03-24 Thread sympy
Updates: Labels: NeedsReview hector1618 Comment #6 on issue 1360 by asmeurer: "integrate" doesn't allow the use of functions as the variable of integration. http://code.google.com/p/sympy/issues/detail?id=1360 (No comment was entered for this change.) -- You received this message bec

Re: Issue 2225 in sympy: Enhancing Matrix Norm

2011-03-24 Thread sympy
Comment #24 on issue 2225 by mrock...@gmail.com: Enhancing Matrix Norm http://code.google.com/p/sympy/issues/detail?id=2225 Regarding Frobenius vs Spectral/2-norm Mathematically the spectral/2-norm is "the" standard norm just like the euclidian/2-norm is standard for vectors. Vector norms hav

Re: Issue 2225 in sympy: Enhancing Matrix Norm

2011-03-24 Thread sympy
Comment #23 on issue 2225 by Vinzent.Steinberg: Enhancing Matrix Norm http://code.google.com/p/sympy/issues/detail?id=2225 The Frobenius is norm is a (numerically motivated) approximation of the hard to calculate 2-norm. So I'm not sure if it makes sense as a symbolical default. I think we

Re: Issue 2225 in sympy: Enhancing Matrix Norm

2011-03-24 Thread sympy
Comment #22 on issue 2225 by pr...@goodok.ru: Enhancing Matrix Norm http://code.google.com/p/sympy/issues/detail?id=2225 And about `Norm(matrix)`, sorry, I have thought more. And, yes, `Norm(matrix)` might be considered as operator, but I suppose that it is not the question for this issue ri