Re: Issue 2385 in sympy: Refactor Basic.sorted_key

2011-05-19 Thread sympy
Updates: Labels: -Milestone-Release0.7.1 Milestone-Release0.7.0 Comment #5 on issue 2385 by asmeurer: Refactor Basic.sorted_key http://code.google.com/p/sympy/issues/detail?id=2385 So is it correct that your pull fixes the first four items (i.e., everything except replacing the old

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #13 on issue 2308 by smi...@gmail.com: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 Would 'kernel' be any better? The choicest or most essential or most vital part of some idea or experience --

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #14 on issue 2308 by asmeurer: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 If we were the mathematicians making up the names, that would be fine, but unfortunately, that has already happened.

Re: Issue 2307 in sympy: Duplicate methods: as_coeff_mul and as_coeff_Mul

2011-05-19 Thread sympy
Comment #20 on issue 2307 by smi...@gmail.com: Duplicate methods: as_coeff_mul and as_coeff_Mul http://code.google.com/p/sympy/issues/detail?id=2307 as_coeff_mul could be .rat_mulargs and as_coeff_add could be .rat_addargs. This would make it clear that you are getting a Rational, not slot

Re: Issue 1592 in sympy: Pretty print Sum with a Sigma

2011-05-19 Thread sympy
Updates: Status: Fixed Comment #10 on issue 1592 by smi...@gmail.com: Pretty print Sum with a Sigma http://code.google.com/p/sympy/issues/detail?id=1592 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups sympy-patches

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #16 on issue 2308 by smi...@gmail.com: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 ...oops, rat_gcd can't take the place of as_coeff_Mul, but as_coeff_Mul could first call rat_gcd to get any

Issue 2396 in sympy: RegularPolygon rotate is only spinning the RP, not rotating it.

2011-05-19 Thread sympy
Status: Accepted Owner: smi...@gmail.com Labels: Type-Defect Priority-Medium NeedsReview smichr New issue 2396 by smi...@gmail.com: RegularPolygon rotate is only spinning the RP, not rotating it. http://code.google.com/p/sympy/issues/detail?id=2396 see [

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #17 on issue 2308 by Vinzent.Steinberg: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 Well, if we have a clear docstring, I think primitive is fine. There are contradictory definitions of words, so

Re: Issue 1525 in sympy: No integration by substitution

2011-05-19 Thread sympy
Comment #20 on issue 1525 by smi...@gmail.com: No integration by substitution http://code.google.com/p/sympy/issues/detail?id=1525 I wonder if f(g(x)).diff(g(x)) could be stored as D(f(u), u, {u:g(x)}) and the subs method of Derivative would look for a substitution {u;g(x)} that could be

Re: Issue 2283 in sympy: Non-iterative 'in'

2011-05-19 Thread sympy
Comment #14 on issue 2283 by smi...@gmail.com: Non-iterative 'in' http://code.google.com/p/sympy/issues/detail?id=2283 Regarding comment 6, args_cnc splits the args up for you. from sympy.abc import * from sympy import * var('n,m', commutative=False) (n, m)

Issue 2398 in sympy: remove msolve after 2 years of warning

2011-05-19 Thread sympy
Status: Accepted Owner: smi...@gmail.com Labels: Type-Defect Priority-Medium NeedsReview smichr New issue 2398 by smi...@gmail.com: remove msolve after 2 years of warning http://code.google.com/p/sympy/issues/detail?id=2398 https://github.com/sympy/sympy/pull/333 -- You received this message

Issue 2399 in sympy: use free_symbols in Integral.transform

2011-05-19 Thread sympy
Status: Accepted Owner: smi...@gmail.com Labels: Type-Defect Priority-Medium NeedsReview smichr New issue 2399 by smi...@gmail.com: use free_symbols in Integral.transform http://code.google.com/p/sympy/issues/detail?id=2399 To be safe the test for x in the solution obtained in the transform

Re: Issue 2399 in sympy: use free_symbols in Integral.transform

2011-05-19 Thread sympy
Comment #1 on issue 2399 by smi...@gmail.com: use free_symbols in Integral.transform http://code.google.com/p/sympy/issues/detail?id=2399 https://github.com/sympy/sympy/pull/334 -- You received this message because you are subscribed to the Google Groups sympy-patches group. To post to

Re: Issue 2398 in sympy: remove msolve after 2 years of warning

2011-05-19 Thread sympy
Updates: Status: Fixed Labels: -NeedsReview PassedReview Comment #1 on issue 2398 by Vinzent.Steinberg: remove msolve after 2 years of warning http://code.google.com/p/sympy/issues/detail?id=2398 Sorry, I thought this was already in. Thanks! -- You received this message

Re: Issue 2308 in sympy: Should we rename primitive()? (and Expr.primitive() should call primitive())

2011-05-19 Thread sympy
Comment #18 on issue 2308 by asmeurer: Should we rename primitive()? (and Expr.primitive() should call primitive()) http://code.google.com/p/sympy/issues/detail?id=2308 Well, Chris inadvertently brought up a good point. (2*x/3 + 4*y/9).primitive() = (2/9, 2*y + 3*x) is wrong. It should

Issue 2400 in sympy: use deep in simplify's together call

2011-05-19 Thread sympy
Status: Accepted Owner: smi...@gmail.com Labels: Type-Defect Priority-Medium smichr NeedsReview New issue 2400 by smi...@gmail.com: use deep in simplify's together call http://code.google.com/p/sympy/issues/detail?id=2400 see discussion at https://github.com/sympy/sympy/pull/335 -- You

Re: Issue 1525 in sympy: No integration by substitution

2011-05-19 Thread sympy
Comment #21 on issue 1525 by asmeurer: No integration by substitution http://code.google.com/p/sympy/issues/detail?id=1525 I'd rather not have workarounds. We should just fix issue 1620. Derivative(f(x), g(x)) is wrong anyway. -- You received this message because you are subscribed to the

Re: Issue 2283 in sympy: Non-iterative 'in'

2011-05-19 Thread sympy
Comment #15 on issue 2283 by asmeurer: Non-iterative 'in' http://code.google.com/p/sympy/issues/detail?id=2283 If you want to know where in is used, just comment out Basic.__contains__ and run the tests. -- You received this message because you are subscribed to the Google Groups

Re: Issue 2203 in sympy: doctest does not test IPython interactive sessions

2011-05-19 Thread sympy
Updates: Status: Fixed Comment #11 on issue 2203 by asmeurer: doctest does not test IPython interactive sessions http://code.google.com/p/sympy/issues/detail?id=2203 This was pushed in. -- You received this message because you are subscribed to the Google Groups sympy-patches

Re: Issue 1525 in sympy: No integration by substitution

2011-05-19 Thread sympy
Updates: Labels: NeedsReview Comment #26 on issue 1525 by smi...@gmail.com: No integration by substitution http://code.google.com/p/sympy/issues/detail?id=1525 https://github.com/sympy/sympy/pull/336; I just wrote factorial(x) as gamma(x + 1) in the test and changed the other test

Re: Issue 2386 in sympy: gosper(...) is missing tests and docstring

2011-05-19 Thread sympy
Updates: Labels: NeedsReview asmeurer Blockedon: 1620 Comment #13 on issue 2386 by asmeurer: gosper(...) is missing tests and docstring http://code.google.com/p/sympy/issues/detail?id=2386 See https://github.com/sympy/sympy/pull/337 for the NotImplementedError. -- You

Re: Issue 1827 in sympy: log eval gives more standard form

2011-05-19 Thread sympy
Updates: Labels: -NeedsBetterPatch NeedsReview smichr Comment #17 on issue 1827 by smi...@gmail.com: log eval gives more standard form http://code.google.com/p/sympy/issues/detail?id=1827 ok, log args are made square free of small factors with the additional commit at

Re: Issue 1827 in sympy: log eval gives more standard form

2011-05-19 Thread sympy
Comment #18 on issue 1827 by asmeurer: log eval gives more standard form http://code.google.com/p/sympy/issues/detail?id=1827 A few second sounds kind of long. How large is your factor limit? -- You received this message because you are subscribed to the Google Groups sympy-patches group. To