Re: C code generator and much improved contraction logic

On 07/26/2010 10:36 PM, Ųyvind Jensen wrote: I have uploaded my work on the C code printer, C code generator and the tensor module to smartbear for review: http://hosted.smartbear.com/sympy/go?page=ReviewDisplayreviewid=6 The ability to create code that loops over array arguments is much

Re: C code generator and much improved contraction logic

On 07/26/2010 10:36 PM, Ųyvind Jensen wrote: The code is also on github: http://github.com/jegerjensen/sympy/tree/codegen_C2 I have two failing tests on my system. __

fortran code generator reviewing

Hi, I've been looking into the fcode and codegen implementation. Sorry for the delay. First of all: I'm really happy with the work being done. I wish I could dedicate more time to the reviewing. I have a few small patches, but consider them as suggestions. (See attachments.)

Re: Issue 1411 Patch

On 04/15/2010 07:57 AM, Matt Curry wrote: Yea, I'll attach the patch in this email (in both zipped and non-zipped versions). I've just reviewed it. The patch is good and the tests run fine. It is pushed in. Thanks. Toon -- You received this message because you are subscribed to the Google

Re: Issue 1411 Patch

Hi Matt, Thanks for the patch. Could you send patches as attachments? Line wrapping messes up the patches. It is even better to compress them with gzip to prevent mail clients from messing things up. cheers, Toon On 04/15/2010 07:03 AM, Matt Curry wrote: Hello everyone, this is my first

issue 1356

Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 cheers, Toon -- You received this message because you are subscribed to the Google Groups sympy-patches group. To post to this group, send email to

Re: issue 1356

Priit Laes wrote: Ühel kenal päeval, L, 2010-03-27 kell 07:41, kirjutas Toon Verstraelen: Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 IMHO, it would be more pythonic if it returns ValueError instead of TypeError when

Re: issue 1356

Ondrej Certik wrote: On Sat, Mar 27, 2010 at 12:16 AM, Priit Laes plaes...@gmail.com wrote: Ühel kenal päeval, L, 2010-03-27 kell 07:41, kirjutas Toon Verstraelen: Hello, Could someone please review the patches of issue1356? http://code.google.com/p/sympy/issues/detail?id=1356 IMHO, it would

Re: new patches

Ondrej Certik wrote: On Wed, Mar 24, 2010 at 4:22 PM, Aaron S. Meurer asmeu...@gmail.com wrote: I am testing your branch now. I also left some comments on your github. Does the test_sage patch require sage to test? If it does, I won't be able to review that one, as I don't have sage

Re: [PATCH] initial fcode implementation

On Fri, Mar 19, 2010 at 12:58 PM, Toon Verstraelen toon.verstrae...@ugent.be wrote: Thanks alot! Vinzent Steinberg wrote: The patch looks fine to me, however I'm not familiar with fortran. But no one objected so far, so I pushed it in, thanks. Vinzent 2010/2/24 Toon Verstraelen toon.verstrae

Re: [PATCH] initial fcode implementation

Ondrej Certik wrote: On Thu, Mar 25, 2010 at 12:13 AM, Toon Verstraelen toon.verstrae...@ugent.be wrote: Right now only f77. f95 is one of the future options I'm thinkng of. Feel free to open a ticket, but I won't forget it anyway. It is mainly a matter of proper line wrapping. Yes. f77

Re: Fixed all but one audit warnings in printing

Ondrej Certik wrote: On Fri, Mar 19, 2010 at 11:36 PM, Toon Verstraelen toon.verstrae...@ugent.be wrote: Hi, There is one warning remaining about a method in the pretty printing code that does not seem to be used anymore. I'm not sure how to handle it. The rest was trivial to fix. The patch

Fixed all but one audit warnings in printing

. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en. From f743e4dd491b0b58de71241adf129e7f4ae6d7d1 Mon Sep 17 00:00:00 2001 From: Toon Verstraelen toon.verstrae...@ugent.be Date

Re: fix atan2() in sage

Ondrej Certik wrote: On Fri, Mar 19, 2010 at 7:01 PM, Ondrej Certik ond...@certik.cz wrote: Hi, please review my 2 patches in pu branch at github: * ee232d5 (HEAD, github/pu, pu) atan2(y, x) can now be converted to/from Sage * 17806ba test_sage: Use S() instead of sympify() please review

Re: [PATCH] initial fcode implementation

Thanks alot! Vinzent Steinberg wrote: The patch looks fine to me, however I'm not familiar with fortran. But no one objected so far, so I pushed it in, thanks. Vinzent 2010/2/24 Toon Verstraelen toon.verstrae...@gmail.com: --- doc/src/modules/printing.txt | 96 +++ sympy

[PATCH] initial fcode implementation

--- doc/src/modules/printing.txt | 96 +++ sympy/__init__.py |2 +- sympy/printing/__init__.py |1 + sympy/printing/fcode.py| 326 sympy/printing/tests/test_fcode.py | 217

[PATCH] Initial codegen implementation.

--- sympy/test_external/test_codegen_c_cc.py | 145 + sympy/utilities/codegen.py | 347 ++ sympy/utilities/tests/test_codegen.py| 54 + 3 files changed, 546 insertions(+), 0 deletions(-) create mode 100644

Initial codegen implementation

, double y, double z) { return z*(x + y); } The codegen function is based a more complex api with more possibilities. More info can be found as comments and the doc strings. Any comments are appreciated. (coding style, typo's, code design, milestones, ...) cheers, Toon -- ir. Toon