Re: [PATCH] Add a new Matrix.QRsolve method.

2009-11-29 Thread Ondrej Certik
Nice patch, it's in, thanks! On Sat, Nov 7, 2009 at 3:01 PM, Vinzent Steinberg vinzent.steinb...@googlemail.com wrote: Here is an improved patch. Vinzent 2009/8/13 Ondrej Certik ond...@certik.cz thanks! On Thu, Aug 13, 2009 at 6:15 AM, Vinzent Steinbergvinzent.steinb...@googlemail.com

Re: [PATCH] Add a new Matrix.QRsolve method.

2009-11-07 Thread Vinzent Steinberg
Here is an improved patch. Vinzent 2009/8/13 Ondrej Certik ond...@certik.cz thanks! On Thu, Aug 13, 2009 at 6:15 AM, Vinzent Steinbergvinzent.steinb...@googlemail.com wrote: Jochen, any progress on this? Your patch is ready to merge in my opinion, if you don't have have time to fix

Re: [PATCH] Add a new Matrix.QRsolve method.

2009-08-13 Thread Ondrej Certik
thanks! On Thu, Aug 13, 2009 at 6:15 AM, Vinzent Steinbergvinzent.steinb...@googlemail.com wrote: Jochen, any progress on this? Your patch is ready to merge in my opinion, if you don't have have time to fix the docstrings, I'll do this trivial stuff. :) Vinzent 2009/5/20 Ondrej Certik

Re: [PATCH] Add a new Matrix.QRsolve method.

2009-05-19 Thread Ondrej Certik
On Fri, May 15, 2009 at 4:15 AM, Vinzent Steinberg vinzent.steinb...@googlemail.com wrote: 2009/5/15 Jochen Voß jochen.v...@googlemail.com Hi, I'll be travelling for a few days and will be able to send a new patch only sometimes next week.  What I suggest to do is: 1) Remove the more

Re: [PATCH] Add a new Matrix.QRsolve method.

2009-05-14 Thread Riccardo Gori
Hello, thanks for the patch! Just a comment, see below: On Wednesday 13 May 2009 19:54:18 Jochen Voss wrote: The new method is slower than Matrix.LUsolve, but should be more stable. The commit also fixes a closeby comment and adds a new docstring. This fixes issue #907 from the issue

Re: [PATCH] Add a new Matrix.QRsolve method.

2009-05-14 Thread Jochen Voß
Hi Riccardo, 2009/5/14 Riccardo Gori goricca...@gmail.com: + # back substitution to solve R*x = y: + # We build up the result backwards in the vector 'x' and reverse it + # only in the end. + x = [] + n = R.lines + for j in range(n-1, -1, -1): + tmp = y[j,:] Why do you use y[j,:]

Re: [PATCH] Add a new Matrix.QRsolve method.

2009-05-14 Thread Jochen Voß
Hi, I'll be travelling for a few days and will be able to send a new patch only sometimes next week. What I suggest to do is: 1) Remove the more stable wording from the QRsolve docstring. 2) Add warnings to the both the LUsolve and the QRsolve docstrings, stating that these functions should