Nice patch, it's in, thanks! On Sat, Nov 7, 2009 at 3:01 PM, Vinzent Steinberg <vinzent.steinb...@googlemail.com> wrote: > Here is an improved patch. > > Vinzent > > 2009/8/13 Ondrej Certik <ond...@certik.cz> >> >> thanks! >> >> On Thu, Aug 13, 2009 at 6:15 AM, Vinzent >> Steinberg<vinzent.steinb...@googlemail.com> wrote: >> > Jochen, any progress on this? Your patch is ready to merge in my >> > opinion, if >> > you don't have have time to fix the docstrings, I'll do this trivial >> > stuff. >> > :) >> > >> > Vinzent >> > >> > 2009/5/20 Ondrej Certik <ond...@certik.cz> >> >> >> >> On Fri, May 15, 2009 at 4:15 AM, Vinzent Steinberg >> >> <vinzent.steinb...@googlemail.com> wrote: >> >> > 2009/5/15 Jochen Voß <jochen.v...@googlemail.com> >> >> >> >> >> >> Hi, >> >> >> >> >> >> I'll be travelling for a few days and will be able to send a new >> >> >> patch >> >> >> only sometimes next week. What I suggest to do is: >> >> >> >> >> >> 1) Remove the "more stable" wording from the QRsolve docstring. >> >> >> 2) Add warnings to the both the LUsolve and the QRsolve docstrings, >> >> >> stating that these functions should not be used for real matrics >> >> >> (and >> >> >> point to mpmath instead). >> >> >> 3) Add one or more examples with symbolic matrices to the tests. >> >> >> >> >> >> Does this sound ok for everybody? >> >> > >> >> > >> >> > Yeah, this sounds very reasonable, let's do it. >> >> > >> >> > Have a nice journey! >> >> >> >> Please ping me if you have something ready for review/merge. >> >> >> >> Thanks, >> >> Ondrej >> >> >> >> >> > >> > >> > > >> > >> >> > > > --~--~---------~--~----~------------~-------~--~----~ > You received this message because you are subscribed to the Google Groups > "sympy-patches" group. > To post to this group, send email to sympy-patches@googlegroups.com > To unsubscribe from this group, send email to > sympy-patches+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/sympy-patches?hl=en > -~----------~----~----~----~------~----~------~--~--- > >
-- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
