I think this error may be due to the whole rebasing issue. I have fixed this in
my last commit. Sorry for the confusion.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7606048
--
You received this message because you are subscribed
@certik I am uncertain of how to interpret the docstring error but I have
corrected what I believe was causing the error. I believe I have addressed all
the concerns.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7607337
--
You
This pull request [passes](http://travis-ci.org/sympy/sympy/builds/2073861)
(merged 5492ef80 into 15c2c89a).
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7607658
--
You received this message because you are subscribed to the
Thanks. This PR is +1 from me. I am just waiting for one last pass of Stefan's
bot to make sure the make html passes as well, and then I'll merge it.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7616275
--
You received this
**SymPy Bot Summary:** :red_circle: There were test failures.
@angadhn: Please fix the test failures.
*Test command:* setup.py test
*master hash*: 15c2c89ad53f5715d7d42a9daf29ae819a8779fb
*branch hash*: 5492ef80cfd9b63b0e65fb6432948ff6df012dd1
**Interpreter 1:** :eight_spoked_asterisk: All
Ok, so the make html has to be fixed. @angadhn, are you able to reproduce the
warning? Just do make html, try to build the docs and see if you can see the
warning.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7617497
--
You
m*r*v*N.z
return self.point.pos_from(point) ^ (self.mass *
self.point.vel(frame))
+
+def kinetic_energy(self, frame):
+Kinetic energy of the particle
+
+The kinetic energy, T, of a particle,P, is given by
+
+T = 0.5 * m *
@angadhn, there are several warnings, see my log here:
https://gist.github.com/3305562, and no warnings in master.
Do:
```
cd doc
make html
```
and let me know if you can reproduce my log. Then the next step will be to fix
the warnings.
---
Reply to this email directly or view it on GitHub:
m*r*v*N.z
return self.point.pos_from(point) ^ (self.mass *
self.point.vel(frame))
+
+def kinetic_energy(self, frame):
+Kinetic energy of the particle
+
+The kinetic energy, T, of a particle,P, is given by
+
+T = 0.5 * m *
m*r*v*N.z
return self.point.pos_from(point) ^ (self.mass *
self.point.vel(frame))
+
+def kinetic_energy(self, frame):
+Kinetic energy of the particle
+
+The kinetic energy, T, of a particle,P, is given by
+
+T = 0.5 * m *
This pull request [passes](http://travis-ci.org/sympy/sympy/builds/2082091)
(merged e16691a6 into dd8352a0).
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7631884
--
You received this message because you are subscribed to the
**[SymPy Bot][sympy-bot] Summary**: :red_circle: There were test failures
(merged angadhn/dev (e16691a608a1f55c30dd2a3b7bd1a74dde485111) into master
(dd8352a0582b91b286a98fabfb0af7486faeeb03)).
@angadhn: Please fix the test failures.
**Build HTML Docs:** :red_circle: There were test
**SymPy Bot Summary:** :eight_spoked_asterisk: All tests have passed.
*Test command:* setup.py test
*master hash*: dd8352a0582b91b286a98fabfb0af7486faeeb03
*branch hash*: e16691a608a1f55c30dd2a3b7bd1a74dde485111
**Interpreter 1:** :eight_spoked_asterisk: All tests have passed.
*Interpreter:*
@angadhn try `make clean; make html`.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7633594
--
You received this message because you are subscribed to the Google Groups
sympy-patches group.
To post to this group, send email to
still nothing. but it looks like the tests passed.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7633637
--
You received this message because you are subscribed to the Google Groups
sympy-patches group.
To post to this group, send
**[SymPy Bot][sympy-bot] Summary**: :red_circle: There were test failures
(merged angadhn/dev (e16691a608a1f55c30dd2a3b7bd1a74dde485111) into master
(dd8352a0582b91b286a98fabfb0af7486faeeb03)).
@angadhn: Please fix the test failures.
**Build HTML Docs:** :red_circle: There were test
I also can't reproduce it outside of sympy-bot. So I don't know what's going
on. Sphinx seems to be quite buggy.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7633847
--
You received this message because you are subscribed to the
**[SymPy Bot][sympy-bot] Summary**: :eight_spoked_asterisk: All tests have
passed (merged angadhn/dev (e16691a608a1f55c30dd2a3b7bd1a74dde485111) into
master (dd8352a0582b91b286a98fabfb0af7486faeeb03)).
**Build HTML Docs:** :eight_spoked_asterisk: All tests have
**SymPy Bot Summary:** :red_circle: There were test failures.
@angadhn: Please fix the test failures.
*Test command:* setup.py test
*master hash*: 0d88b25d001e4bf91d5ec36fddd06eb6cba77348
*branch hash*: caa2aa8836cadb302a33bf511f9f6264f762e9d5
**Interpreter 1:** :eight_spoked_asterisk: All
if not isinstance(bodylist, list):
raise TypeError('System elements must be supplied as a list')
else:
-angularmomentum_sys = 0
+angular_momentum_sys = 0
done.
---
Reply to this email directly or view it on GitHub:
I have also fixed the html doc errors in the latest commit and addressed all
issues brought up thus far.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7581049
--
You received this message because you are subscribed to the Google
This pull request [passes](http://travis-ci.org/sympy/sympy/builds/2065828)
(merged 57f1c042 into 0d88b25d).
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7581070
--
You received this message because you are subscribed to the
This pull request [passes](http://travis-ci.org/sympy/sympy/builds/2065891)
(merged 2fa49af6 into 0d88b25d).
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7581366
--
You received this message because you are subscribed to the
@angadhn, did you see my comment about rebasing? See also:
https://groups.google.com/d/topic/sympy/T2NfDo17wqc/discussion
Please stop rebasing, just keep pushing new patches in.
You still didn't address the points, that I mentioned:
https://github.com/sympy/sympy/pull/1407/files#r1306927
+ from sympy.physics.mechanics import Point, Particle, ReferenceFrame
+ from sympy.physics.mechanics import RigidBody, outer,
potential_energy
+ from sympy import symbols
+ M, m, g, h = symbols('M m g h')
+ N = ReferenceFrame('N')
+ O = Point('O')
+
10*N.z
+bodylist = list(bodylist)
fixed this. I didn't realise this was in the momenta functions too.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407/files#r1336833
--
You received this message because you are subscribed
10*N.x + 500*N.y
+bodylist = list(bodylist)
if not isinstance(bodylist, list):
same as below. addressed now.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407/files#r1336838
--
You received this message because you are
+
+Examples
+
+
+ from sympy.physics.mechanics import Particle, Point
+ from sympy import symbols
+ m, g, h = symbols('m g h')
+ O = Point('O')
+ P = Particle('P', O, m)
+ P.set_potential_energy(m * g * h)
+
+
@certik I have stopped rebasing. Sorry about that mess.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7597305
--
You received this message because you are subscribed to the Google Groups
sympy-patches group.
To post to this group,
This pull request [passes](http://travis-ci.org/sympy/sympy/builds/2070253)
(merged 50b2496f into 0d88b25d).
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7597848
--
You received this message because you are subscribed to the
**SymPy Bot Summary:** :red_circle: There were test failures.
@angadhn: Please fix the test failures.
*Test command:* setup.py test
*master hash*: 15c2c89ad53f5715d7d42a9daf29ae819a8779fb
*branch hash*: 50b2496fba8ef6df10c5032088b1c4965dbf2f7c
**Interpreter 1:** :eight_spoked_asterisk: All
@angadhn, can you please address all Aaron's and Jason's comments above? E.g.
things about the isinstance as well as the +=. Then we can merge it.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7571749
--
You received this message
Hi @certik, I believe I have already addressed the issues.
https://github.com/angadhn/sympy/commit/53b6bc2d1f2dd99f6d27a4c154481fa463b0a2ec
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7571850
--
You received this message because
First one note for any PR just keep adding patches to your branch, so that
we can quickly see what has changed and one can read the whole PR as a history
or story. If you rebase, then suddenly all the test results stop having any
sense.
Only at the very end, when the PR is ready to go in,
for e in bodylist:
if isinstance(e, (RigidBody, Particle)):
-lm_individual = e.linearmomentum(frame)
-linearmomentum_sys = linearmomentum_sys + lm_individual
+lm_individual = e.linear_momentum(frame)
+
10*N.x + 500*N.y
+bodylist = list(bodylist)
if not isinstance(bodylist, list):
@angadhn, this comment still applies I think.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407/files#r1328300
--
You received this message
+ from sympy.physics.mechanics import Point, Particle, ReferenceFrame
+ from sympy.physics.mechanics import RigidBody, outer,
potential_energy
+ from sympy import symbols
+ M, m, g, h = symbols('M m g h')
+ N = ReferenceFrame('N')
+ O = Point('O')
+
Looks like you rebased again...
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7572129
--
You received this message because you are subscribed to the Google Groups
sympy-patches group.
To post to this group, send email to
This pull request [passes](http://travis-ci.org/sympy/sympy/builds/2062711)
(merged 1ba125ec into bd49e6a0).
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7572588
--
You received this message because you are subscribed to the
Must've done that again mistakenly. Apologies.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7573127
--
You received this message because you are subscribed to the Google Groups
sympy-patches group.
To post to this group, send
+
+ from sympy.physics.mechanics import Particle, Point, outer
+ from sympy.physics.mechanics import RigidBody, ReferenceFrame
+ from sympy import symbols
+ b = ReferenceFrame('b')
+ M, g, h = symbols('M g h')
+ P = Point('P')
+ I =
This pull request [passes](http://travis-ci.org/sympy/sympy/builds/2063189)
(merged caa2aa88 into bd49e6a0).
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy/pull/1407#issuecomment-7573678
--
You received this message because you are subscribed to the
if not isinstance(bodylist, list):
raise TypeError('System elements must be supplied as a list')
else:
-linearmomentum_sys = 0
+linear_momentum_sys = 0
Would returning S(0) here be better, to get a SymPy object? I've had other
difficulties in mechanics
if not isinstance(bodylist, list):
raise TypeError('System elements must be supplied as a list')
else:
-angularmomentum_sys = 0
+angular_momentum_sys = 0
Same comment about S(0)
---
Reply to this email directly or view it on GitHub:
44 matches
Mail list logo
