Regarding the emojis being first -- I think the header looks fine as
is (with the emoji coming afterwards). I was talking about the
individual results lines. It is there that I would omit the
Interpreter information and just put the emoji first and the other
info after it for each interpreter. You
I think it would be better to do
:redcircle: **Python 3.2.1 (64-bit)**: Pass
It's strange not seeing what's what, especially with the docs build.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy-bot/pull/123#issuecomment-7607063
--
You received this
Or
**Python 3.2.1 (64-bit)**: :red_circle: Fail
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy-bot/pull/123#issuecomment-7607074
--
You received this message because you are subscribed to the Google Groups
sympy-patches group.
To post to this group,
I'd like feedback before I do this. I just realized that we can save even more
space. What if the output looked like this:
**[SymPy Bot][sympy-bot] Summary**: :red_circle: There were test failures
(merged mrocklin/trace (71ca3be7d64076064448d8210ba1f51063887cb7) into master
Yep, looks great to me.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy-bot/pull/123#issuecomment-7601235
--
You received this message because you are subscribed to the Google Groups
sympy-patches group.
To post to this group, send email to
Looks good to me too. Cuts down a lot of space with little loss of info.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy-bot/pull/123#issuecomment-7601798
--
You received this message because you are subscribed to the Google Groups
sympy-patches group.
To
OK, done. I don't see how the summaries could be made any smaller now, without
removing what is IMHO vital information, or making the formatting much harder
to read.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy-bot/pull/123#issuecomment-7602543
--
You
Since which interpreter was used is obvious from what follows on a given line,
the Interpreter 1-like prefixes could be removed so what would appear first
are the emoji icons.
---
Reply to this email directly or view it on GitHub:
https://github.com/sympy/sympy-bot/pull/123#issuecomment-7604206
Right. I was also thinking of replacing **Interpreter 1** with **Python 3.2.3
(64-bit)**. And I'm not sure if the operating system is super important, so it
can probably be removed (it's not even in the test header in the full report).
---
Reply to this email directly or view it on GitHub:
Regarding the order of the symbol, I did play with putting it before **SymPy
Bot** (see for example
https://github.com/asmeurer/GitHub-Issues-Test/issues/6#issuecomment-7473378),
and it just didn't look good. I don't know how it would look for the
interpreters, but probably it would look best
This pull request refactors SymPy-Bot a little bit.
Two chief things were done here (unfortunately it would have been too much work
to split them into separate commits):
1. SymPy-Bot now avoids doing redundant things more than once. In particular,
for each pull request, the merge is attempted
11 matches
Mail list logo
