Re: C code generator and much improved contraction logic

2010-08-02 Thread Øyvind Jensen
I have uploaded new fixes here: http://hosted.smartbear.com/sympy/go?page=ReviewDisplayreviewid=6 If you prefer github, I'll read those comments too. NOTE: the branch corresponding to the code on smartbear is called 'second_review_round':

Re: C code generator and much improved contraction logic

2010-07-28 Thread Ondrej Certik
On Tue, Jul 27, 2010 at 9:11 AM, Andy Ray Terrel andy.ter...@gmail.com wrote: On Tue, Jul 27, 2010 at 10:33 AM, Toon Verstraelen toon.verstrae...@ugent.be wrote: On 07/26/2010 10:36 PM, Ųyvind Jensen wrote: I have uploaded my work on the C code printer, C code generator and the tensor module

Re: C code generator and much improved contraction logic

2010-07-28 Thread Øyvind Jensen
Thanks for your comments everybody! When you are finished reviewing, please remember to push the button in smartbear so that we move on to the next phase. Øyvind On 28 Jul, 08:19, Ondrej Certik ond...@certik.cz wrote: On Tue, Jul 27, 2010 at 9:11 AM, Andy Ray Terrel andy.ter...@gmail.com

Re: C code generator and much improved contraction logic

2010-07-28 Thread Øyvind Jensen
On 27 Jul, 19:07, Brian Granger elliso...@gmail.com wrote: Oyvind, I don't know if you saw the new operator priority stuff that I did this weekend.  This will make it possible to more reliably have Expr subclasses that define their own binary special methods (__mul__, __add__, etc._) that

Re: C code generator and much improved contraction logic

2010-07-27 Thread Ondrej Certik
On Mon, Jul 26, 2010 at 1:36 PM, Øyvind Jensen jensen.oyv...@gmail.com wrote: I have uploaded my work on the C code printer, C code generator and the tensor module to smartbear for review: http://hosted.smartbear.com/sympy/go?page=ReviewDisplayreviewid=6 The ability to create code that loops

Re: C code generator and much improved contraction logic

2010-07-27 Thread Toon Verstraelen
On 07/26/2010 10:36 PM, Ųyvind Jensen wrote: I have uploaded my work on the C code printer, C code generator and the tensor module to smartbear for review: http://hosted.smartbear.com/sympy/go?page=ReviewDisplayreviewid=6 The ability to create code that loops over array arguments is much

Re: C code generator and much improved contraction logic

2010-07-27 Thread Toon Verstraelen
On 07/26/2010 10:36 PM, Ųyvind Jensen wrote: The code is also on github: http://github.com/jegerjensen/sympy/tree/codegen_C2 I have two failing tests on my system. __

Re: C code generator and much improved contraction logic

2010-07-27 Thread Andy Ray Terrel
On Tue, Jul 27, 2010 at 10:33 AM, Toon Verstraelen toon.verstrae...@ugent.be wrote: On 07/26/2010 10:36 PM, Ųyvind Jensen wrote: I have uploaded my work on the C code printer, C code generator and the tensor module to smartbear for review:

Re: C code generator and much improved contraction logic

2010-07-27 Thread Brian Granger
Oyvind, I don't know if you saw the new operator priority stuff that I did this weekend. This will make it possible to more reliably have Expr subclasses that define their own binary special methods (__mul__, __add__, etc._) that are always called based on priority of the class. This could be

Re: C code generator and much improved contraction logic

2010-07-27 Thread Andy Ray Terrel
On Tue, Jul 27, 2010 at 4:25 PM, Aaron S. Meurer asmeu...@gmail.com wrote: On Jul 27, 2010, at 10:11 AM, Andy Ray Terrel wrote: On Tue, Jul 27, 2010 at 10:33 AM, Toon Verstraelen toon.verstrae...@ugent.be wrote: On 07/26/2010 10:36 PM, Ųyvind Jensen wrote: I have uploaded my work on the C

C code generator and much improved contraction logic

2010-07-26 Thread Øyvind Jensen
I have uploaded my work on the C code printer, C code generator and the tensor module to smartbear for review: http://hosted.smartbear.com/sympy/go?page=ReviewDisplayreviewid=6 The ability to create code that loops over array arguments is much improved, mainly because the contraction logic is