I have uploaded new fixes here: http://hosted.smartbear.com/sympy/go?page=ReviewDisplay&reviewid=6
If you prefer github, I'll read those comments too. NOTE: the branch corresponding to the code on smartbear is called 'second_review_round': http://github.com/jegerjensen/sympy/tree/second_review_round Øyvind On 28 Jul, 23:52, Øyvind Jensen <jensen.oyv...@gmail.com> wrote: > On 27 Jul, 19:07, Brian Granger <elliso...@gmail.com> wrote: > > > Oyvind, > > > I don't know if you saw the new operator priority stuff that I did this > > weekend. This will make it possible to more reliably have Expr subclasses > > that define their own binary special methods (__mul__, __add__, etc._) that > > are always called based on priority of the class. This could be useful when > > multiplying tensors, etc. to do compatibility testing. Ondrej, pushed this > > to sympy master in the last 24 hours. > > I saw it, and thought it could be useful. However, I can not > prioritize it right now. Maybe we should just create an issue and do > it later when things have stabilized. > > Øyvind > > > > > Cheers, > > > Brian > > > On Mon, Jul 26, 2010 at 1:36 PM, Øyvind Jensen > > <jensen.oyv...@gmail.com>wrote: > > > > I have uploaded my work on the C code printer, C code generator and the > > > tensor module to smartbear for review: > > > >http://hosted.smartbear.com/sympy/go?page=ReviewDisplay&reviewid=6 > > > > The ability to create code that loops over array arguments is much > > > improved, mainly because the contraction logic is now handled in the > > > tensor module. I added Andy as reviewer, but anyone can add themselves > > > to the review to be able to create comments and defects. > > > > The code is also on github: > > >http://github.com/jegerjensen/sympy/tree/codegen_C2 > > > > Cheers, > > > Øyvind > > > > -- > > > You received this message because you are subscribed to the Google Groups > > > "sympy-patches" group. > > > To post to this group, send email to sympy-patc...@googlegroups.com. > > > To unsubscribe from this group, send email to > > > sympy-patches+unsubscr...@googlegroups.com<sympy-patches%2bunsubscr...@googlegroups.com> > > > . > > > For more options, visit this group at > > >http://groups.google.com/group/sympy-patches?hl=en. > > > -- > > Brian E. Granger, Ph.D. > > Assistant Professor of Physics > > Cal Poly State University, San Luis Obispo > > bgran...@calpoly.edu > > elliso...@gmail.com > > -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
