Re: Quantum Code Review

2010-08-19 Thread Vinzent Steinberg
2010/8/19 Aaron S. Meurer asmeu...@gmail.com: But you can still go back and fix commit messages, without changing any of the actual code history. Beware, changing the commit message also changes the commit hash I think. Vinzent -- You received this message because you are subscribed to the

Re: Quantum Code Review

2010-08-19 Thread Aaron S. Meurer
Yes it does (and as I said, you should use the original hash for the code samples). But it won't change any of the code history, or related attribution, which is what seemed to be worrying Brian. It's best to start a hilbert3 to do this if you are going to do it, so you don't loose anything.

Re: Quantum Code Review

2010-08-18 Thread Ondrej Certik
Hi Brian, Matt and Addison, I think the discussion wandered a bit from the review. 1) Git history: Do you want to keep your history? Does the history bring any value to sympy? From what I understood, many times it doesn't import, or tests don't pass. So it seems to me there isn't really any

Re: Quantum Code Review

2010-08-18 Thread Ondrej Certik
On Wed, Aug 18, 2010 at 2:22 PM, Ondrej Certik ond...@certik.cz wrote: Hi Brian, Matt and Addison, I think the discussion wandered a bit from the review. 1) Git history: Do you want to keep your history? Does the history bring any value to sympy? From what I understood, many times it

Re: Quantum Code Review

2010-08-18 Thread Aaron S. Meurer
On Aug 18, 2010, at 3:29 PM, Brian Granger wrote: On Wed, Aug 18, 2010 at 2:22 PM, Ondrej Certik ond...@certik.cz wrote: Hi Brian, Matt and Addison, I think the discussion wandered a bit from the review. 1) Git history: Do you want to keep your history? Does the history bring any

Re: Quantum Code Review

2010-08-18 Thread Aaron S. Meurer
On Aug 18, 2010, at 8:31 PM, Ondrej Certik wrote: On Wed, Aug 18, 2010 at 3:04 PM, Aaron S. Meurer asmeu...@gmail.com wrote: On Aug 18, 2010, at 3:29 PM, Brian Granger wrote: On Wed, Aug 18, 2010 at 2:22 PM, Ondrej Certik ond...@certik.cz wrote: Hi Brian, Matt and Addison, I think the

Re: Quantum Code Review

2010-08-17 Thread Brian Granger
On Tue, Aug 17, 2010 at 9:23 AM, Christian Muise christian.mu...@gmail.com wrote:   One thing that was pressed on me was the desire to have every commit run clean. Regardless of what point in the commit history, all tests should work, or at the very least the system should install (broken

Re: Quantum Code Review

2010-08-17 Thread Aaron S. Meurer
On Aug 17, 2010, at 11:07 AM, Brian Granger wrote: On Tue, Aug 17, 2010 at 9:23 AM, Christian Muise christian.mu...@gmail.com wrote: One thing that was pressed on me was the desire to have every commit run clean. Regardless of what point in the commit history, all tests should work, or at

Re: Quantum Code Review

2010-08-17 Thread Brian Granger
On Tue, Aug 17, 2010 at 12:06 PM, Vinzent Steinberg vinzent.steinb...@googlemail.com wrote: 2010/8/17 Brian Granger elliso...@gmail.com: On Tue, Aug 17, 2010 at 9:23 AM, Christian Muise christian.mu...@gmail.com wrote:   One thing that was pressed on me was the desire to have every commit run

Re: Quantum Code Review

2010-08-17 Thread Aaron S. Meurer
If you do decide to do rebasing, you should fix up some of the commit messages. DId [sic] nothing basically, Not much, and Nothing aren't very descriptive. Otherwise, try to do better in the future. You will be cursing yourself later when you go back to fix a bug and can't tell what a commit

Quantum Code Review

2010-08-16 Thread Matt Curry
Addison and I have been working on adding features to sympy.physics for our GSoC project. We started off working on separate branches, but, as time progressed, our two branches merged together. Here is a description of what we have added: We have added a general quantum mechanical framework using

Re: Quantum Code Review

2010-08-16 Thread Aaron S. Meurer
On Aug 16, 2010, at 4:05 PM, Ondrej Certik wrote: Hi Matt and Addison, great job! Some comments below: On Mon, Aug 16, 2010 at 12:19 PM, Matt Curry mattjcu...@gmail.com wrote: Addison and I have been working on adding features to sympy.physics for our GSoC project. We started off

Re: Quantum Code Review

2010-08-16 Thread Mateusz Paprocki
Hi, On Mon, Aug 16, 2010 at 03:05:27PM -0700, Ondrej Certik wrote: Hi Matt and Addison, great job! Some comments below: On Mon, Aug 16, 2010 at 12:19 PM, Matt Curry mattjcu...@gmail.com wrote: Addison and I have been working on adding features to sympy.physics for our GSoC project. We