new patches

2010-03-24 Thread Ondrej Certik
Hi, can someone please review my pu branch at github? It contains the following patches: $ git shortlog master..pu Ondrej Certik (7): test_sage: Use S() instead of sympify() atan2(y, x) can now be converted to/from Sage mpmath: test for sage_utils.bitcount test_sage.py: a

Re: new patches

2010-03-24 Thread Aaron S. Meurer
I am testing your branch now. I also left some comments on your github. Does the test_sage patch require sage to test? If it does, I won't be able to review that one, as I don't have sage installed. Aaron Meurer On Mar 24, 2010, at 5:10 PM, Ondrej Certik wrote: > Hi, > > can someone please

Re: new patches

2010-03-24 Thread Ondrej Certik
On Wed, Mar 24, 2010 at 4:22 PM, Aaron S. Meurer wrote: > I am testing your branch now.  I also left some comments on your github. > > Does the test_sage patch require sage to test?  If it does, I won't be able > to review that one, as I don't have sage installed. It does. Seems like noone was a

Re: new patches

2010-03-24 Thread Ondrej Certik
On Wed, Mar 24, 2010 at 4:26 PM, Ondrej Certik wrote: > On Wed, Mar 24, 2010 at 4:22 PM, Aaron S. Meurer wrote: >> I am testing your branch now.  I also left some comments on your github. >> >> Does the test_sage patch require sage to test?  If it does, I won't be able >> to review that one, as

Re: new patches

2010-03-24 Thread Toon Verstraelen
Ondrej Certik wrote: On Wed, Mar 24, 2010 at 4:22 PM, Aaron S. Meurer wrote: I am testing your branch now. I also left some comments on your github. Does the test_sage patch require sage to test? If it does, I won't be able to review that one, as I don't have sage installed. It does. Seem

Re: new patches

2010-03-25 Thread Ondrej Certik
On Wed, Mar 24, 2010 at 11:30 PM, Toon Verstraelen wrote: > Ondrej Certik wrote: >> >> On Wed, Mar 24, 2010 at 4:22 PM, Aaron S. Meurer >> wrote: >>> >>> I am testing your branch now.  I also left some comments on your github. >>> >>> Does the test_sage patch require sage to test?  If it does, I