Hello,
There are 17 commits that are waiting for review in my 1766 branch.
They are listed below. When I got feedback in a review, I made changes
and added another commit so, for example, 1778 has 3 parts. Those will
be squashed together when the review process is complete.
b13efb7 1772: integral
On Sun, May 9, 2010 at 4:45 AM, smichr wrote:
> Hello,
>
> There are 17 commits that are waiting for review in my 1766 branch.
> They are listed below. When I got feedback in a review, I made changes
> and added another commit so, for example, 1778 has 3 parts. Those will
> be squashed together wh
Only the commits before 1766 are really ready for pushing. I am still
pulling apart 1766.
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to this group, send email to sympy-patc...@googlegroups.com.
To unsubscribe from this group, send
2010/5/10 smichr
> Only the commits before 1766 are really ready for pushing. I am still
> pulling apart 1766.
As I already said, it would be much easier if you could create another
branch for review (1766-for-review) which contains only "stable" changes.
This would help to get it in faster.
V
On Mon, May 10, 2010 at 4:56 AM, Vinzent Steinberg
wrote:
> 2010/5/10 smichr
>>
>> Only the commits before 1766 are really ready for pushing. I am still
>> pulling apart 1766.
>
> As I already said, it would be much easier if you could create another
> branch for review (1766-for-review) which co
> > As I already said, it would be much easier if you could create another
> > branch for review (1766-for-review) which contains only "stable" changes.
> > This would help to get it in faster.
The commits before "1766--" are stable. I am not
changing those. I am only, as revie
>
> Do all tests (including the code quality) work for you? If so, we need
> to improve this.
You said "without the first commit". Do you mean without the latest
commit? In any case, all solvers.py tests pass in all commits. The
equal() can be used too make these pass on 32 or 64 bit systems if
n
ti., 11.05.2010 kl. 02.36 -0700, skrev smichr:
> > > As I already said, it would be much easier if you could create another
> > > branch for review (1766-for-review) which contains only "stable" changes.
> > > This would help to get it in faster.
>
> The commits before "1766--"
>
> I hope I am not adding confusion here, but I think Vincent just asked
> for something like
>
> ]$ git branch 1766-for-review ff50ca5221a22e9b80d1
>
> Øyvind
That's a helpful hint Øyvind. I see that that creates a branch with
the indicated commit as the HEAD. I'm willing to do what is most
help
2010/5/11 smichr
> >
> > I hope I am not adding confusion here, but I think Vincent just asked
> > for something like
> >
> > ]$ git branch 1766-for-review ff50ca5221a22e9b80d1
> >
> > Øyvind
>
> That's a helpful hint Øyvind. I see that that creates a branch with
> the indicated commit as the HEA
In the meanwhile, I've used Øyvind's hint to create branches numbered
as to commit number for all the commits in review and pushed them to
github. In cases where there are additions (like 1725a 1725b 1725c,
those are all in branch 1725).
ff50ca5 1936: Integral and Sum edits
c2a77c6 1919: unify var
On May 11, 4:43 pm, smichr wrote:
> In the meanwhile, I've used Øyvind's hint to create branches numbered
> as to commit number for all the commits in review and pushed them to
> github. In cases where there are additions (like 1725a 1725b 1725c,
> those are all in branch 1725).
My parenthesis
12 matches
Mail list logo
