[systemd-devel] [PATCH] fix tmpwatch service and timer installation.

2010-09-20 Thread Gustavo Sverzut Barbieri
--- Makefile.am | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/Makefile.am b/Makefile.am index b5b2a9d..3c3fa3b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -183,7 +183,9 @@ dist_systemunit_DATA = \ units/remount-rootfs.service \ units/prin

[systemd-devel] [PATCH] Allow disable of SysV init/rcN.d support at compile time

2010-09-20 Thread Gustavo Sverzut Barbieri
From: Fabiano Fidencio This patch adds a cpp definition HAVE_SYSV_COMPAT that is used to isolate code dealing with /etc/init.d and /etc/rcN.d for systems where it does not make sense (one that does not use sysv or one that is fully systemd native). The patch tries to be as little intrusive as po

Re: [systemd-devel] [PATCH] service: add support for Arch daemons

2010-09-20 Thread Lennart Poettering
On Tue, 21.09.10 00:32, Tom Gundersen (t...@jklm.no) wrote: > Hi Lennart, > > [sorry for sending it twice, forgot to include the ML] Applied. Thanks! Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list systemd-devel@lists.fr

Re: [systemd-devel] [PATCH 1/2] Allow disable of SysV init/rcN.d support at compile time

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 16:33, Fabiano Fidencio (fiden...@profusion.mobi) wrote: > static DEFINE_CONFIG_PARSE_ENUM(config_parse_kill_mode, kill_mode, KillMode, > "Failed to parse kill mode"); > > @@ -1446,7 +1448,9 @@ static void dump_items(FILE *f, const ConfigItem > *items) { > {

Re: [systemd-devel] [PATCH 2/2] Support IPv6-less systems with runtime check.

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 16:33, Fabiano Fidencio (fiden...@profusion.mobi) wrote: > This patch introduces socket_ipv6_is_supported() call that checks for > IPv6 availability. Code then check for it before using specific calls. Made some minimal changes (downgraded the error messages and made them more el

Re: [systemd-devel] [PATCH] gentoo: locale-setup support.

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 18:09, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) wrote: > > Hmpf. I am still a bit torn about this. We are not a shell, and > > interpreting those "export" lines looks like a call for desaster, > > because we don't actually really understand shell syntax here. For > > ex

Re: [systemd-devel] [PATCH] gentoo: vconsole-setup support.

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 19:07, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) wrote: > This patch is a bit bigger than expected since Gentoo being > non-standard in some places. > > 1. it is installing binaries at /usr/bin instead of /bin. > > 2. it is using CamelCase names for consolefonts. >

Re: [systemd-devel] [PATCH 1/2] Moving null check for strv_path_canonicalize inside function.

2010-09-20 Thread Lennart Poettering
On Thu, 16.09.10 23:30, Luis Felipe Strano Moraes (luis.str...@gmail.com) wrote: > strv_uniq(p->unit_path); > strv_uniq(p->sysvinit_path); > diff --git a/src/util.c b/src/util.c > index bdc194e..e9ff11b 100644 > --- a/src/util.c > +++ b/src/util.c > @@ -986,7 +986,9 @@ char **str

[systemd-devel] [PATCH] service: add support for Arch daemons

2010-09-20 Thread Tom Gundersen
Hi Lennart, [sorry for sending it twice, forgot to include the ML] On Mon, Sep 20, 2010 at 11:19 PM, Lennart Poettering wrote: > On Sun, 19.09.10 21:25, Tom Gundersen (t...@jklm.no) wrote: >> +#ifdef TARGET_ARCH >> +     if ((r = parse_env_file("/etc/rc.conf", NEWLINE, >> +                      

Re: [systemd-devel] [PATCH 2/2] Initializing socket_fd inside ask_agent.

2010-09-20 Thread Lennart Poettering
On Thu, 16.09.10 23:30, Luis Felipe Strano Moraes (luis.str...@gmail.com) wrote: > Garbage value could have been used if there was an error creating the > password file. Thanks, applied! Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel

Re: [systemd-devel] Systemd port on custom embedded linux

2010-09-20 Thread Lennart Poettering
On Fri, 17.09.10 16:49, Cristian Axenie (cristian.axe...@gmail.com) wrote: > Hi ! > I've managed to solve some problems appearing during boot but some persist. > The current setup makes the system freeze in the current step : > > [ 10.23] systemd[1]: systemd 8 running in system mode. (+PAM

Re: [systemd-devel] Couldn't find service

2010-09-20 Thread Lennart Poettering
On Sat, 18.09.10 00:45, Piavlo (pia...@cs.bgu.ac.il) wrote: > > On 09/14/2010 09:04 PM, Lennart Poettering wrote: > > > Also, > > recent systemd versions (>= 9) will spawn a getty on the > > configured kernel console anyway. > > That does not seem to be the case with systemd-10 > > I still ne

Re: [systemd-devel] [PATCH] systemctl: make condrestart equivalent to try-restart

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 20:45, Michal Schmidt (mschm...@redhat.com) wrote: > "condrestart" should be equivalent to "try-restart", i.e. it should be > translated into "TryRestartUnit". See > http://fedoraproject.org/wiki/Packaging:SysVInitScript#condrestart_and_try-restart > > Fixes https://bugzilla.redh

Re: [systemd-devel] How to disable unit under /lib/systemd/system/*.wants?

2010-09-20 Thread Lennart Poettering
On Sat, 18.09.10 21:39, Andrey Borzenkov (arvidj...@mail.ru) wrote: > Let's assume unit foo is installed as wanted by other unit under > $systemunitdir (/lib/systemd/system/bar.wants/foo). How can I now > disable it? systemctl (enable|disable) only manipulates links under > $pkgsysconfdir, so "

Re: [systemd-devel] [PATCH] Do not try to compile gtk apps if vala compiler is not present.

2010-09-20 Thread Lennart Poettering
On Fri, 17.09.10 16:17, Luis Felipe Strano Moraes (luis.str...@gmail.com) wrote: > > Not sure whether this is the best approach for this, basically my > problem was that even though configure properly detected that VALAC > was not present, it was trying to compile the gtk apps because > HAVE_GTK

[systemd-devel] [PATCH] gentoo: vconsole-setup support.

2010-09-20 Thread Gustavo Sverzut Barbieri
This patch is a bit bigger than expected since Gentoo being non-standard in some places. 1. it is installing binaries at /usr/bin instead of /bin. 2. it is using CamelCase names for consolefonts. 3. /etc/rc.conf:unicode=(yes|no) just forbids loadkeys and setfont "-u" options, but do not d

Re: [systemd-devel] [PATCH] gentoo: vconsole-setup support.

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 18:03, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) wrote: > > On Mon, Sep 20, 2010 at 5:44 PM, Lennart Poettering > wrote: > > On Sun, 19.09.10 21:23, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) > > wrote: > > > > Heya, > > > > Looks pretty good, but a few reques

Re: [systemd-devel] [PATCH] service: add support for Arch daemons

2010-09-20 Thread Lennart Poettering
On Sun, 19.09.10 21:25, Tom Gundersen (t...@jklm.no) wrote: > > +#ifdef TARGET_ARCH > + if ((r = parse_env_file("/etc/rc.conf", NEWLINE, > + "DAEMONS", &arch_daemons, > + NULL)) < 0) { > + if (r != -ENOENT) > +

Re: [systemd-devel] [PATCH] arch: set keymap, consolefont and locale

2010-09-20 Thread Lennart Poettering
On Sun, 19.09.10 23:07, Tom Gundersen (t...@jklm.no) wrote: > Hi, > > These two patches adds support for keymap, consolefont and locale > variables to Arch, similarly to how it is done for Fedora. Thanks! Both patches applied! Lennart -- Lennart Poettering - Red Hat, Inc.

Re: [systemd-devel] [PATCH] create parents of RANDOM_SEED if they do not exist.

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 10:04, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) wrote: > it may happen that parent directories of RANDOM_SEED do not exist, in > that case we must create it otherwise save will not work. Applied with minor modifications (i.e. I dropped the access() call since it is red

Re: [systemd-devel] [PATCH] gentoo: locale-setup support.

2010-09-20 Thread Gustavo Sverzut Barbieri
On Mon, Sep 20, 2010 at 5:58 PM, Lennart Poettering wrote: > On Sun, 19.09.10 21:32, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) > wrote: > > Heya, > >> Use locale variables from /etc/profile.env as Gentoo's openrc >> runscript does (tool that is used by /etc/init.d/* services). > > Hmpf.

Re: [systemd-devel] [PATCH] gentoo: vconsole-setup support.

2010-09-20 Thread Gustavo Sverzut Barbieri
On Mon, Sep 20, 2010 at 5:44 PM, Lennart Poettering wrote: > On Sun, 19.09.10 21:23, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) > wrote: > > Heya, > > Looks pretty good, but a few requests: > >> +#ifdef TARGET_GENTOO >> +/* Gentoo uses sys-apps/kbd that installs to /usr and have fonts in

Re: [systemd-devel] [PATCH] gentoo: locale-setup support.

2010-09-20 Thread Lennart Poettering
On Sun, 19.09.10 21:32, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) wrote: Heya, > Use locale variables from /etc/profile.env as Gentoo's openrc > runscript does (tool that is used by /etc/init.d/* services). Hmpf. I am still a bit torn about this. We are not a shell, and interpreting th

Re: [systemd-devel] [PATCH] gentoo: vconsole-setup support.

2010-09-20 Thread Lennart Poettering
On Sun, 19.09.10 21:23, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) wrote: Heya, Looks pretty good, but a few requests: > +#ifdef TARGET_GENTOO > +/* Gentoo uses sys-apps/kbd that installs to /usr and have fonts in > CamelCase */ > +#define KBD_LOADKEYS "/usr/bin/loadkeys" > +#define KB

[systemd-devel] [PATCH 2/2] Support IPv6-less systems with runtime check.

2010-09-20 Thread Fabiano Fidencio
This patch introduces socket_ipv6_is_supported() call that checks for IPv6 availability. Code then check for it before using specific calls. In order to be less intrusive, this patch avoids IPv6 entries being parsed at all, this way we don't get such entries in the system and all other code paths

[systemd-devel] [PATCH 1/2] Allow disable of SysV init/rcN.d support at compile time

2010-09-20 Thread Fabiano Fidencio
This patch adds a cpp definition HAVE_SYSV_COMPAT that is used to isolate code dealing with /etc/init.d and /etc/rcN.d for systems where it does not make sense (one that does not use sysv or one that is fully systemd native). The patch tries to be as little intrusive as possible, however in order

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Jack Byer
> I do this since long for /tmp. /var/tmp might be more difficult, as is > supposed to be able to carry large files. > According to the FHS /var/tmp must be persistent across reboots so it should never be tmpfs by default. ___ systemd-devel mailing list

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 20:55, Kay Sievers (kay.siev...@vrfy.org) wrote: > > On Mon, Sep 20, 2010 at 20:47, Lennart Poettering > wrote: > > On Mon, 20.09.10 09:16, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) > > wrote: > >>   - should we provide a "clean /tmp" service? > > > > Ideally, we'd jus

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 16:42, Michael Biebl (mbi...@gmail.com) wrote: > >>  - systemd-random-seed-save.service: why do we need this as a > >> separated service? Anyway, shouldn't it be in > >> /lib/systemd/system/shutdown.target.wants by default? > > > > Same. > > This clashes with our existing sysv in

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Kay Sievers
On Mon, Sep 20, 2010 at 20:47, Lennart Poettering wrote: > On Mon, 20.09.10 09:16, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) > wrote: >>   - should we provide a "clean /tmp" service? > > Ideally, we'd just mount tmpfs there, bug I guess given that we don't do > that we might want to add

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 10:13, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) wrote: > >>  - why do  xyz.mount does not automatically enables its xyz.service? > >> I've noticed that although I have /var/lock and /var/run in /etc/fstab > >> and systemd recognizes them to var-lock.mount and var-run.mo

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Lennart Poettering
On Mon, 20.09.10 09:16, Gustavo Sverzut Barbieri (barbi...@profusion.mobi) wrote: > Hi all, > > I was asking Lennart at #systemd, but as some questions were not > answered I'm asking them here as well: which services should be > enabled by default, and how? After these answers are agreed I'll >

[systemd-devel] [PATCH] systemctl: make condrestart equivalent to try-restart

2010-09-20 Thread Michal Schmidt
"condrestart" should be equivalent to "try-restart", i.e. it should be translated into "TryRestartUnit". See http://fedoraproject.org/wiki/Packaging:SysVInitScript#condrestart_and_try-restart Fixes https://bugzilla.redhat.com/show_bug.cgi?id=635780 --- src/systemctl.c |6 +++--- 1 files chan

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Ozan Çağlayan
On 20.09.2010 15:16, Gustavo Sverzut Barbieri wrote: > Hi all, > > - remount-rootfs.service: shouldn't it be in > /lib/systemd/system/sysinit.target.wants? Or maybe > /etc/systemd/system/sysinit.target.wants? People that do not use > initramfs/initrd will need this anyway, and AFAIK this is not

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Matthew Miller
On Mon, Sep 20, 2010 at 11:47:32AM -0400, Bill Nottingham wrote: > Sure, but an app that cleans /tmp (as opposed to a service that calls > that app) seems to be a bit out of systemd's scope. Particularly when there's already a perfectly good program which already does it, and which is useful for o

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Bill Nottingham
Gustavo Sverzut Barbieri (barbi...@profusion.mobi) said: > > Or, conversely, why not enable 12 by default? > > :-) Because when you add a link at "make install", you have to remove > it. If you add it manually, it will not be removed. So what happens > is that people that just use one for rescue

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Bill Nottingham
Gustavo Sverzut Barbieri (barbi...@profusion.mobi) said: > > On Mon, Sep 20, 2010 at 10:13:20AM -0300, Gustavo Sverzut Barbieri wrote: > >> Maybe integrate it into systemd? It's one single .c file as far as I > >> could check. > > > > What's the advantage of making this monolithic? > > not having

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Jens Persson
On Mon, Sep 20, 2010 at 4:42 PM, Michael Biebl wrote: > 2010/9/20 Kay Sievers : > > On Mon, Sep 20, 2010 at 14:16, Gustavo Sverzut Barbieri > > wrote: > >> - systemd-modules-load.service: why do we need this as a separated > >> service? > > > > What else would it be? > > > >> Anyway, shouldn't

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Jens Persson
On Mon, Sep 20, 2010 at 4:36 PM, Michael Biebl wrote: > 2010/9/20 Gustavo Sverzut Barbieri : > > - do we really need to install 6 getty services by default? can't we > > just install one and people that don't like to use 1 + screen enable > > more? It is a PITA to remove the links after every in

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Michael Biebl
2010/9/20 Kay Sievers : > On Mon, Sep 20, 2010 at 14:16, Gustavo Sverzut Barbieri > wrote: >>  - systemd-modules-load.service: why do we need this as a separated >> service? > > What else would it be? > >> Anyway, shouldn't it be in >> /lib/systemd/system/sysinit.target.wants by default? > > It sh

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Michael Biebl
2010/9/20 Gustavo Sverzut Barbieri : >  - do we really need to install 6 getty services by default? can't we > just install one and people that don't like to use 1 + screen enable > more? It is a PITA to remove the links after every installation of > systemd :-/ > Why are the re-enabled? Is that a

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Gustavo Sverzut Barbieri
On Mon, Sep 20, 2010 at 10:14 AM, Matthew Miller wrote: > On Mon, Sep 20, 2010 at 10:13:20AM -0300, Gustavo Sverzut Barbieri wrote: >> Maybe integrate it into systemd? It's one single .c file as far as I >> could check. > > What's the advantage of making this monolithic? not having to install an

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Gustavo Sverzut Barbieri
On Mon, Sep 20, 2010 at 10:08 AM, Matthew Miller wrote: > On Mon, Sep 20, 2010 at 09:16:10AM -0300, Gustavo Sverzut Barbieri wrote: >> while at it: >>   - do we really need to install 6 getty services by default? can't we >> just install one and people that don't like to use 1 + screen enable >> m

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Matthew Miller
On Mon, Sep 20, 2010 at 10:13:20AM -0300, Gustavo Sverzut Barbieri wrote: > Maybe integrate it into systemd? It's one single .c file as far as I > could check. What's the advantage of making this monolithic? -- Matthew Miller mat...@mattdm.org __

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Gustavo Sverzut Barbieri
On Mon, Sep 20, 2010 at 10:01 AM, Kay Sievers wrote: > On Mon, Sep 20, 2010 at 14:16, Gustavo Sverzut Barbieri > wrote: >>  - systemd-modules-load.service: why do we need this as a separated >> service? > > What else would it be? built-in systemd, just like locale setup? >> Anyway, shouldn't i

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Tomasz Torcz
On Mon, Sep 20, 2010 at 09:08:39AM -0400, Matthew Miller wrote: > On Mon, Sep 20, 2010 at 09:16:10AM -0300, Gustavo Sverzut Barbieri wrote: > > while at it: > > - do we really need to install 6 getty services by default? can't we > > just install one and people that don't like to use 1 + screen e

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Matthew Miller
On Mon, Sep 20, 2010 at 09:16:10AM -0300, Gustavo Sverzut Barbieri wrote: > while at it: > - do we really need to install 6 getty services by default? can't we > just install one and people that don't like to use 1 + screen enable > more? It is a PITA to remove the links after every installation

[systemd-devel] [PATCH] create parents of RANDOM_SEED if they do not exist.

2010-09-20 Thread Gustavo Sverzut Barbieri
it may happen that parent directories of RANDOM_SEED do not exist, in that case we must create it otherwise save will not work. --- src/random-seed.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/random-seed.c b/src/random-seed.c index 936ed47..2b3a61f 100644 -

Re: [systemd-devel] Services enabled by default?

2010-09-20 Thread Kay Sievers
On Mon, Sep 20, 2010 at 14:16, Gustavo Sverzut Barbieri wrote: >  - systemd-modules-load.service: why do we need this as a separated > service? What else would it be? > Anyway, shouldn't it be in > /lib/systemd/system/sysinit.target.wants by default? It should, yes. >  - systemd-vconsole-setup

[systemd-devel] Services enabled by default?

2010-09-20 Thread Gustavo Sverzut Barbieri
Hi all, I was asking Lennart at #systemd, but as some questions were not answered I'm asking them here as well: which services should be enabled by default, and how? After these answers are agreed I'll provide a patch to Makefile.am install rules. - systemd-modules-load.service: why do we need t